From: Rob Herring <robh@kernel.org>
To: "liangxu.xu" <liangxu.xu@mediatek.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
chunkuang.hu@kernel.org, p.zabel@pengutronix.de,
airlied@linux.ie, daniel@ffwll.ch,
krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com,
jitao.shi@mediatek.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Project_Global_Chrome_Upstream_Group@mediatek.com,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] dt-bindings: display: mediatek: dp: Add compatible for MediaTek MT8188
Date: Mon, 26 Sep 2022 16:54:40 -0500 [thread overview]
Message-ID: <20220926215440.GA2888681-robh@kernel.org> (raw)
In-Reply-To: <2afb5b7f761c7931eaf93f2f8a0fd268a39e1b02.camel@mediatek.com>
On Mon, Sep 26, 2022 at 10:52:04AM +0800, liangxu.xu wrote:
> On Fri, 2022-09-23 at 13:16 +0200, Krzysztof Kozlowski wrote:
> > On 23/09/2022 03:39, liangxu.xu@mediatek.com wrote:
> > > From: liangxu xu <liangxu.xu@mediatek.com>
> > >
> > > Add dt-binding documentation of dp for MediaTek MT8188 SoC.
> > >
> > > Signed-off-by: liangxu xu <liangxu.xu@mediatek.com>
> > > ---
> >
> > Where is the DTS? Where are driver changes?
> >
> > Best regards,
> > Krzysztof
> >
>
> Hi Krzysztof:
>
> If you want to see the synchronous changes of dts and binding files,
> then I will attach this binding file changes when sending dts later.
>
> The driver change of mt8188 reuses that of mt8195. The driver link is
> as follows:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/gpu/drm/mediatek/mtk_dp.c?id=48f4230642ee32a97ddf4be492838ce96089f040
So the 8188 block is backwards compatible with the 8195 block?
That's good, but not what your schema says because you have not defined
a fallback compatible for the driver to use.
Rob
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: "liangxu.xu" <liangxu.xu@mediatek.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
chunkuang.hu@kernel.org, p.zabel@pengutronix.de,
airlied@linux.ie, daniel@ffwll.ch,
krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com,
jitao.shi@mediatek.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Project_Global_Chrome_Upstream_Group@mediatek.com,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] dt-bindings: display: mediatek: dp: Add compatible for MediaTek MT8188
Date: Mon, 26 Sep 2022 16:54:40 -0500 [thread overview]
Message-ID: <20220926215440.GA2888681-robh@kernel.org> (raw)
In-Reply-To: <2afb5b7f761c7931eaf93f2f8a0fd268a39e1b02.camel@mediatek.com>
On Mon, Sep 26, 2022 at 10:52:04AM +0800, liangxu.xu wrote:
> On Fri, 2022-09-23 at 13:16 +0200, Krzysztof Kozlowski wrote:
> > On 23/09/2022 03:39, liangxu.xu@mediatek.com wrote:
> > > From: liangxu xu <liangxu.xu@mediatek.com>
> > >
> > > Add dt-binding documentation of dp for MediaTek MT8188 SoC.
> > >
> > > Signed-off-by: liangxu xu <liangxu.xu@mediatek.com>
> > > ---
> >
> > Where is the DTS? Where are driver changes?
> >
> > Best regards,
> > Krzysztof
> >
>
> Hi Krzysztof:
>
> If you want to see the synchronous changes of dts and binding files,
> then I will attach this binding file changes when sending dts later.
>
> The driver change of mt8188 reuses that of mt8195. The driver link is
> as follows:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/gpu/drm/mediatek/mtk_dp.c?id=48f4230642ee32a97ddf4be492838ce96089f040
So the 8188 block is backwards compatible with the 8195 block?
That's good, but not what your schema says because you have not defined
a fallback compatible for the driver to use.
Rob
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: "liangxu.xu" <liangxu.xu@mediatek.com>
Cc: chunkuang.hu@kernel.org, jitao.shi@mediatek.com,
devicetree@vger.kernel.org, airlied@linux.ie,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Project_Global_Chrome_Upstream_Group@mediatek.com,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
linux-mediatek@lists.infradead.org,
krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] dt-bindings: display: mediatek: dp: Add compatible for MediaTek MT8188
Date: Mon, 26 Sep 2022 16:54:40 -0500 [thread overview]
Message-ID: <20220926215440.GA2888681-robh@kernel.org> (raw)
In-Reply-To: <2afb5b7f761c7931eaf93f2f8a0fd268a39e1b02.camel@mediatek.com>
On Mon, Sep 26, 2022 at 10:52:04AM +0800, liangxu.xu wrote:
> On Fri, 2022-09-23 at 13:16 +0200, Krzysztof Kozlowski wrote:
> > On 23/09/2022 03:39, liangxu.xu@mediatek.com wrote:
> > > From: liangxu xu <liangxu.xu@mediatek.com>
> > >
> > > Add dt-binding documentation of dp for MediaTek MT8188 SoC.
> > >
> > > Signed-off-by: liangxu xu <liangxu.xu@mediatek.com>
> > > ---
> >
> > Where is the DTS? Where are driver changes?
> >
> > Best regards,
> > Krzysztof
> >
>
> Hi Krzysztof:
>
> If you want to see the synchronous changes of dts and binding files,
> then I will attach this binding file changes when sending dts later.
>
> The driver change of mt8188 reuses that of mt8195. The driver link is
> as follows:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/gpu/drm/mediatek/mtk_dp.c?id=48f4230642ee32a97ddf4be492838ce96089f040
So the 8188 block is backwards compatible with the 8195 block?
That's good, but not what your schema says because you have not defined
a fallback compatible for the driver to use.
Rob
next prev parent reply other threads:[~2022-09-26 21:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-23 1:39 [PATCH] dt-bindings: display: mediatek: dp: Add compatible for MediaTek MT8188 liangxu.xu
2022-09-23 1:39 ` liangxu.xu
2022-09-23 1:39 ` liangxu.xu
2022-09-23 11:16 ` Krzysztof Kozlowski
2022-09-23 11:16 ` Krzysztof Kozlowski
2022-09-23 11:16 ` Krzysztof Kozlowski
2022-09-26 2:52 ` liangxu.xu
2022-09-26 2:52 ` liangxu.xu
2022-09-26 2:52 ` liangxu.xu
2022-09-26 21:54 ` Rob Herring [this message]
2022-09-26 21:54 ` Rob Herring
2022-09-26 21:54 ` Rob Herring
2022-09-27 7:20 ` liangxu.xu
2022-09-27 7:20 ` liangxu.xu
2022-09-27 7:20 ` liangxu.xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220926215440.GA2888681-robh@kernel.org \
--to=robh@kernel.org \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=airlied@linux.ie \
--cc=chunkuang.hu@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jitao.shi@mediatek.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=liangxu.xu@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.