From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49685C07E9D for ; Tue, 27 Sep 2022 10:03:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231622AbiI0KDQ convert rfc822-to-8bit (ORCPT ); Tue, 27 Sep 2022 06:03:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52310 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231604AbiI0KDO (ORCPT ); Tue, 27 Sep 2022 06:03:14 -0400 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 03D01A924F; Tue, 27 Sep 2022 03:03:10 -0700 (PDT) Received: from fraeml705-chm.china.huawei.com (unknown [172.18.147.207]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4McFXM0s2Jz687Rd; Tue, 27 Sep 2022 18:01:55 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (7.191.163.240) by fraeml705-chm.china.huawei.com (10.206.15.54) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2375.31; Tue, 27 Sep 2022 12:03:07 +0200 Received: from localhost (10.202.226.42) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 27 Sep 2022 11:03:07 +0100 Date: Tue, 27 Sep 2022 11:03:05 +0100 From: Jonathan Cameron To: Bjorn Helgaas CC: Shuai Xue , , , , , , , , , Subject: Re: [PATCH v1 2/3] drivers/perf: add DesignWare PCIe PMU driver Message-ID: <20220927110305.000079cc@huawei.com> In-Reply-To: <20220926171857.GA1609097@bhelgaas> References: <89efd20f-65f2-c082-1eb4-4e308957ff59@linux.alibaba.com> <20220926171857.GA1609097@bhelgaas> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.29; i686-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8BIT X-Originating-IP: [10.202.226.42] X-ClientProxiedBy: lhrpeml100006.china.huawei.com (7.191.160.224) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Mon, 26 Sep 2022 12:18:57 -0500 Bjorn Helgaas wrote: > On Mon, Sep 26, 2022 at 09:31:34PM +0800, Shuai Xue wrote: > > 在 2022/9/23 PM11:54, Jonathan Cameron 写道: > > >> I found a similar definition in arch/ia64/pci/pci.c . > > >> > > >> #define PCI_SAL_ADDRESS(seg, bus, devfn, reg) \ > > >> (((u64) seg << 24) | (bus << 16) | (devfn << 8) | (reg)) > > >> > > >> Should we move it into a common header first? > > > > > > Maybe. The bus, devfn, reg part is standard bdf, but I don't think > > > the PCI 6.0 spec defined a version with the seg in the upper bits. > > > I'm not sure if we want to adopt that in LInux. > > > > I found lots of code use seg,bus,devfn,reg with format "%04x:%02x:%02x.%x", > > I am not quite familiar with PCIe spec. What do you think about it, Bjorn? > > The PCIe spec defines an address encoding for bus/device/function/reg > for the purposes of ECAM (PCIe r6.0, sec 7.2.2), but as far as I know, > it doesn't define anything similar that includes the segment. The > segment is really outside the scope of PCIe because each segment is a > completely separate PCIe hierarchy. It's beginning to get exposed in PCIe 6.0 as a result of enabling cross segment messages. Two places I know of that the segment can be seen in. Captured TLP headers with certain AER reported errors. Hierarchy ID Extended capability - this one takes some digging. Specifically 7.9.17.3 Hierarchy ID Data Register which if you follow link to 6.25 includes Segment Group Number. Anyhow, not particularly relevant here and it never occurs next to any of the BDF stuff but it is now (just about) in scope of PCIe. Jonathan > > So I probably wouldn't make this a generic definition. But if/when > you print things like this out, please do use the format spec you > mentioned above so it matches the style used elsewhere. > > Bjorn From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 16DBBC6FA86 for ; Tue, 27 Sep 2022 10:04:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vAIXEDnBFXxoK3OCjqr+vL5w0Gr80R87W6Ho+u/ZvHc=; b=E+BA1tqIZta0lL WhM6pK5xlj3973H5BYGFyitJIPD8p4i1X1/BvS/XPKKsEvJA1JYdU8kbQJmMSo8Nd0bMqe2izR+kY AvMNDdSjvVyybP+ROoas5UPa169ee42OBC8zrcQVTpZ2UvwTl9IHNveR4wzE2Ogk5+qTvB/d7aFrw UJIasG8N3cO/GN894Tj+xqitbdvgudnEbfmIbtIU9CcirY5e+bc0/Jh3a0JRboTRgoO3wR3K0erkq uK7itpWf9dREuMCS41X0AAoWE6ayg/VjNe98nN6AR67Q3D/cVv4dTu9ziXzrse5bj1YHo1zBk/TA5 NbI8AwSCWhjjRxasMZlA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1od7Qv-009jRt-9G; Tue, 27 Sep 2022 10:03:21 +0000 Received: from frasgout.his.huawei.com ([185.176.79.56]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1od7Qr-009jPR-2Y for linux-arm-kernel@lists.infradead.org; Tue, 27 Sep 2022 10:03:19 +0000 Received: from fraeml705-chm.china.huawei.com (unknown [172.18.147.207]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4McFXM0s2Jz687Rd; Tue, 27 Sep 2022 18:01:55 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (7.191.163.240) by fraeml705-chm.china.huawei.com (10.206.15.54) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2375.31; Tue, 27 Sep 2022 12:03:07 +0200 Received: from localhost (10.202.226.42) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 27 Sep 2022 11:03:07 +0100 Date: Tue, 27 Sep 2022 11:03:05 +0100 From: Jonathan Cameron To: Bjorn Helgaas CC: Shuai Xue , , , , , , , , , Subject: Re: [PATCH v1 2/3] drivers/perf: add DesignWare PCIe PMU driver Message-ID: <20220927110305.000079cc@huawei.com> In-Reply-To: <20220926171857.GA1609097@bhelgaas> References: <89efd20f-65f2-c082-1eb4-4e308957ff59@linux.alibaba.com> <20220926171857.GA1609097@bhelgaas> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.29; i686-w64-mingw32) MIME-Version: 1.0 X-Originating-IP: [10.202.226.42] X-ClientProxiedBy: lhrpeml100006.china.huawei.com (7.191.160.224) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220927_030317_294397_AAE0BB03 X-CRM114-Status: GOOD ( 20.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCAyNiBTZXAgMjAyMiAxMjoxODo1NyAtMDUwMApCam9ybiBIZWxnYWFzIDxoZWxnYWFz QGtlcm5lbC5vcmc+IHdyb3RlOgoKPiBPbiBNb24sIFNlcCAyNiwgMjAyMiBhdCAwOTozMTozNFBN ICswODAwLCBTaHVhaSBYdWUgd3JvdGU6Cj4gPiDlnKggMjAyMi85LzIzIFBNMTE6NTQsIEpvbmF0 aGFuIENhbWVyb24g5YaZ6YGTOiAgCj4gPiA+PiBJIGZvdW5kIGEgc2ltaWxhciBkZWZpbml0aW9u IGluIGFyY2gvaWE2NC9wY2kvcGNpLmMgLgo+ID4gPj4KPiA+ID4+IAkjZGVmaW5lIFBDSV9TQUxf QUREUkVTUyhzZWcsIGJ1cywgZGV2Zm4sIHJlZykJCVwKPiA+ID4+IAkoKCh1NjQpIHNlZyA8PCAy NCkgfCAoYnVzIDw8IDE2KSB8IChkZXZmbiA8PCA4KSB8IChyZWcpKQo+ID4gPj4KPiA+ID4+IFNo b3VsZCB3ZSBtb3ZlIGl0IGludG8gYSBjb21tb24gaGVhZGVyIGZpcnN0PyAgCj4gPiA+IAo+ID4g PiBNYXliZS4gVGhlIGJ1cywgZGV2Zm4sIHJlZyBwYXJ0IGlzIHN0YW5kYXJkIGJkZiwgYnV0IEkg ZG9uJ3QgdGhpbmsKPiA+ID4gdGhlIFBDSSA2LjAgc3BlYyBkZWZpbmVkIGEgdmVyc2lvbiB3aXRo IHRoZSBzZWcgaW4gdGhlIHVwcGVyIGJpdHMuCj4gPiA+IEknbSBub3Qgc3VyZSBpZiB3ZSB3YW50 IHRvIGFkb3B0IHRoYXQgaW4gTEludXguICAKPiA+IAo+ID4gSSBmb3VuZCBsb3RzIG9mIGNvZGUg dXNlIHNlZyxidXMsZGV2Zm4scmVnIHdpdGggZm9ybWF0ICIlMDR4OiUwMng6JTAyeC4leCIsCj4g PiBJIGFtIG5vdCBxdWl0ZSBmYW1pbGlhciB3aXRoIFBDSWUgc3BlYy4gV2hhdCBkbyB5b3UgdGhp bmsgYWJvdXQgaXQsIEJqb3JuPyAgCj4gCj4gVGhlIFBDSWUgc3BlYyBkZWZpbmVzIGFuIGFkZHJl c3MgZW5jb2RpbmcgZm9yIGJ1cy9kZXZpY2UvZnVuY3Rpb24vcmVnCj4gZm9yIHRoZSBwdXJwb3Nl cyBvZiBFQ0FNIChQQ0llIHI2LjAsIHNlYyA3LjIuMiksIGJ1dCBhcyBmYXIgYXMgSSBrbm93LAo+ IGl0IGRvZXNuJ3QgZGVmaW5lIGFueXRoaW5nIHNpbWlsYXIgdGhhdCBpbmNsdWRlcyB0aGUgc2Vn bWVudC4gIFRoZQo+IHNlZ21lbnQgaXMgcmVhbGx5IG91dHNpZGUgdGhlIHNjb3BlIG9mIFBDSWUg YmVjYXVzZSBlYWNoIHNlZ21lbnQgaXMgYQo+IGNvbXBsZXRlbHkgc2VwYXJhdGUgUENJZSBoaWVy YXJjaHkuCgpJdCdzIGJlZ2lubmluZyB0byBnZXQgZXhwb3NlZCBpbiBQQ0llIDYuMCBhcyBhIHJl c3VsdCBvZiBlbmFibGluZyBjcm9zcwpzZWdtZW50IG1lc3NhZ2VzLiBUd28gcGxhY2VzIEkga25v dyBvZiB0aGF0IHRoZSBzZWdtZW50IGNhbiBiZSBzZWVuIGluLgpDYXB0dXJlZCBUTFAgaGVhZGVy cyB3aXRoIGNlcnRhaW4gQUVSIHJlcG9ydGVkIGVycm9ycy4KSGllcmFyY2h5IElEIEV4dGVuZGVk IGNhcGFiaWxpdHkgLSB0aGlzIG9uZSB0YWtlcyBzb21lIGRpZ2dpbmcuClNwZWNpZmljYWxseSA3 LjkuMTcuMyBIaWVyYXJjaHkgSUQgRGF0YSBSZWdpc3RlciB3aGljaCBpZiB5b3UgZm9sbG93IAps aW5rIHRvIDYuMjUgaW5jbHVkZXMgU2VnbWVudCBHcm91cCBOdW1iZXIuIAoKQW55aG93LCBub3Qg cGFydGljdWxhcmx5IHJlbGV2YW50IGhlcmUgYW5kIGl0IG5ldmVyIG9jY3VycyBuZXh0IHRvCmFu eSBvZiB0aGUgQkRGIHN0dWZmIGJ1dCBpdCBpcyBub3cgKGp1c3QgYWJvdXQpIGluIHNjb3BlIG9m IFBDSWUuCgpKb25hdGhhbgoKCj4gCj4gU28gSSBwcm9iYWJseSB3b3VsZG4ndCBtYWtlIHRoaXMg YSBnZW5lcmljIGRlZmluaXRpb24uICBCdXQgaWYvd2hlbgo+IHlvdSBwcmludCB0aGluZ3MgbGlr ZSB0aGlzIG91dCwgcGxlYXNlIGRvIHVzZSB0aGUgZm9ybWF0IHNwZWMgeW91Cj4gbWVudGlvbmVk IGFib3ZlIHNvIGl0IG1hdGNoZXMgdGhlIHN0eWxlIHVzZWQgZWxzZXdoZXJlLgo+IAo+IEJqb3Ju CgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgt YXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQu b3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJt LWtlcm5lbAo=