From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2ECFC07E9D for ; Tue, 27 Sep 2022 10:04:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230057AbiI0KEo convert rfc822-to-8bit (ORCPT ); Tue, 27 Sep 2022 06:04:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54062 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229779AbiI0KEn (ORCPT ); Tue, 27 Sep 2022 06:04:43 -0400 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8F7491005E; Tue, 27 Sep 2022 03:04:39 -0700 (PDT) Received: from fraeml705-chm.china.huawei.com (unknown [172.18.147.226]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4McFbR4yb6z6HJG9; Tue, 27 Sep 2022 18:04:35 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (7.191.163.240) by fraeml705-chm.china.huawei.com (10.206.15.54) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2375.31; Tue, 27 Sep 2022 12:04:37 +0200 Received: from localhost (10.202.226.42) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 27 Sep 2022 11:04:36 +0100 Date: Tue, 27 Sep 2022 11:04:35 +0100 From: Jonathan Cameron To: Shuai Xue CC: Bjorn Helgaas , , , , , , , , , Subject: Re: [PATCH v1 2/3] drivers/perf: add DesignWare PCIe PMU driver Message-ID: <20220927110435.00005b4d@huawei.com> In-Reply-To: <7502d496-9ec1-1ca4-c643-376ec2aa662e@linux.alibaba.com> References: <20220926171857.GA1609097@bhelgaas> <7502d496-9ec1-1ca4-c643-376ec2aa662e@linux.alibaba.com> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.29; i686-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT X-Originating-IP: [10.202.226.42] X-ClientProxiedBy: lhrpeml100006.china.huawei.com (7.191.160.224) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Tue, 27 Sep 2022 13:13:29 +0800 Shuai Xue wrote: > 在 2022/9/27 AM1:18, Bjorn Helgaas 写道: > > On Mon, Sep 26, 2022 at 09:31:34PM +0800, Shuai Xue wrote: > >> 在 2022/9/23 PM11:54, Jonathan Cameron 写道: > >>>> I found a similar definition in arch/ia64/pci/pci.c . > >>>> > >>>> #define PCI_SAL_ADDRESS(seg, bus, devfn, reg) \ > >>>> (((u64) seg << 24) | (bus << 16) | (devfn << 8) | (reg)) > >>>> > >>>> Should we move it into a common header first? > >>> > >>> Maybe. The bus, devfn, reg part is standard bdf, but I don't think > >>> the PCI 6.0 spec defined a version with the seg in the upper bits. > >>> I'm not sure if we want to adopt that in LInux. > >> > >> I found lots of code use seg,bus,devfn,reg with format "%04x:%02x:%02x.%x", > >> I am not quite familiar with PCIe spec. What do you think about it, Bjorn? > > > > The PCIe spec defines an address encoding for bus/device/function/reg > > for the purposes of ECAM (PCIe r6.0, sec 7.2.2), but as far as I know, > > it doesn't define anything similar that includes the segment. The > > segment is really outside the scope of PCIe because each segment is a > > completely separate PCIe hierarchy. > > Thank you for your explanation. > > > > > So I probably wouldn't make this a generic definition. But if/when > > you print things like this out, please do use the format spec you > > mentioned above so it matches the style used elsewhere. > > > > Agree. The print format of bus/device/function/reg is "%04x:%02x:%02x.%x", > so I named the PMU as the same format. Then the usage flow would be: > > - lspci to get the device root port in format seg/bus/device/function/reg. > 10:00.0 PCI bridge: Device 1ded:8000 (rev 01) > - select its PMU name pcie_bdf_100000. > - monitor with perf: > perf stat -a -e pcie_bdf_200/Rx_PCIe_TLP_Data_Payload/ I think you probably want something in there to indicate it's an RP and the bdf part may be redundant... Jonathan > > Bjorn and Jonathan, are you happy with this flow? > > Thank you. > > Best Regards, > Shuai > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 09952C07E9D for ; Tue, 27 Sep 2022 10:05:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fpl+uyKGFzCsYg4fKfeBtIyhNptxfsLio9I78NT0Fac=; b=26RL8gBYc96TDP PUrq92dWh/NN4tPFaIWxLKkTBuc1bwdIXD4adDKuyQg7PBWHIDSs9b0pP5/pHyVsgHvYyppZStXmv lFj1k2e1GLnVlzD2YpjT0u8C9Xam7TbPuo4VxzmXc9gLS85lTPnX58gwCbW1+QOWG9HdfnA6SAaOn RPwu8Hff9FNkKWtnUFxG1Nzc5ngt1WLBtH3rdPZrqZMYy5ADQHcBxh0xsSAoqf/2a2PQfCSicGGo6 THSVhTRTv7Z6IldcDkJ3ELA2qbffKHZOG1N+/PiUhIk/ClijfheZs2r9BifAUFQr0iwsWDff0rjfI 1Zjf/fPGPIFNFlp+pV0Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1od7SE-009jlE-Ch; Tue, 27 Sep 2022 10:04:42 +0000 Received: from frasgout.his.huawei.com ([185.176.79.56]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1od7SB-009jk6-7O for linux-arm-kernel@lists.infradead.org; Tue, 27 Sep 2022 10:04:40 +0000 Received: from fraeml705-chm.china.huawei.com (unknown [172.18.147.226]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4McFbR4yb6z6HJG9; Tue, 27 Sep 2022 18:04:35 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (7.191.163.240) by fraeml705-chm.china.huawei.com (10.206.15.54) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2375.31; Tue, 27 Sep 2022 12:04:37 +0200 Received: from localhost (10.202.226.42) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 27 Sep 2022 11:04:36 +0100 Date: Tue, 27 Sep 2022 11:04:35 +0100 From: Jonathan Cameron To: Shuai Xue CC: Bjorn Helgaas , , , , , , , , , Subject: Re: [PATCH v1 2/3] drivers/perf: add DesignWare PCIe PMU driver Message-ID: <20220927110435.00005b4d@huawei.com> In-Reply-To: <7502d496-9ec1-1ca4-c643-376ec2aa662e@linux.alibaba.com> References: <20220926171857.GA1609097@bhelgaas> <7502d496-9ec1-1ca4-c643-376ec2aa662e@linux.alibaba.com> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.29; i686-w64-mingw32) MIME-Version: 1.0 X-Originating-IP: [10.202.226.42] X-ClientProxiedBy: lhrpeml100006.china.huawei.com (7.191.160.224) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220927_030439_436002_761EFBD2 X-CRM114-Status: GOOD ( 24.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCAyNyBTZXAgMjAyMiAxMzoxMzoyOSArMDgwMApTaHVhaSBYdWUgPHh1ZXNodWFpQGxp bnV4LmFsaWJhYmEuY29tPiB3cm90ZToKCj4g5ZyoIDIwMjIvOS8yNyBBTTE6MTgsIEJqb3JuIEhl bGdhYXMg5YaZ6YGTOgo+ID4gT24gTW9uLCBTZXAgMjYsIDIwMjIgYXQgMDk6MzE6MzRQTSArMDgw MCwgU2h1YWkgWHVlIHdyb3RlOiAgCj4gPj4g5ZyoIDIwMjIvOS8yMyBQTTExOjU0LCBKb25hdGhh biBDYW1lcm9uIOWGmemBkzogIAo+ID4+Pj4gSSBmb3VuZCBhIHNpbWlsYXIgZGVmaW5pdGlvbiBp biBhcmNoL2lhNjQvcGNpL3BjaS5jIC4KPiA+Pj4+Cj4gPj4+PiAJI2RlZmluZSBQQ0lfU0FMX0FE RFJFU1Moc2VnLCBidXMsIGRldmZuLCByZWcpCQlcCj4gPj4+PiAJKCgodTY0KSBzZWcgPDwgMjQp IHwgKGJ1cyA8PCAxNikgfCAoZGV2Zm4gPDwgOCkgfCAocmVnKSkKPiA+Pj4+Cj4gPj4+PiBTaG91 bGQgd2UgbW92ZSBpdCBpbnRvIGEgY29tbW9uIGhlYWRlciBmaXJzdD8gIAo+ID4+Pgo+ID4+PiBN YXliZS4gVGhlIGJ1cywgZGV2Zm4sIHJlZyBwYXJ0IGlzIHN0YW5kYXJkIGJkZiwgYnV0IEkgZG9u J3QgdGhpbmsKPiA+Pj4gdGhlIFBDSSA2LjAgc3BlYyBkZWZpbmVkIGEgdmVyc2lvbiB3aXRoIHRo ZSBzZWcgaW4gdGhlIHVwcGVyIGJpdHMuCj4gPj4+IEknbSBub3Qgc3VyZSBpZiB3ZSB3YW50IHRv IGFkb3B0IHRoYXQgaW4gTEludXguICAKPiA+Pgo+ID4+IEkgZm91bmQgbG90cyBvZiBjb2RlIHVz ZSBzZWcsYnVzLGRldmZuLHJlZyB3aXRoIGZvcm1hdCAiJTA0eDolMDJ4OiUwMnguJXgiLAo+ID4+ IEkgYW0gbm90IHF1aXRlIGZhbWlsaWFyIHdpdGggUENJZSBzcGVjLiBXaGF0IGRvIHlvdSB0aGlu ayBhYm91dCBpdCwgQmpvcm4/ICAKPiA+IAo+ID4gVGhlIFBDSWUgc3BlYyBkZWZpbmVzIGFuIGFk ZHJlc3MgZW5jb2RpbmcgZm9yIGJ1cy9kZXZpY2UvZnVuY3Rpb24vcmVnCj4gPiBmb3IgdGhlIHB1 cnBvc2VzIG9mIEVDQU0gKFBDSWUgcjYuMCwgc2VjIDcuMi4yKSwgYnV0IGFzIGZhciBhcyBJIGtu b3csCj4gPiBpdCBkb2Vzbid0IGRlZmluZSBhbnl0aGluZyBzaW1pbGFyIHRoYXQgaW5jbHVkZXMg dGhlIHNlZ21lbnQuICBUaGUKPiA+IHNlZ21lbnQgaXMgcmVhbGx5IG91dHNpZGUgdGhlIHNjb3Bl IG9mIFBDSWUgYmVjYXVzZSBlYWNoIHNlZ21lbnQgaXMgYQo+ID4gY29tcGxldGVseSBzZXBhcmF0 ZSBQQ0llIGhpZXJhcmNoeS4gIAo+IAo+IFRoYW5rIHlvdSBmb3IgeW91ciBleHBsYW5hdGlvbi4K PiAKPiA+IAo+ID4gU28gSSBwcm9iYWJseSB3b3VsZG4ndCBtYWtlIHRoaXMgYSBnZW5lcmljIGRl ZmluaXRpb24uICBCdXQgaWYvd2hlbgo+ID4geW91IHByaW50IHRoaW5ncyBsaWtlIHRoaXMgb3V0 LCBwbGVhc2UgZG8gdXNlIHRoZSBmb3JtYXQgc3BlYyB5b3UKPiA+IG1lbnRpb25lZCBhYm92ZSBz byBpdCBtYXRjaGVzIHRoZSBzdHlsZSB1c2VkIGVsc2V3aGVyZS4KPiA+ICAgCj4gCj4gQWdyZWUu IFRoZSBwcmludCBmb3JtYXQgb2YgYnVzL2RldmljZS9mdW5jdGlvbi9yZWcgaXMgIiUwNHg6JTAy eDolMDJ4LiV4IiwKPiBzbyBJIG5hbWVkIHRoZSBQTVUgYXMgdGhlIHNhbWUgZm9ybWF0LiBUaGVu IHRoZSB1c2FnZSBmbG93IHdvdWxkIGJlOgo+IAo+IC0gbHNwY2kgdG8gZ2V0IHRoZSBkZXZpY2Ug cm9vdCBwb3J0IGluIGZvcm1hdCBzZWcvYnVzL2RldmljZS9mdW5jdGlvbi9yZWcuCj4gCTEwOjAw LjAgUENJIGJyaWRnZTogRGV2aWNlIDFkZWQ6ODAwMCAocmV2IDAxKQo+IC0gc2VsZWN0IGl0cyBQ TVUgbmFtZSBwY2llX2JkZl8xMDAwMDAuCj4gLSBtb25pdG9yIHdpdGggcGVyZjoKPiAJcGVyZiBz dGF0IC1hIC1lIHBjaWVfYmRmXzIwMC9SeF9QQ0llX1RMUF9EYXRhX1BheWxvYWQvCgpJIHRoaW5r IHlvdSBwcm9iYWJseSB3YW50IHNvbWV0aGluZyBpbiB0aGVyZSB0byBpbmRpY2F0ZSBpdCdzIGFu IFJQCmFuZCB0aGUgYmRmIHBhcnQgbWF5IGJlIHJlZHVuZGFudC4uLgoKSm9uYXRoYW4KPiAKPiBC am9ybiBhbmQgSm9uYXRoYW4sIGFyZSB5b3UgaGFwcHkgd2l0aCB0aGlzIGZsb3c/Cj4gCj4gVGhh bmsgeW91Lgo+IAo+IEJlc3QgUmVnYXJkcywKPiBTaHVhaQo+IAoKCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBs aXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5m cmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK