From: Kees Cook <keescook@chromium.org>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H . Peter Anvin" <hpa@zytor.com>,
Peter Zijlstra <peterz@infradead.org>,
linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
llvm@lists.linux.dev, Andy Lutomirski <luto@kernel.org>
Subject: Re: [PATCH v3] x86, mem: move memmove to out of line assembler
Date: Tue, 27 Sep 2022 14:14:22 -0700 [thread overview]
Message-ID: <202209271413.314FCFC3@keescook> (raw)
In-Reply-To: <20220927210248.3950201-1-ndesaulniers@google.com>
On Tue, Sep 27, 2022 at 02:02:48PM -0700, Nick Desaulniers wrote:
> [...]
> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
> ---
> Changes v2 -> v3:
> * Fix bug I introduced in v1 when I changed one of temp register
> operands for one of the two instructions performing a mem to mem swap,
> but not the other instruction's operand, and discovered by Kees.
> Verified KUnit memcpy tests are passing via:
> $ ./tools/testing/kunit/kunit.py run --arch=i386 --make_options LLVM=1
> $ ./tools/testing/kunit/kunit.py run --arch=i386
> Fixed by using symbolic identifiers rather than open coded registers
> for the less-than-word-size temporary registers.
> * Expand the comment about callee saved registers on i386 with a
> reference to the psABI.
Thanks! This looks good.
Reviewed-by: Kees Cook <keescook@chromium.org>
Tested-by: Kees Cook <keescook@chromium.org>
--
Kees Cook
next prev parent reply other threads:[~2022-09-27 21:14 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-23 17:02 [PATCH] x86, mem: move memmove to out of line assembler Nick Desaulniers
2022-09-23 17:29 ` Linus Torvalds
2022-09-23 17:55 ` Nick Desaulniers
2022-09-23 18:05 ` Linus Torvalds
2022-09-27 17:03 ` Nick Desaulniers
2022-09-27 17:28 ` [PATCH v2] " Nick Desaulniers
2022-09-27 18:41 ` Kees Cook
2022-09-27 19:23 ` Kees Cook
2022-09-27 20:01 ` Nick Desaulniers
2022-09-27 20:36 ` Kees Cook
2022-09-27 21:02 ` [PATCH v3] " Nick Desaulniers
2022-09-27 21:14 ` Kees Cook [this message]
2022-09-28 7:24 ` Rasmus Villemoes
2022-09-28 19:00 ` Linus Torvalds
2022-09-28 19:06 ` Nick Desaulniers
2022-09-28 20:49 ` Nick Desaulniers
2022-09-28 21:05 ` [PATCH v4] " Nick Desaulniers
2022-09-28 22:03 ` Kees Cook
2022-09-29 7:01 ` Ingo Molnar
2022-09-29 8:02 ` Ingo Molnar
2022-09-29 17:26 ` Nick Desaulniers
2022-09-30 9:55 ` David Laight
2022-09-30 16:43 ` Nick Desaulniers
2022-09-30 16:46 ` Linus Torvalds
2022-09-30 18:55 ` [PATCH v5] " Nick Desaulniers
2022-09-30 10:14 ` [PATCH v4] " David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202209271413.314FCFC3@keescook \
--to=keescook@chromium.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=ndesaulniers@google.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.