From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A20D1C6FA8E for ; Tue, 27 Sep 2022 14:19:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232024AbiI0OTm (ORCPT ); Tue, 27 Sep 2022 10:19:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52854 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231835AbiI0OTi (ORCPT ); Tue, 27 Sep 2022 10:19:38 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 109B013F25 for ; Tue, 27 Sep 2022 07:19:34 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9D8F8619EB for ; Tue, 27 Sep 2022 14:19:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3BD79C43141; Tue, 27 Sep 2022 14:19:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664288373; bh=OrKVJXEi8szo1hPh5xE6W+Cneq3FaibL95qCVvytrFU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YpJLk43vHbkknbA/vtQbI3ZuQm6v/TldSs1KjQZlrFo25LJ63yd1wMNBr4hBFSYKy FoXeWNidnQwlea00LyNoSnOxiMgyLUSaQlOIXBMSZQ1DYNcsmHPgt1ecMyQTDVE7wO G1G3w0Jm/PQ6c8gVZqF7NHRGwV9rDjx22+Ctfvo8ypJiuh93IGgsuBVMdTXUKmrcOQ Ojzcf6FbewhvBf3rVYm2AW1HmllUFku9Kcf4hDF3dr649hb66UExASF64g+Dh+kAav gPztCPPhmmnbOBpN9cL01jXo0hxXxcvsP0tHWPEnHNfBSF7TWQWU8+0SIMkeJMQJ6h gvDgYiJ1UcKAw== From: =?UTF-8?q?Marek=20Beh=C3=BAn?= To: Lorenzo Pieralisi Cc: Bjorn Helgaas , Gregory CLEMENT , pali@kernel.org, =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, =?UTF-8?q?Marek=20Beh=C3=BAn?= , Lukas Wunner Subject: [PATCH v2 01/10] PCI: pciehp: Enable Command Completed Interrupt only if supported Date: Tue, 27 Sep 2022 16:19:17 +0200 Message-Id: <20220927141926.8895-2-kabel@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220927141926.8895-1-kabel@kernel.org> References: <20220927141926.8895-1-kabel@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org From: Pali Rohár The No Command Completed Support bit in the Slot Capabilities register indicates whether Command Completed Interrupt Enable is unsupported. We already check whether No Command Completed Support bit is set in pcie_wait_cmd(), and do not wait in this case. Let's not enable this Command Completed Interrupt at all if NCCS is set, so that when users dump configuration space from userspace, the dump does not confuse them by saying that Command Completed Interrupt is not supported, but it is enabled. Signed-off-by: Pali Rohár Signed-off-by: Marek Behún Reviewed-by: Lukas Wunner --- drivers/pci/hotplug/pciehp_hpc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/pci/hotplug/pciehp_hpc.c b/drivers/pci/hotplug/pciehp_hpc.c index 040ae076ec0e..10e9670eea0b 100644 --- a/drivers/pci/hotplug/pciehp_hpc.c +++ b/drivers/pci/hotplug/pciehp_hpc.c @@ -811,7 +811,9 @@ static void pcie_enable_notification(struct controller *ctrl) else cmd |= PCI_EXP_SLTCTL_PDCE; if (!pciehp_poll_mode) - cmd |= PCI_EXP_SLTCTL_HPIE | PCI_EXP_SLTCTL_CCIE; + cmd |= PCI_EXP_SLTCTL_HPIE; + if (!pciehp_poll_mode && !NO_CMD_CMPL(ctrl)) + cmd |= PCI_EXP_SLTCTL_CCIE; mask = (PCI_EXP_SLTCTL_PDCE | PCI_EXP_SLTCTL_ABPE | PCI_EXP_SLTCTL_PFDE | -- 2.35.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DB0AAC6FA82 for ; Tue, 27 Sep 2022 14:20:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rypwWUd/oBicYx8Hz/hI+hSeIZtBVzkxoRqMffIc9fg=; b=wfUHhv2lFbZ8nV 8GU8DGWyXiCVN7HXQu5S5frdOGf8XK+SJ9iCmcb5JsczsSS2woQv8qdYaKdN3ABO6C/hJ6MUkVHxa OK/zNGraXZCSRW90urQFijysyhkmxc0DxuycJLo1C+t74T7IGowHHTvt2kyTLZJ4MBVS6Yuzpkx+T ghcU8UuO9mhGaWF8XvNxUHkAf0NbymuDQFp94a0fgQ/uHARumz/wkXGet7zsauZtP5MvpUktPpRJy k9S73/XxGuZJ057Mr3avUKt94/b//cDgjSVSK7b6mwrVfVRRYqKLUobn1OF3wMKMoqm6csSkOMtTG Irezc6ZiVYychi4gP20w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1odBR5-00BB57-1I; Tue, 27 Sep 2022 14:19:47 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1odBQt-00BB01-T7 for linux-arm-kernel@lists.infradead.org; Tue, 27 Sep 2022 14:19:37 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 55209B81C15; Tue, 27 Sep 2022 14:19:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3BD79C43141; Tue, 27 Sep 2022 14:19:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664288373; bh=OrKVJXEi8szo1hPh5xE6W+Cneq3FaibL95qCVvytrFU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YpJLk43vHbkknbA/vtQbI3ZuQm6v/TldSs1KjQZlrFo25LJ63yd1wMNBr4hBFSYKy FoXeWNidnQwlea00LyNoSnOxiMgyLUSaQlOIXBMSZQ1DYNcsmHPgt1ecMyQTDVE7wO G1G3w0Jm/PQ6c8gVZqF7NHRGwV9rDjx22+Ctfvo8ypJiuh93IGgsuBVMdTXUKmrcOQ Ojzcf6FbewhvBf3rVYm2AW1HmllUFku9Kcf4hDF3dr649hb66UExASF64g+Dh+kAav gPztCPPhmmnbOBpN9cL01jXo0hxXxcvsP0tHWPEnHNfBSF7TWQWU8+0SIMkeJMQJ6h gvDgYiJ1UcKAw== From: =?UTF-8?q?Marek=20Beh=C3=BAn?= To: Lorenzo Pieralisi Cc: Bjorn Helgaas , Gregory CLEMENT , pali@kernel.org, =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, =?UTF-8?q?Marek=20Beh=C3=BAn?= , Lukas Wunner Subject: [PATCH v2 01/10] PCI: pciehp: Enable Command Completed Interrupt only if supported Date: Tue, 27 Sep 2022 16:19:17 +0200 Message-Id: <20220927141926.8895-2-kabel@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220927141926.8895-1-kabel@kernel.org> References: <20220927141926.8895-1-kabel@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220927_071936_104431_8C30F475 X-CRM114-Status: GOOD ( 14.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org RnJvbTogUGFsaSBSb2jDoXIgPHBhbGlAa2VybmVsLm9yZz4KClRoZSBObyBDb21tYW5kIENvbXBs ZXRlZCBTdXBwb3J0IGJpdCBpbiB0aGUgU2xvdCBDYXBhYmlsaXRpZXMgcmVnaXN0ZXIKaW5kaWNh dGVzIHdoZXRoZXIgQ29tbWFuZCBDb21wbGV0ZWQgSW50ZXJydXB0IEVuYWJsZSBpcyB1bnN1cHBv cnRlZC4KCldlIGFscmVhZHkgY2hlY2sgd2hldGhlciBObyBDb21tYW5kIENvbXBsZXRlZCBTdXBw b3J0IGJpdCBpcyBzZXQgaW4KcGNpZV93YWl0X2NtZCgpLCBhbmQgZG8gbm90IHdhaXQgaW4gdGhp cyBjYXNlLgoKTGV0J3Mgbm90IGVuYWJsZSB0aGlzIENvbW1hbmQgQ29tcGxldGVkIEludGVycnVw dCBhdCBhbGwgaWYgTkNDUyBpcyBzZXQsCnNvIHRoYXQgd2hlbiB1c2VycyBkdW1wIGNvbmZpZ3Vy YXRpb24gc3BhY2UgZnJvbSB1c2Vyc3BhY2UsIHRoZSBkdW1wCmRvZXMgbm90IGNvbmZ1c2UgdGhl bSBieSBzYXlpbmcgdGhhdCBDb21tYW5kIENvbXBsZXRlZCBJbnRlcnJ1cHQgaXMgbm90CnN1cHBv cnRlZCwgYnV0IGl0IGlzIGVuYWJsZWQuCgpTaWduZWQtb2ZmLWJ5OiBQYWxpIFJvaMOhciA8cGFs aUBrZXJuZWwub3JnPgpTaWduZWQtb2ZmLWJ5OiBNYXJlayBCZWjDum4gPGthYmVsQGtlcm5lbC5v cmc+ClJldmlld2VkLWJ5OiBMdWthcyBXdW5uZXIgPGx1a2FzQHd1bm5lci5kZT4KLS0tCiBkcml2 ZXJzL3BjaS9ob3RwbHVnL3BjaWVocF9ocGMuYyB8IDQgKysrLQogMSBmaWxlIGNoYW5nZWQsIDMg aW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL2RyaXZlcnMvcGNpL2hv dHBsdWcvcGNpZWhwX2hwYy5jIGIvZHJpdmVycy9wY2kvaG90cGx1Zy9wY2llaHBfaHBjLmMKaW5k ZXggMDQwYWUwNzZlYzBlLi4xMGU5NjcwZWVhMGIgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvcGNpL2hv dHBsdWcvcGNpZWhwX2hwYy5jCisrKyBiL2RyaXZlcnMvcGNpL2hvdHBsdWcvcGNpZWhwX2hwYy5j CkBAIC04MTEsNyArODExLDkgQEAgc3RhdGljIHZvaWQgcGNpZV9lbmFibGVfbm90aWZpY2F0aW9u KHN0cnVjdCBjb250cm9sbGVyICpjdHJsKQogCWVsc2UKIAkJY21kIHw9IFBDSV9FWFBfU0xUQ1RM X1BEQ0U7CiAJaWYgKCFwY2llaHBfcG9sbF9tb2RlKQotCQljbWQgfD0gUENJX0VYUF9TTFRDVExf SFBJRSB8IFBDSV9FWFBfU0xUQ1RMX0NDSUU7CisJCWNtZCB8PSBQQ0lfRVhQX1NMVENUTF9IUElF OworCWlmICghcGNpZWhwX3BvbGxfbW9kZSAmJiAhTk9fQ01EX0NNUEwoY3RybCkpCisJCWNtZCB8 PSBQQ0lfRVhQX1NMVENUTF9DQ0lFOwogCiAJbWFzayA9IChQQ0lfRVhQX1NMVENUTF9QRENFIHwg UENJX0VYUF9TTFRDVExfQUJQRSB8CiAJCVBDSV9FWFBfU0xUQ1RMX1BGREUgfAotLSAKMi4zNS4x CgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgt YXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQu b3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJt LWtlcm5lbAo=