From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DD34C6FA82 for ; Tue, 27 Sep 2022 13:39:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231536AbiI0Njx convert rfc822-to-8bit (ORCPT ); Tue, 27 Sep 2022 09:39:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41320 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231425AbiI0Njx (ORCPT ); Tue, 27 Sep 2022 09:39:53 -0400 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 17A1C3FA2A; Tue, 27 Sep 2022 06:39:52 -0700 (PDT) Received: from fraeml737-chm.china.huawei.com (unknown [172.18.147.200]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4McLLN6tv7z67kws; Tue, 27 Sep 2022 21:38:36 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (7.191.163.240) by fraeml737-chm.china.huawei.com (10.206.15.218) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 27 Sep 2022 15:39:49 +0200 Received: from localhost (10.202.226.42) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 27 Sep 2022 14:39:49 +0100 Date: Tue, 27 Sep 2022 14:39:48 +0100 From: Jonathan Cameron To: Shuai Xue CC: Robin Murphy , Bjorn Helgaas , , , , , , , , Subject: Re: [PATCH v1 2/3] drivers/perf: add DesignWare PCIe PMU driver Message-ID: <20220927143948.00004c43@huawei.com> In-Reply-To: <2085a695-7fa2-b560-3164-c62cb17dd5f7@linux.alibaba.com> References: <20220926171857.GA1609097@bhelgaas> <7502d496-9ec1-1ca4-c643-376ec2aa662e@linux.alibaba.com> <20220927110435.00005b4d@huawei.com> <5372edb4-5717-42a0-142e-91657a9b18c3@arm.com> <2085a695-7fa2-b560-3164-c62cb17dd5f7@linux.alibaba.com> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.29; i686-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT X-Originating-IP: [10.202.226.42] X-ClientProxiedBy: lhrpeml500004.china.huawei.com (7.191.163.9) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Tue, 27 Sep 2022 20:49:26 +0800 Shuai Xue wrote: > + Jonathan > > 在 2022/9/27 PM6:14, Robin Murphy 写道: > > On 2022-09-27 11:04, Jonathan Cameron wrote: > >> On Tue, 27 Sep 2022 13:13:29 +0800 > >> Shuai Xue wrote: > >> > >>> 在 2022/9/27 AM1:18, Bjorn Helgaas 写道: > >>>> On Mon, Sep 26, 2022 at 09:31:34PM +0800, Shuai Xue wrote: > >>>>> 在 2022/9/23 PM11:54, Jonathan Cameron 写道: > >>>>>>> I found a similar definition in arch/ia64/pci/pci.c . > >>>>>>> > >>>>>>>     #define PCI_SAL_ADDRESS(seg, bus, devfn, reg)        \ > >>>>>>>     (((u64) seg << 24) | (bus << 16) | (devfn << 8) | (reg)) > >>>>>>> > >>>>>>> Should we move it into a common header first? > >>>>>> > >>>>>> Maybe. The bus, devfn, reg part is standard bdf, but I don't think > >>>>>> the PCI 6.0 spec defined a version with the seg in the upper bits. > >>>>>> I'm not sure if we want to adopt that in LInux. > >>>>> > >>>>> I found lots of code use seg,bus,devfn,reg with format "%04x:%02x:%02x.%x", > >>>>> I am not quite familiar with PCIe spec. What do you think about it, Bjorn? > >>>> > >>>> The PCIe spec defines an address encoding for bus/device/function/reg > >>>> for the purposes of ECAM (PCIe r6.0, sec 7.2.2), but as far as I know, > >>>> it doesn't define anything similar that includes the segment.  The > >>>> segment is really outside the scope of PCIe because each segment is a > >>>> completely separate PCIe hierarchy. > >>> > >>> Thank you for your explanation. > >>> > >>>> > >>>> So I probably wouldn't make this a generic definition.  But if/when > >>>> you print things like this out, please do use the format spec you > >>>> mentioned above so it matches the style used elsewhere. > >>>>    > >>> > >>> Agree. The print format of bus/device/function/reg is "%04x:%02x:%02x.%x", > >>> so I named the PMU as the same format. Then the usage flow would be: > >>> > >>> - lspci to get the device root port in format seg/bus/device/function/reg. > >>>     10:00.0 PCI bridge: Device 1ded:8000 (rev 01) > >>> - select its PMU name pcie_bdf_100000. > >>> - monitor with perf: > >>>     perf stat -a -e pcie_bdf_100000/Rx_PCIe_TLP_Data_Payload/ > >> > >> I think you probably want something in there to indicate it's an RP > >> and the bdf part may be redundant... > > > > Indeed that seems horribly unclear; personally I reckon something like "dw_pcie_200" would be more appropriate. The address is just a disambiguator between multiple instances so doesn't need any further emphasis, but what is crucial to the user is exactly what kind of PMU it is (especially if there's potential for other unrelated PCIe functions to start exposing their own different PMUs). > > I see your point. The current prefix `pcie_bdf` is not appropriate, > > - it does not indicate it is for a root point as Jonathan mentioned. > - its prefix is not `dwc` > > Is dwc_rootport_100000 more appropriate? > > - `dwc` indicates the PMU is for Synopsys DesignWare Cores PCIe controller IP > - `rootport` indicates the PMU is for a root port device > - `100000` indicates the device address Looks good to me. J > > > Thank you. > > Best Regards, > Shuai > > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0B656C07E9D for ; Tue, 27 Sep 2022 13:41:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=eefyEIpCqpZGr5JjspSaB7gvFlfS7HaaqHwWx9If4vg=; b=zfcJ+/aB5bKHaM NOLg+5sRb9BXyq1hyZg4LPKIyiwIXmUvDdTzTx1XIzgwfkdtKwnNHCS3J4ZBMUfJSbvCpSIK/03SF x+m1ddtbw3z2dU+sJPKsGQjYSKdTMVB0I6Rd/rqhrBJQwodVTQEwBps6V9RM6QP0sygkpzg+X/ZWA H6oahrloy/4716yk4pO3esOVNW/S1Oa9NPN5BTqJmJg7zHUL2drTktR0C2LcDp3AUNW1Wqqk3kcNH N9LPAIGDIDfKroCw7f9TFrjjcT8Jx7LhtzwKjJ6fVVmAln1hA8sHj8lhP54nddGG+IB1TrgR6/U74 8vmwFabQwHzJOWRT+5kg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1odAob-00AyWM-7J; Tue, 27 Sep 2022 13:40:01 +0000 Received: from frasgout.his.huawei.com ([185.176.79.56]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1odAoW-00Ay6w-4Q for linux-arm-kernel@lists.infradead.org; Tue, 27 Sep 2022 13:39:58 +0000 Received: from fraeml737-chm.china.huawei.com (unknown [172.18.147.200]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4McLLN6tv7z67kws; Tue, 27 Sep 2022 21:38:36 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (7.191.163.240) by fraeml737-chm.china.huawei.com (10.206.15.218) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 27 Sep 2022 15:39:49 +0200 Received: from localhost (10.202.226.42) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 27 Sep 2022 14:39:49 +0100 Date: Tue, 27 Sep 2022 14:39:48 +0100 From: Jonathan Cameron To: Shuai Xue CC: Robin Murphy , Bjorn Helgaas , , , , , , , , Subject: Re: [PATCH v1 2/3] drivers/perf: add DesignWare PCIe PMU driver Message-ID: <20220927143948.00004c43@huawei.com> In-Reply-To: <2085a695-7fa2-b560-3164-c62cb17dd5f7@linux.alibaba.com> References: <20220926171857.GA1609097@bhelgaas> <7502d496-9ec1-1ca4-c643-376ec2aa662e@linux.alibaba.com> <20220927110435.00005b4d@huawei.com> <5372edb4-5717-42a0-142e-91657a9b18c3@arm.com> <2085a695-7fa2-b560-3164-c62cb17dd5f7@linux.alibaba.com> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.29; i686-w64-mingw32) MIME-Version: 1.0 X-Originating-IP: [10.202.226.42] X-ClientProxiedBy: lhrpeml500004.china.huawei.com (7.191.163.9) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220927_063956_483963_0528B37A X-CRM114-Status: GOOD ( 28.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCAyNyBTZXAgMjAyMiAyMDo0OToyNiArMDgwMApTaHVhaSBYdWUgPHh1ZXNodWFpQGxp bnV4LmFsaWJhYmEuY29tPiB3cm90ZToKCj4gKyBKb25hdGhhbgo+IAo+IOWcqCAyMDIyLzkvMjcg UE02OjE0LCBSb2JpbiBNdXJwaHkg5YaZ6YGTOgo+ID4gT24gMjAyMi0wOS0yNyAxMTowNCwgSm9u YXRoYW4gQ2FtZXJvbiB3cm90ZTogIAo+ID4+IE9uIFR1ZSwgMjcgU2VwIDIwMjIgMTM6MTM6Mjkg KzA4MDAKPiA+PiBTaHVhaSBYdWUgPHh1ZXNodWFpQGxpbnV4LmFsaWJhYmEuY29tPiB3cm90ZToK PiA+PiAgCj4gPj4+IOWcqCAyMDIyLzkvMjcgQU0xOjE4LCBCam9ybiBIZWxnYWFzIOWGmemBkzog IAo+ID4+Pj4gT24gTW9uLCBTZXAgMjYsIDIwMjIgYXQgMDk6MzE6MzRQTSArMDgwMCwgU2h1YWkg WHVlIHdyb3RlOiAgCj4gPj4+Pj4g5ZyoIDIwMjIvOS8yMyBQTTExOjU0LCBKb25hdGhhbiBDYW1l cm9uIOWGmemBkzogIAo+ID4+Pj4+Pj4gSSBmb3VuZCBhIHNpbWlsYXIgZGVmaW5pdGlvbiBpbiBh cmNoL2lhNjQvcGNpL3BjaS5jIC4KPiA+Pj4+Pj4+Cj4gPj4+Pj4+PiDCoMKgwqDCoCNkZWZpbmUg UENJX1NBTF9BRERSRVNTKHNlZywgYnVzLCBkZXZmbiwgcmVnKcKgwqDCoMKgwqDCoMKgIFwKPiA+ Pj4+Pj4+IMKgwqDCoMKgKCgodTY0KSBzZWcgPDwgMjQpIHwgKGJ1cyA8PCAxNikgfCAoZGV2Zm4g PDwgOCkgfCAocmVnKSkKPiA+Pj4+Pj4+Cj4gPj4+Pj4+PiBTaG91bGQgd2UgbW92ZSBpdCBpbnRv IGEgY29tbW9uIGhlYWRlciBmaXJzdD8gIAo+ID4+Pj4+Pgo+ID4+Pj4+PiBNYXliZS4gVGhlIGJ1 cywgZGV2Zm4sIHJlZyBwYXJ0IGlzIHN0YW5kYXJkIGJkZiwgYnV0IEkgZG9uJ3QgdGhpbmsKPiA+ Pj4+Pj4gdGhlIFBDSSA2LjAgc3BlYyBkZWZpbmVkIGEgdmVyc2lvbiB3aXRoIHRoZSBzZWcgaW4g dGhlIHVwcGVyIGJpdHMuCj4gPj4+Pj4+IEknbSBub3Qgc3VyZSBpZiB3ZSB3YW50IHRvIGFkb3B0 IHRoYXQgaW4gTEludXguICAKPiA+Pj4+Pgo+ID4+Pj4+IEkgZm91bmQgbG90cyBvZiBjb2RlIHVz ZSBzZWcsYnVzLGRldmZuLHJlZyB3aXRoIGZvcm1hdCAiJTA0eDolMDJ4OiUwMnguJXgiLAo+ID4+ Pj4+IEkgYW0gbm90IHF1aXRlIGZhbWlsaWFyIHdpdGggUENJZSBzcGVjLiBXaGF0IGRvIHlvdSB0 aGluayBhYm91dCBpdCwgQmpvcm4/ICAKPiA+Pj4+Cj4gPj4+PiBUaGUgUENJZSBzcGVjIGRlZmlu ZXMgYW4gYWRkcmVzcyBlbmNvZGluZyBmb3IgYnVzL2RldmljZS9mdW5jdGlvbi9yZWcKPiA+Pj4+ IGZvciB0aGUgcHVycG9zZXMgb2YgRUNBTSAoUENJZSByNi4wLCBzZWMgNy4yLjIpLCBidXQgYXMg ZmFyIGFzIEkga25vdywKPiA+Pj4+IGl0IGRvZXNuJ3QgZGVmaW5lIGFueXRoaW5nIHNpbWlsYXIg dGhhdCBpbmNsdWRlcyB0aGUgc2VnbWVudC7CoCBUaGUKPiA+Pj4+IHNlZ21lbnQgaXMgcmVhbGx5 IG91dHNpZGUgdGhlIHNjb3BlIG9mIFBDSWUgYmVjYXVzZSBlYWNoIHNlZ21lbnQgaXMgYQo+ID4+ Pj4gY29tcGxldGVseSBzZXBhcmF0ZSBQQ0llIGhpZXJhcmNoeS4gIAo+ID4+Pgo+ID4+PiBUaGFu ayB5b3UgZm9yIHlvdXIgZXhwbGFuYXRpb24uCj4gPj4+ICAKPiA+Pj4+Cj4gPj4+PiBTbyBJIHBy b2JhYmx5IHdvdWxkbid0IG1ha2UgdGhpcyBhIGdlbmVyaWMgZGVmaW5pdGlvbi7CoCBCdXQgaWYv d2hlbgo+ID4+Pj4geW91IHByaW50IHRoaW5ncyBsaWtlIHRoaXMgb3V0LCBwbGVhc2UgZG8gdXNl IHRoZSBmb3JtYXQgc3BlYyB5b3UKPiA+Pj4+IG1lbnRpb25lZCBhYm92ZSBzbyBpdCBtYXRjaGVz IHRoZSBzdHlsZSB1c2VkIGVsc2V3aGVyZS4KPiA+Pj4+IMKgwqAgICAKPiA+Pj4KPiA+Pj4gQWdy ZWUuIFRoZSBwcmludCBmb3JtYXQgb2YgYnVzL2RldmljZS9mdW5jdGlvbi9yZWcgaXMgIiUwNHg6 JTAyeDolMDJ4LiV4IiwKPiA+Pj4gc28gSSBuYW1lZCB0aGUgUE1VIGFzIHRoZSBzYW1lIGZvcm1h dC4gVGhlbiB0aGUgdXNhZ2UgZmxvdyB3b3VsZCBiZToKPiA+Pj4KPiA+Pj4gLSBsc3BjaSB0byBn ZXQgdGhlIGRldmljZSByb290IHBvcnQgaW4gZm9ybWF0IHNlZy9idXMvZGV2aWNlL2Z1bmN0aW9u L3JlZy4KPiA+Pj4gwqDCoMKgwqAxMDowMC4wIFBDSSBicmlkZ2U6IERldmljZSAxZGVkOjgwMDAg KHJldiAwMSkKPiA+Pj4gLSBzZWxlY3QgaXRzIFBNVSBuYW1lIHBjaWVfYmRmXzEwMDAwMC4KPiA+ Pj4gLSBtb25pdG9yIHdpdGggcGVyZjoKPiA+Pj4gwqDCoMKgwqBwZXJmIHN0YXQgLWEgLWUgcGNp ZV9iZGZfMTAwMDAwL1J4X1BDSWVfVExQX0RhdGFfUGF5bG9hZC8gIAo+ID4+Cj4gPj4gSSB0aGlu ayB5b3UgcHJvYmFibHkgd2FudCBzb21ldGhpbmcgaW4gdGhlcmUgdG8gaW5kaWNhdGUgaXQncyBh biBSUAo+ID4+IGFuZCB0aGUgYmRmIHBhcnQgbWF5IGJlIHJlZHVuZGFudC4uLiAgCj4gPiAKPiA+ IEluZGVlZCB0aGF0IHNlZW1zIGhvcnJpYmx5IHVuY2xlYXI7IHBlcnNvbmFsbHkgSSByZWNrb24g c29tZXRoaW5nIGxpa2UgImR3X3BjaWVfMjAwIiB3b3VsZCBiZSBtb3JlIGFwcHJvcHJpYXRlLiBU aGUgYWRkcmVzcyBpcyBqdXN0IGEgZGlzYW1iaWd1YXRvciBiZXR3ZWVuIG11bHRpcGxlIGluc3Rh bmNlcyBzbyBkb2Vzbid0IG5lZWQgYW55IGZ1cnRoZXIgZW1waGFzaXMsIGJ1dCB3aGF0IGlzIGNy dWNpYWwgdG8gdGhlIHVzZXIgaXMgZXhhY3RseSB3aGF0IGtpbmQgb2YgUE1VIGl0IGlzIChlc3Bl Y2lhbGx5IGlmIHRoZXJlJ3MgcG90ZW50aWFsIGZvciBvdGhlciB1bnJlbGF0ZWQgUENJZSBmdW5j dGlvbnMgdG8gc3RhcnQgZXhwb3NpbmcgdGhlaXIgb3duIGRpZmZlcmVudCBQTVVzKS4gIAo+IAo+ IEkgc2VlIHlvdXIgcG9pbnQuIFRoZSBjdXJyZW50IHByZWZpeCBgcGNpZV9iZGZgIGlzIG5vdCBh cHByb3ByaWF0ZSwKPiAKPiAtIGl0IGRvZXMgbm90IGluZGljYXRlIGl0IGlzIGZvciBhIHJvb3Qg cG9pbnQgYXMgSm9uYXRoYW4gbWVudGlvbmVkLgo+IC0gaXRzIHByZWZpeCBpcyBub3QgYGR3Y2AK PiAKPiBJcyBkd2Nfcm9vdHBvcnRfMTAwMDAwIG1vcmUgYXBwcm9wcmlhdGU/Cj4gCj4gLSBgZHdj YCBpbmRpY2F0ZXMgdGhlIFBNVSBpcyBmb3IgU3lub3BzeXMgRGVzaWduV2FyZSBDb3JlcyBQQ0ll IGNvbnRyb2xsZXIgSVAKPiAtIGByb290cG9ydGAgaW5kaWNhdGVzIHRoZSBQTVUgaXMgZm9yIGEg cm9vdCBwb3J0IGRldmljZQo+IC0gYDEwMDAwMGAgaW5kaWNhdGVzIHRoZSBkZXZpY2UgYWRkcmVz cwoKTG9va3MgZ29vZCB0byBtZS4KCkoKPiAKPiAKPiBUaGFuayB5b3UuCj4gCj4gQmVzdCBSZWdh cmRzLAo+IFNodWFpCj4gCj4gCj4gCj4gCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJt LWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21h aWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=