From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 57209C54EE9 for ; Tue, 27 Sep 2022 15:34:20 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4McNvt6FxHz3dwJ for ; Wed, 28 Sep 2022 01:34:18 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=209.85.210.49; helo=mail-ot1-f49.google.com; envelope-from=robherring2@gmail.com; receiver=) Received: from mail-ot1-f49.google.com (mail-ot1-f49.google.com [209.85.210.49]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4McNv35Vpvz3c5v for ; Wed, 28 Sep 2022 01:33:34 +1000 (AEST) Received: by mail-ot1-f49.google.com with SMTP id br15-20020a056830390f00b0061c9d73b8bdso6530171otb.6 for ; Tue, 27 Sep 2022 08:33:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=zjI6ubeIbgQT2Yf0aGxPciDY+P2liDNjOEnL2+LkAyE=; b=5MrIZxT0QHI1KGAIFtz50PdCUc22BSVw4Rp/r+kfMEHZvNMXSuKY+ushjO1VRXf3Tm A/ajil7/vadrwo5T2CDEGRNLe6l5imKTrI8EnFrD2ggfPd4msuOvnD4mhf0Gu4fTbv4a mDe87sTbck2+cpKnXc7HjZwk83XPGte2gFbb+xvkOeVSld6TSviP6D1RE8bLO1XWn6Pr uHcsqRHQYJYtvkcWDZ61r+AH1mntDl/ByEwWRMGvFiMdDWRUfrz4vliRuSOstYaxlwUs DKCFGpdvJiJoOKY37SQGOaSCqvx5rKzNu02PlgCr62M5c33kyELtJdfXJ7m1wobX8CYT czOA== X-Gm-Message-State: ACrzQf1oSoc/pRLWLrjRRdMlui8EKOpQBWni+9st2VK1wewQYnEL3XP5 LoVKwpyVSoTb58+lVxY2fg== X-Google-Smtp-Source: AMsMyM5eq9K8ICY6X0Mr3tOx3IJ4dvoj1unYKLRLY6r5PgzFpoQnkpXjPvXns1r165xN5VFsaDkAWw== X-Received: by 2002:a05:6830:1d4c:b0:65b:5ca1:3c5c with SMTP id p12-20020a0568301d4c00b0065b5ca13c5cmr12714674oth.77.1664292812364; Tue, 27 Sep 2022 08:33:32 -0700 (PDT) Received: from macbook.herring.priv (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id o11-20020a4ae58b000000b00425678b9c4bsm744517oov.0.2022.09.27.08.33.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Sep 2022 08:33:32 -0700 (PDT) Received: (nullmailer pid 4069847 invoked by uid 1000); Tue, 27 Sep 2022 15:33:31 -0000 Date: Tue, 27 Sep 2022 10:33:31 -0500 From: Rob Herring To: Sean Anderson Subject: Re: [PATCH net-next v5 1/9] dt-bindings: net: Expand pcs-handle to an array Message-ID: <20220927153331.GA4057163-robh@kernel.org> References: <20220926190322.2889342-1-sean.anderson@seco.com> <20220926190322.2889342-2-sean.anderson@seco.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220926190322.2889342-2-sean.anderson@seco.com> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Madalin Bucur , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Russell King , Eric Dumazet , Camelia Alexandra Groza , Krzysztof Kozlowski , Jakub Kicinski , Paolo Abeni , "linuxppc-dev @ lists . ozlabs . org" , "David S . Miller" , linux-arm-kernel@lists.infradead.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Mon, Sep 26, 2022 at 03:03:13PM -0400, Sean Anderson wrote: > This allows multiple phandles to be specified for pcs-handle, such as > when multiple PCSs are present for a single MAC. To differentiate > between them, also add a pcs-handle-names property. > > Signed-off-by: Sean Anderson > --- > This was previously submitted as [1]. I expect to update this series > more, so I have moved it here. Changes from that version include: > - Add maxItems to existing bindings > - Add a dependency from pcs-names to pcs-handle. > > [1] https://lore.kernel.org/netdev/20220711160519.741990-3-sean.anderson@seco.com/ > > (no changes since v4) > > Changes in v4: > - Use pcs-handle-names instead of pcs-names, as discussed > > Changes in v3: > - New > > .../bindings/net/dsa/renesas,rzn1-a5psw.yaml | 1 + > .../devicetree/bindings/net/ethernet-controller.yaml | 10 +++++++++- > .../devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml | 2 +- > 3 files changed, 11 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/dsa/renesas,rzn1-a5psw.yaml b/Documentation/devicetree/bindings/net/dsa/renesas,rzn1-a5psw.yaml > index 7ca9c19a157c..a53552ee1d0e 100644 > --- a/Documentation/devicetree/bindings/net/dsa/renesas,rzn1-a5psw.yaml > +++ b/Documentation/devicetree/bindings/net/dsa/renesas,rzn1-a5psw.yaml > @@ -74,6 +74,7 @@ properties: > > properties: > pcs-handle: > + maxItems: 1 Forgot to remove the $ref here. > description: > phandle pointing to a PCS sub-node compatible with > renesas,rzn1-miic.yaml# > diff --git a/Documentation/devicetree/bindings/net/ethernet-controller.yaml b/Documentation/devicetree/bindings/net/ethernet-controller.yaml > index 4b3c590fcebf..5bb2ec2963cf 100644 > --- a/Documentation/devicetree/bindings/net/ethernet-controller.yaml > +++ b/Documentation/devicetree/bindings/net/ethernet-controller.yaml > @@ -108,11 +108,16 @@ properties: > $ref: "#/properties/phy-connection-type" > > pcs-handle: > - $ref: /schemas/types.yaml#/definitions/phandle > + $ref: /schemas/types.yaml#/definitions/phandle-array 'phandle-array' is really a matrix, so this needs a bit more: items: maxItems: 1 Which basically says this is phandles with no arg cells. > description: > Specifies a reference to a node representing a PCS PHY device on a MDIO > bus to link with an external PHY (phy-handle) if exists. > > + pcs-handle-names: > + $ref: /schemas/types.yaml#/definitions/string-array No need for a type as *-names already has a type. > + description: > + The name of each PCS in pcs-handle. > + > phy-handle: > $ref: /schemas/types.yaml#/definitions/phandle > description: > @@ -216,6 +221,9 @@ properties: > required: > - speed > > +dependencies: > + pcs-handle-names: [pcs-handle] > + > allOf: > - if: > properties: > diff --git a/Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml b/Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml > index 7f620a71a972..600240281e8c 100644 > --- a/Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml > +++ b/Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml > @@ -31,7 +31,7 @@ properties: > phy-mode: true > > pcs-handle: > - $ref: /schemas/types.yaml#/definitions/phandle > + maxItems: 1 > description: > A reference to a node representing a PCS PHY device found on > the internal MDIO bus. > -- > 2.35.1.1320.gc452695387.dirty > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 46F94C07E9D for ; Tue, 27 Sep 2022 15:34:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EfMJJmpu/4twCipIQiNtpjXzAzqkBNyqul1PWdVB8Jc=; b=rer7Yc7/O470Y+ HIdVDU3u4k2FS7Iz0c9XSFYdo5t/BTqMRg+vr60u9fCNmS5KcMTrfIomby2n/fXS9vzjKsNdr4Vk6 sw34BASKjE2mZbRW/RROMaf2pGeW4hiedvojkzlWbkqkccnDb49hXK2PEwFJiqaSBFMkIo3IL+TGx 6IEI1OZp9qfXnk7IyJBPpZkCH7J5AvhUSTQs2A71Aauw0mZdGF2o/xJXO3f6kChTlwt0Xs/0MlO1X L97Te1ICSOAhD0qI46rhx03k6k3kT8b0zZA/S9aQThrpnSdZUF0dLd2NDRdoHsylnacX38Yytm1aO PiDopMwPOUvSoVIHQpdQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1odCaZ-00BTya-Rg; Tue, 27 Sep 2022 15:33:39 +0000 Received: from mail-ot1-f52.google.com ([209.85.210.52]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1odCaV-00BTwa-Qq for linux-arm-kernel@lists.infradead.org; Tue, 27 Sep 2022 15:33:37 +0000 Received: by mail-ot1-f52.google.com with SMTP id cm7-20020a056830650700b006587fe87d1aso6528871otb.10 for ; Tue, 27 Sep 2022 08:33:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=zjI6ubeIbgQT2Yf0aGxPciDY+P2liDNjOEnL2+LkAyE=; b=SwA3Q6VywvX1Q7BBIRWShHABpGaWiPHO3mcbvDU8kM/cY9io/FIsKUtCGKdDJKHgWK hJobzcJMoqO1SfLz8fSHNC72t7bjdrDgmNBeJSMIuhJ0dHFDC54HLd97j04xHsCk9PqP 6bjv7lBk5OcT3GQvrALYQEjcxBUFTIv7NF4pkiEv7eKht0QaKSiDYs+uYKgqejmtQSZG 8MghWh4y2y1Z/fSBY8roHS3XyEGgzk0qx5IP2aadLVK1S7h+vwPR2tMP1n0fpWK6QGji NJQUiakHGgYXS0OkihCIZKatLWAb/lKZkZui8n0WDtRLfc/WbCtwGi1x//RFe7rlRTCu 36iw== X-Gm-Message-State: ACrzQf2pUH6uNuuvzBbvVlyg7S5keUs6/BJeo4t9fBvEXkLUPFObs3Lb Tb7TygKR3rUBPpvzkOgWQhdwoi5+Sg== X-Google-Smtp-Source: AMsMyM5eq9K8ICY6X0Mr3tOx3IJ4dvoj1unYKLRLY6r5PgzFpoQnkpXjPvXns1r165xN5VFsaDkAWw== X-Received: by 2002:a05:6830:1d4c:b0:65b:5ca1:3c5c with SMTP id p12-20020a0568301d4c00b0065b5ca13c5cmr12714674oth.77.1664292812364; Tue, 27 Sep 2022 08:33:32 -0700 (PDT) Received: from macbook.herring.priv (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id o11-20020a4ae58b000000b00425678b9c4bsm744517oov.0.2022.09.27.08.33.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Sep 2022 08:33:32 -0700 (PDT) Received: (nullmailer pid 4069847 invoked by uid 1000); Tue, 27 Sep 2022 15:33:31 -0000 Date: Tue, 27 Sep 2022 10:33:31 -0500 From: Rob Herring To: Sean Anderson Cc: "David S . Miller" , Jakub Kicinski , Madalin Bucur , Camelia Alexandra Groza , netdev@vger.kernel.org, Eric Dumazet , Paolo Abeni , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Russell King , "linuxppc-dev @ lists . ozlabs . org" , Krzysztof Kozlowski , devicetree@vger.kernel.org Subject: Re: [PATCH net-next v5 1/9] dt-bindings: net: Expand pcs-handle to an array Message-ID: <20220927153331.GA4057163-robh@kernel.org> References: <20220926190322.2889342-1-sean.anderson@seco.com> <20220926190322.2889342-2-sean.anderson@seco.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220926190322.2889342-2-sean.anderson@seco.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220927_083335_887396_DA4A13C5 X-CRM114-Status: GOOD ( 26.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Sep 26, 2022 at 03:03:13PM -0400, Sean Anderson wrote: > This allows multiple phandles to be specified for pcs-handle, such as > when multiple PCSs are present for a single MAC. To differentiate > between them, also add a pcs-handle-names property. > > Signed-off-by: Sean Anderson > --- > This was previously submitted as [1]. I expect to update this series > more, so I have moved it here. Changes from that version include: > - Add maxItems to existing bindings > - Add a dependency from pcs-names to pcs-handle. > > [1] https://lore.kernel.org/netdev/20220711160519.741990-3-sean.anderson@seco.com/ > > (no changes since v4) > > Changes in v4: > - Use pcs-handle-names instead of pcs-names, as discussed > > Changes in v3: > - New > > .../bindings/net/dsa/renesas,rzn1-a5psw.yaml | 1 + > .../devicetree/bindings/net/ethernet-controller.yaml | 10 +++++++++- > .../devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml | 2 +- > 3 files changed, 11 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/dsa/renesas,rzn1-a5psw.yaml b/Documentation/devicetree/bindings/net/dsa/renesas,rzn1-a5psw.yaml > index 7ca9c19a157c..a53552ee1d0e 100644 > --- a/Documentation/devicetree/bindings/net/dsa/renesas,rzn1-a5psw.yaml > +++ b/Documentation/devicetree/bindings/net/dsa/renesas,rzn1-a5psw.yaml > @@ -74,6 +74,7 @@ properties: > > properties: > pcs-handle: > + maxItems: 1 Forgot to remove the $ref here. > description: > phandle pointing to a PCS sub-node compatible with > renesas,rzn1-miic.yaml# > diff --git a/Documentation/devicetree/bindings/net/ethernet-controller.yaml b/Documentation/devicetree/bindings/net/ethernet-controller.yaml > index 4b3c590fcebf..5bb2ec2963cf 100644 > --- a/Documentation/devicetree/bindings/net/ethernet-controller.yaml > +++ b/Documentation/devicetree/bindings/net/ethernet-controller.yaml > @@ -108,11 +108,16 @@ properties: > $ref: "#/properties/phy-connection-type" > > pcs-handle: > - $ref: /schemas/types.yaml#/definitions/phandle > + $ref: /schemas/types.yaml#/definitions/phandle-array 'phandle-array' is really a matrix, so this needs a bit more: items: maxItems: 1 Which basically says this is phandles with no arg cells. > description: > Specifies a reference to a node representing a PCS PHY device on a MDIO > bus to link with an external PHY (phy-handle) if exists. > > + pcs-handle-names: > + $ref: /schemas/types.yaml#/definitions/string-array No need for a type as *-names already has a type. > + description: > + The name of each PCS in pcs-handle. > + > phy-handle: > $ref: /schemas/types.yaml#/definitions/phandle > description: > @@ -216,6 +221,9 @@ properties: > required: > - speed > > +dependencies: > + pcs-handle-names: [pcs-handle] > + > allOf: > - if: > properties: > diff --git a/Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml b/Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml > index 7f620a71a972..600240281e8c 100644 > --- a/Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml > +++ b/Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml > @@ -31,7 +31,7 @@ properties: > phy-mode: true > > pcs-handle: > - $ref: /schemas/types.yaml#/definitions/phandle > + maxItems: 1 > description: > A reference to a node representing a PCS PHY device found on > the internal MDIO bus. > -- > 2.35.1.1320.gc452695387.dirty > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13EA7C54EE9 for ; Tue, 27 Sep 2022 15:33:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231981AbiI0Pdi (ORCPT ); Tue, 27 Sep 2022 11:33:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47452 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232285AbiI0Pde (ORCPT ); Tue, 27 Sep 2022 11:33:34 -0400 Received: from mail-ot1-f43.google.com (mail-ot1-f43.google.com [209.85.210.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 371F11C00FB; Tue, 27 Sep 2022 08:33:33 -0700 (PDT) Received: by mail-ot1-f43.google.com with SMTP id r13-20020a056830418d00b0065601df69c0so6545124otu.7; Tue, 27 Sep 2022 08:33:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=zjI6ubeIbgQT2Yf0aGxPciDY+P2liDNjOEnL2+LkAyE=; b=cN3Bg1R7tKngsluouxTcd9k3VeYyD9sY7FjN6G5SWlngQRuZUpmrBYK9MkKBJ6dkTh E9v+2vvW6/dVwS2ArzV1xzzH5CiiE6Jdxj2Of+qUBVZk4rwgG7u11DV0pkdpF+bQ/Czv eHhn7Jb3eiIbrPRn+voZ3I1EwbOIHkkhS6qWSpj6OjOuBCXoy8aESrM6RsGA+nJ3RCKu lTaGXckJSOF9z7TqbBNtlx9vu+2/IOSHlp5N932ryCDxG4J/8fv31BwujvuxF3lOy3Cu dMMXjdopz2Ztk91BkhkaTjftDIfc7uGEApkqmUfCcU76B4gCMAM5i5wvhx0Xo438gvTr izqA== X-Gm-Message-State: ACrzQf0BQaiJlFgBCbbzFcFB8iQ7A7A+AtwpF59PwUKMTuaNcZrusjVb Yz+AwY7BCTbs/vFRqo30Ug== X-Google-Smtp-Source: AMsMyM5eq9K8ICY6X0Mr3tOx3IJ4dvoj1unYKLRLY6r5PgzFpoQnkpXjPvXns1r165xN5VFsaDkAWw== X-Received: by 2002:a05:6830:1d4c:b0:65b:5ca1:3c5c with SMTP id p12-20020a0568301d4c00b0065b5ca13c5cmr12714674oth.77.1664292812364; Tue, 27 Sep 2022 08:33:32 -0700 (PDT) Received: from macbook.herring.priv (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id o11-20020a4ae58b000000b00425678b9c4bsm744517oov.0.2022.09.27.08.33.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Sep 2022 08:33:32 -0700 (PDT) Received: (nullmailer pid 4069847 invoked by uid 1000); Tue, 27 Sep 2022 15:33:31 -0000 Date: Tue, 27 Sep 2022 10:33:31 -0500 From: Rob Herring To: Sean Anderson Cc: "David S . Miller" , Jakub Kicinski , Madalin Bucur , Camelia Alexandra Groza , netdev@vger.kernel.org, Eric Dumazet , Paolo Abeni , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Russell King , "linuxppc-dev @ lists . ozlabs . org" , Krzysztof Kozlowski , devicetree@vger.kernel.org Subject: Re: [PATCH net-next v5 1/9] dt-bindings: net: Expand pcs-handle to an array Message-ID: <20220927153331.GA4057163-robh@kernel.org> References: <20220926190322.2889342-1-sean.anderson@seco.com> <20220926190322.2889342-2-sean.anderson@seco.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220926190322.2889342-2-sean.anderson@seco.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, Sep 26, 2022 at 03:03:13PM -0400, Sean Anderson wrote: > This allows multiple phandles to be specified for pcs-handle, such as > when multiple PCSs are present for a single MAC. To differentiate > between them, also add a pcs-handle-names property. > > Signed-off-by: Sean Anderson > --- > This was previously submitted as [1]. I expect to update this series > more, so I have moved it here. Changes from that version include: > - Add maxItems to existing bindings > - Add a dependency from pcs-names to pcs-handle. > > [1] https://lore.kernel.org/netdev/20220711160519.741990-3-sean.anderson@seco.com/ > > (no changes since v4) > > Changes in v4: > - Use pcs-handle-names instead of pcs-names, as discussed > > Changes in v3: > - New > > .../bindings/net/dsa/renesas,rzn1-a5psw.yaml | 1 + > .../devicetree/bindings/net/ethernet-controller.yaml | 10 +++++++++- > .../devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml | 2 +- > 3 files changed, 11 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/dsa/renesas,rzn1-a5psw.yaml b/Documentation/devicetree/bindings/net/dsa/renesas,rzn1-a5psw.yaml > index 7ca9c19a157c..a53552ee1d0e 100644 > --- a/Documentation/devicetree/bindings/net/dsa/renesas,rzn1-a5psw.yaml > +++ b/Documentation/devicetree/bindings/net/dsa/renesas,rzn1-a5psw.yaml > @@ -74,6 +74,7 @@ properties: > > properties: > pcs-handle: > + maxItems: 1 Forgot to remove the $ref here. > description: > phandle pointing to a PCS sub-node compatible with > renesas,rzn1-miic.yaml# > diff --git a/Documentation/devicetree/bindings/net/ethernet-controller.yaml b/Documentation/devicetree/bindings/net/ethernet-controller.yaml > index 4b3c590fcebf..5bb2ec2963cf 100644 > --- a/Documentation/devicetree/bindings/net/ethernet-controller.yaml > +++ b/Documentation/devicetree/bindings/net/ethernet-controller.yaml > @@ -108,11 +108,16 @@ properties: > $ref: "#/properties/phy-connection-type" > > pcs-handle: > - $ref: /schemas/types.yaml#/definitions/phandle > + $ref: /schemas/types.yaml#/definitions/phandle-array 'phandle-array' is really a matrix, so this needs a bit more: items: maxItems: 1 Which basically says this is phandles with no arg cells. > description: > Specifies a reference to a node representing a PCS PHY device on a MDIO > bus to link with an external PHY (phy-handle) if exists. > > + pcs-handle-names: > + $ref: /schemas/types.yaml#/definitions/string-array No need for a type as *-names already has a type. > + description: > + The name of each PCS in pcs-handle. > + > phy-handle: > $ref: /schemas/types.yaml#/definitions/phandle > description: > @@ -216,6 +221,9 @@ properties: > required: > - speed > > +dependencies: > + pcs-handle-names: [pcs-handle] > + > allOf: > - if: > properties: > diff --git a/Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml b/Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml > index 7f620a71a972..600240281e8c 100644 > --- a/Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml > +++ b/Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml > @@ -31,7 +31,7 @@ properties: > phy-mode: true > > pcs-handle: > - $ref: /schemas/types.yaml#/definitions/phandle > + maxItems: 1 > description: > A reference to a node representing a PCS PHY device found on > the internal MDIO bus. > -- > 2.35.1.1320.gc452695387.dirty > >