From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9B82C54EE9 for ; Tue, 27 Sep 2022 13:40:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232772AbiI0NkQ (ORCPT ); Tue, 27 Sep 2022 09:40:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42832 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232778AbiI0NkL (ORCPT ); Tue, 27 Sep 2022 09:40:11 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B62836B154 for ; Tue, 27 Sep 2022 06:40:09 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5314F619A3 for ; Tue, 27 Sep 2022 13:40:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DEF8FC433D6; Tue, 27 Sep 2022 13:40:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664286008; bh=bHe7jqSdC6M9l75s9W0qT54/RGr69ijmKeccBsyU9Lk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=d7KI9QJVRUTbcxl2kwBxegRL0PUDjIfPysbyPFBnPS4CkR6/6vAIQdaKcnEAPXsrM Wjbfq+SMhAxqAmwq1LcDO8G/wzDHDNoEpDoMLUo4p7F56F7zT8VZpBYcWUhfldUVth 0EkJodrqlSX169VCruVQ7XYUq8O/0/lrqTSubcuomDdXetYD5eN7bOqjdRmiuakWmK pCPYARhnKqkE5U0n53aW+655dCupQ9OpdfxZVOQCdMaPC3NIvWYmww6N2Mp9eSVCcy xjbK4wlSCZQE3MeVfY6C5tt3Qo7OblLH2osDxTxNIBbbkgXxgZj6+DBuNiiuHtfauu Gc1kQ8Vl0TNPQ== Date: Tue, 27 Sep 2022 15:40:02 +0200 From: Marek =?UTF-8?B?QmVow7pu?= To: Lorenzo Pieralisi Cc: Marc Zyngier , Lorenzo Pieralisi , Bjorn Helgaas , Krzysztof =?UTF-8?B?V2lsY3p5xYRza2k=?= , pali@kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, tglx@linutronix.de Subject: Re: [PATCH 03/11] PCI: aardvark: Add support for DLLSC and hotplug interrupt Message-ID: <20220927153947.2df43936@dellmb> In-Reply-To: References: <20220818135140.5996-1-kabel@kernel.org> <20220818135140.5996-4-kabel@kernel.org> <87r10al6a0.wl-maz@kernel.org> <868rm68g9k.wl-maz@kernel.org> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.34; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Mon, 26 Sep 2022 16:00:13 +0200 Lorenzo Pieralisi wrote: > On Mon, Sep 26, 2022 at 08:35:51AM -0400, Marc Zyngier wrote: > > On Mon, 26 Sep 2022 07:49:55 -0400, > > Lorenzo Pieralisi wrote: =20 > > >=20 > > > On Sat, Sep 17, 2022 at 10:05:59AM +0100, Marc Zyngier wrote: =20 > > > > Hi Lorenzo, > > > >=20 > > > > On Fri, 09 Sep 2022 15:57:11 +0100, > > > > Lorenzo Pieralisi wrote: =20 > > > > >=20 > > > > > [+Marc, Thomas - I can't merge this code without them reviewing i= t, > > > > > I am not sure at all you can mix the timer/IRQ code the way you d= o] > > > > >=20 > > > > > On Thu, Aug 18, 2022 at 03:51:32PM +0200, Marek Beh=C3=BAn wrote:= =20 > > > > > > From: Pali Roh=C3=A1r > > > > > >=20 > > > > > > Add support for Data Link Layer State Change in the emulated sl= ot > > > > > > registers and hotplug interrupt via the emulated root bridge. > > > > > >=20 > > > > > > This is mainly useful for when an error causes link down event.= With > > > > > > this change, drivers can try recovery. > > > > > >=20 > > > > > > Link down state change can be implemented because Aardvark supp= orts Link > > > > > > Down event interrupt. Use it for signaling that Data Link Layer= Link is > > > > > > not active anymore via Hot-Plug Interrupt on emulated root brid= ge. > > > > > >=20 > > > > > > Link up interrupt is not available on Aardvark, but we check fo= r whether > > > > > > link is up in the advk_pcie_link_up() function. By triggering H= ot-Plug > > > > > > Interrupt from this function we achieve Link up event, so long = as the > > > > > > function is called (which it is after probe and when rescanning= ). > > > > > > Although it is not ideal, it is better than nothing. =20 > > > > >=20 > > > > > So before even coming to the code review: this patch does two thi= ngs. > > > > >=20 > > > > > 1) It adds support for handling the Link down state > > > > > 2) It adds some code to emulate a Link-up event > > > > >=20 > > > > > Now, for (2). IIUC you are adding code to make sure that an HP > > > > > event is triggered if advk_pcie_link_up() is called and it > > > > > detects a Link-down->Link-up transition, that has to be notified > > > > > through an HP event. > > > > >=20 > > > > > If that's correct, you have to explain to me please what this is > > > > > actually achieving and a specific scenario where we want this to = be > > > > > implemented, in fine details; then we add it to the commit log. > > > > >=20 > > > > > That aside, the interaction of the timer and the IRQ domain code > > > > > must be reviewed by Marc and Thomas to make sure this is not > > > > > a gross violation of the respective subsystems usage. =20 > > > >=20 > > > > I don't see anything being a "gross violation" here, at least from = an > > > > interrupt subsystem perspective. In a way, this is synthesising an > > > > interrupt on the back of some other event, and as long as the conte= xt > > > > is somehow appropriate (something that looks like an interrupt when > > > > pretending there is one), this should be OK. Other subsystems such = as > > > > i2c GPIO expanders do similar things. =20 > > >=20 > > > Right, thanks. > > > =20 > > > > The one thing I'm dubious about is the frequency of the timer. Aski= ng > > > > for a poll of the link every jiffy is bound to be expensive, and it > > > > would be good to relax this as much as possible, specially on low-e= nd > > > > HW such as this, where every cycle counts. It is always going to be= a > > > > "best effort" thing, and the commit message doesn't say what's the > > > > actual grace period to handle this (the spec probably has one). =20 > > >=20 > > > AFAICS, the code does not poll the link. It sets a timer only if > > > the link is checked (eg upon PCI bus forced rescan or config access) > > > the link is up and it was down, to emulate a HP IRQ. =20 > >=20 > > I still find the timer frequency pretty high, but surely the authors > > of the code have worked out that this wasn't a problem. =20 >=20 > Please correct me if I am wrong but with mod_timer() all they want to do > is emulating/firing an (hotplug) IRQ as soon as possible - a one-off. >=20 > It is not a periodic timer - at least that's what I understand from the > code and that's the reason why such a short interval was chosen but > it should not be me who comment on that :) This is true, it is not a periodic timer. We are just using an IRQSAFE timer to call generic_handle_domain_irq() from it's handler, because we can't do it during the config space access. Marek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A198FC07E9D for ; Tue, 27 Sep 2022 13:41:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9bJekrsmR/o3Io9nAlJnTyIiYBS2X3lmZJdDcNDnVg0=; b=Drxd0JWst8jF4I Y7FKeTR4mTmmNhlq7DdJm5Pob3f0x4c6hH4HnxYj4/tIqg5HRrm4AAzAKRksqyedQykSilsvd7OZU 8b0jLnCFPxVfoAGdrp7x7b01ZzEsqyRnCcozS6i49IeVdlIFHId1UST0L50UXr8AF6JoRqSdZ5Y1+ uhA5h8qxmI2P9bwIO89wXvFN6j9eGgAtqkxcOxv48sRIutpOBuEGWMDx1Ldgij3d8ZBd/jfwTYyt6 QacMF+UIfBEgxPSPR4biTavrcMZY/r5vgcXmQf1IHJVkuQlwUkqLUjfukA1Cf/TfUoTBZ8xYd3nsj hSyYrn9WDjOG3ntxW7QA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1odAoo-00AymP-B2; Tue, 27 Sep 2022 13:40:14 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1odAok-00AykP-CA for linux-arm-kernel@lists.infradead.org; Tue, 27 Sep 2022 13:40:12 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4B96C619A2; Tue, 27 Sep 2022 13:40:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DEF8FC433D6; Tue, 27 Sep 2022 13:40:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664286008; bh=bHe7jqSdC6M9l75s9W0qT54/RGr69ijmKeccBsyU9Lk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=d7KI9QJVRUTbcxl2kwBxegRL0PUDjIfPysbyPFBnPS4CkR6/6vAIQdaKcnEAPXsrM Wjbfq+SMhAxqAmwq1LcDO8G/wzDHDNoEpDoMLUo4p7F56F7zT8VZpBYcWUhfldUVth 0EkJodrqlSX169VCruVQ7XYUq8O/0/lrqTSubcuomDdXetYD5eN7bOqjdRmiuakWmK pCPYARhnKqkE5U0n53aW+655dCupQ9OpdfxZVOQCdMaPC3NIvWYmww6N2Mp9eSVCcy xjbK4wlSCZQE3MeVfY6C5tt3Qo7OblLH2osDxTxNIBbbkgXxgZj6+DBuNiiuHtfauu Gc1kQ8Vl0TNPQ== Date: Tue, 27 Sep 2022 15:40:02 +0200 From: Marek =?UTF-8?B?QmVow7pu?= To: Lorenzo Pieralisi Cc: Marc Zyngier , Lorenzo Pieralisi , Bjorn Helgaas , Krzysztof =?UTF-8?B?V2lsY3p5xYRza2k=?= , pali@kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, tglx@linutronix.de Subject: Re: [PATCH 03/11] PCI: aardvark: Add support for DLLSC and hotplug interrupt Message-ID: <20220927153947.2df43936@dellmb> In-Reply-To: References: <20220818135140.5996-1-kabel@kernel.org> <20220818135140.5996-4-kabel@kernel.org> <87r10al6a0.wl-maz@kernel.org> <868rm68g9k.wl-maz@kernel.org> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.34; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220927_064010_542426_2B247188 X-CRM114-Status: GOOD ( 50.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCAyNiBTZXAgMjAyMiAxNjowMDoxMyArMDIwMApMb3JlbnpvIFBpZXJhbGlzaSA8bHBp ZXJhbGlzaUBrZXJuZWwub3JnPiB3cm90ZToKCj4gT24gTW9uLCBTZXAgMjYsIDIwMjIgYXQgMDg6 MzU6NTFBTSAtMDQwMCwgTWFyYyBaeW5naWVyIHdyb3RlOgo+ID4gT24gTW9uLCAyNiBTZXAgMjAy MiAwNzo0OTo1NSAtMDQwMCwKPiA+IExvcmVuem8gUGllcmFsaXNpIDxscGllcmFsaXNpQGtlcm5l bC5vcmc+IHdyb3RlOiAgCj4gPiA+IAo+ID4gPiBPbiBTYXQsIFNlcCAxNywgMjAyMiBhdCAxMDow NTo1OUFNICswMTAwLCBNYXJjIFp5bmdpZXIgd3JvdGU6ICAKPiA+ID4gPiBIaSBMb3JlbnpvLAo+ ID4gPiA+IAo+ID4gPiA+IE9uIEZyaSwgMDkgU2VwIDIwMjIgMTU6NTc6MTEgKzAxMDAsCj4gPiA+ ID4gTG9yZW56byBQaWVyYWxpc2kgPGxwaWVyYWxpc2lAa2VybmVsLm9yZz4gd3JvdGU6ICAKPiA+ ID4gPiA+IAo+ID4gPiA+ID4gWytNYXJjLCBUaG9tYXMgLSBJIGNhbid0IG1lcmdlIHRoaXMgY29k ZSB3aXRob3V0IHRoZW0gcmV2aWV3aW5nIGl0LAo+ID4gPiA+ID4gSSBhbSBub3Qgc3VyZSBhdCBh bGwgeW91IGNhbiBtaXggdGhlIHRpbWVyL0lSUSBjb2RlIHRoZSB3YXkgeW91IGRvXQo+ID4gPiA+ ID4gCj4gPiA+ID4gPiBPbiBUaHUsIEF1ZyAxOCwgMjAyMiBhdCAwMzo1MTozMlBNICswMjAwLCBN YXJlayBCZWjDum4gd3JvdGU6ICAKPiA+ID4gPiA+ID4gRnJvbTogUGFsaSBSb2jDoXIgPHBhbGlA a2VybmVsLm9yZz4KPiA+ID4gPiA+ID4gCj4gPiA+ID4gPiA+IEFkZCBzdXBwb3J0IGZvciBEYXRh IExpbmsgTGF5ZXIgU3RhdGUgQ2hhbmdlIGluIHRoZSBlbXVsYXRlZCBzbG90Cj4gPiA+ID4gPiA+ IHJlZ2lzdGVycyBhbmQgaG90cGx1ZyBpbnRlcnJ1cHQgdmlhIHRoZSBlbXVsYXRlZCByb290IGJy aWRnZS4KPiA+ID4gPiA+ID4gCj4gPiA+ID4gPiA+IFRoaXMgaXMgbWFpbmx5IHVzZWZ1bCBmb3Ig d2hlbiBhbiBlcnJvciBjYXVzZXMgbGluayBkb3duIGV2ZW50LiBXaXRoCj4gPiA+ID4gPiA+IHRo aXMgY2hhbmdlLCBkcml2ZXJzIGNhbiB0cnkgcmVjb3ZlcnkuCj4gPiA+ID4gPiA+IAo+ID4gPiA+ ID4gPiBMaW5rIGRvd24gc3RhdGUgY2hhbmdlIGNhbiBiZSBpbXBsZW1lbnRlZCBiZWNhdXNlIEFh cmR2YXJrIHN1cHBvcnRzIExpbmsKPiA+ID4gPiA+ID4gRG93biBldmVudCBpbnRlcnJ1cHQuIFVz ZSBpdCBmb3Igc2lnbmFsaW5nIHRoYXQgRGF0YSBMaW5rIExheWVyIExpbmsgaXMKPiA+ID4gPiA+ ID4gbm90IGFjdGl2ZSBhbnltb3JlIHZpYSBIb3QtUGx1ZyBJbnRlcnJ1cHQgb24gZW11bGF0ZWQg cm9vdCBicmlkZ2UuCj4gPiA+ID4gPiA+IAo+ID4gPiA+ID4gPiBMaW5rIHVwIGludGVycnVwdCBp cyBub3QgYXZhaWxhYmxlIG9uIEFhcmR2YXJrLCBidXQgd2UgY2hlY2sgZm9yIHdoZXRoZXIKPiA+ ID4gPiA+ID4gbGluayBpcyB1cCBpbiB0aGUgYWR2a19wY2llX2xpbmtfdXAoKSBmdW5jdGlvbi4g QnkgdHJpZ2dlcmluZyBIb3QtUGx1Zwo+ID4gPiA+ID4gPiBJbnRlcnJ1cHQgZnJvbSB0aGlzIGZ1 bmN0aW9uIHdlIGFjaGlldmUgTGluayB1cCBldmVudCwgc28gbG9uZyBhcyB0aGUKPiA+ID4gPiA+ ID4gZnVuY3Rpb24gaXMgY2FsbGVkICh3aGljaCBpdCBpcyBhZnRlciBwcm9iZSBhbmQgd2hlbiBy ZXNjYW5uaW5nKS4KPiA+ID4gPiA+ID4gQWx0aG91Z2ggaXQgaXMgbm90IGlkZWFsLCBpdCBpcyBi ZXR0ZXIgdGhhbiBub3RoaW5nLiAgCj4gPiA+ID4gPiAKPiA+ID4gPiA+IFNvIGJlZm9yZSBldmVu IGNvbWluZyB0byB0aGUgY29kZSByZXZpZXc6IHRoaXMgcGF0Y2ggZG9lcyB0d28gdGhpbmdzLgo+ ID4gPiA+ID4gCj4gPiA+ID4gPiAxKSBJdCBhZGRzIHN1cHBvcnQgZm9yIGhhbmRsaW5nIHRoZSBM aW5rIGRvd24gc3RhdGUKPiA+ID4gPiA+IDIpIEl0IGFkZHMgc29tZSBjb2RlIHRvIGVtdWxhdGUg YSBMaW5rLXVwIGV2ZW50Cj4gPiA+ID4gPiAKPiA+ID4gPiA+IE5vdywgZm9yICgyKS4gSUlVQyB5 b3UgYXJlIGFkZGluZyBjb2RlIHRvIG1ha2Ugc3VyZSB0aGF0IGFuIEhQCj4gPiA+ID4gPiBldmVu dCBpcyB0cmlnZ2VyZWQgaWYgYWR2a19wY2llX2xpbmtfdXAoKSBpcyBjYWxsZWQgYW5kIGl0Cj4g PiA+ID4gPiBkZXRlY3RzIGEgTGluay1kb3duLT5MaW5rLXVwIHRyYW5zaXRpb24sIHRoYXQgaGFz IHRvIGJlIG5vdGlmaWVkCj4gPiA+ID4gPiB0aHJvdWdoIGFuIEhQIGV2ZW50Lgo+ID4gPiA+ID4g Cj4gPiA+ID4gPiBJZiB0aGF0J3MgY29ycmVjdCwgeW91IGhhdmUgdG8gZXhwbGFpbiB0byBtZSBw bGVhc2Ugd2hhdCB0aGlzIGlzCj4gPiA+ID4gPiBhY3R1YWxseSBhY2hpZXZpbmcgYW5kIGEgc3Bl Y2lmaWMgc2NlbmFyaW8gd2hlcmUgd2Ugd2FudCB0aGlzIHRvIGJlCj4gPiA+ID4gPiBpbXBsZW1l bnRlZCwgaW4gZmluZSBkZXRhaWxzOyB0aGVuIHdlIGFkZCBpdCB0byB0aGUgY29tbWl0IGxvZy4K PiA+ID4gPiA+IAo+ID4gPiA+ID4gVGhhdCBhc2lkZSwgdGhlIGludGVyYWN0aW9uIG9mIHRoZSB0 aW1lciBhbmQgdGhlIElSUSBkb21haW4gY29kZQo+ID4gPiA+ID4gbXVzdCBiZSByZXZpZXdlZCBi eSBNYXJjIGFuZCBUaG9tYXMgdG8gbWFrZSBzdXJlIHRoaXMgaXMgbm90Cj4gPiA+ID4gPiBhIGdy b3NzIHZpb2xhdGlvbiBvZiB0aGUgcmVzcGVjdGl2ZSBzdWJzeXN0ZW1zIHVzYWdlLiAgCj4gPiA+ ID4gCj4gPiA+ID4gSSBkb24ndCBzZWUgYW55dGhpbmcgYmVpbmcgYSAiZ3Jvc3MgdmlvbGF0aW9u IiBoZXJlLCBhdCBsZWFzdCBmcm9tIGFuCj4gPiA+ID4gaW50ZXJydXB0IHN1YnN5c3RlbSBwZXJz cGVjdGl2ZS4gSW4gYSB3YXksIHRoaXMgaXMgc3ludGhlc2lzaW5nIGFuCj4gPiA+ID4gaW50ZXJy dXB0IG9uIHRoZSBiYWNrIG9mIHNvbWUgb3RoZXIgZXZlbnQsIGFuZCBhcyBsb25nIGFzIHRoZSBj b250ZXh0Cj4gPiA+ID4gaXMgc29tZWhvdyBhcHByb3ByaWF0ZSAoc29tZXRoaW5nIHRoYXQgbG9v a3MgbGlrZSBhbiBpbnRlcnJ1cHQgd2hlbgo+ID4gPiA+IHByZXRlbmRpbmcgdGhlcmUgaXMgb25l KSwgdGhpcyBzaG91bGQgYmUgT0suIE90aGVyIHN1YnN5c3RlbXMgc3VjaCBhcwo+ID4gPiA+IGky YyBHUElPIGV4cGFuZGVycyBkbyBzaW1pbGFyIHRoaW5ncy4gIAo+ID4gPiAKPiA+ID4gUmlnaHQs IHRoYW5rcy4KPiA+ID4gICAKPiA+ID4gPiBUaGUgb25lIHRoaW5nIEknbSBkdWJpb3VzIGFib3V0 IGlzIHRoZSBmcmVxdWVuY3kgb2YgdGhlIHRpbWVyLiBBc2tpbmcKPiA+ID4gPiBmb3IgYSBwb2xs IG9mIHRoZSBsaW5rIGV2ZXJ5IGppZmZ5IGlzIGJvdW5kIHRvIGJlIGV4cGVuc2l2ZSwgYW5kIGl0 Cj4gPiA+ID4gd291bGQgYmUgZ29vZCB0byByZWxheCB0aGlzIGFzIG11Y2ggYXMgcG9zc2libGUs IHNwZWNpYWxseSBvbiBsb3ctZW5kCj4gPiA+ID4gSFcgc3VjaCBhcyB0aGlzLCB3aGVyZSBldmVy eSBjeWNsZSBjb3VudHMuIEl0IGlzIGFsd2F5cyBnb2luZyB0byBiZSBhCj4gPiA+ID4gImJlc3Qg ZWZmb3J0IiB0aGluZywgYW5kIHRoZSBjb21taXQgbWVzc2FnZSBkb2Vzbid0IHNheSB3aGF0J3Mg dGhlCj4gPiA+ID4gYWN0dWFsIGdyYWNlIHBlcmlvZCB0byBoYW5kbGUgdGhpcyAodGhlIHNwZWMg cHJvYmFibHkgaGFzIG9uZSkuICAKPiA+ID4gCj4gPiA+IEFGQUlDUywgdGhlIGNvZGUgZG9lcyBu b3QgcG9sbCB0aGUgbGluay4gSXQgc2V0cyBhIHRpbWVyIG9ubHkgaWYKPiA+ID4gdGhlIGxpbmsg aXMgY2hlY2tlZCAoZWcgdXBvbiBQQ0kgYnVzIGZvcmNlZCByZXNjYW4gb3IgY29uZmlnIGFjY2Vz cykKPiA+ID4gdGhlIGxpbmsgaXMgdXAgYW5kIGl0IHdhcyBkb3duLCB0byBlbXVsYXRlIGEgSFAg SVJRLiAgCj4gPiAKPiA+IEkgc3RpbGwgZmluZCB0aGUgdGltZXIgZnJlcXVlbmN5IHByZXR0eSBo aWdoLCBidXQgc3VyZWx5IHRoZSBhdXRob3JzCj4gPiBvZiB0aGUgY29kZSBoYXZlIHdvcmtlZCBv dXQgdGhhdCB0aGlzIHdhc24ndCBhIHByb2JsZW0uICAKPiAKPiBQbGVhc2UgY29ycmVjdCBtZSBp ZiBJIGFtIHdyb25nIGJ1dCB3aXRoIG1vZF90aW1lcigpIGFsbCB0aGV5IHdhbnQgdG8gZG8KPiBp cyBlbXVsYXRpbmcvZmlyaW5nIGFuIChob3RwbHVnKSBJUlEgYXMgc29vbiBhcyBwb3NzaWJsZSAt IGEgb25lLW9mZi4KPiAKPiBJdCBpcyBub3QgYSBwZXJpb2RpYyB0aW1lciAtIGF0IGxlYXN0IHRo YXQncyB3aGF0IEkgdW5kZXJzdGFuZCBmcm9tIHRoZQo+IGNvZGUgYW5kIHRoYXQncyB0aGUgcmVh c29uIHdoeSBzdWNoIGEgc2hvcnQgaW50ZXJ2YWwgd2FzIGNob3NlbiBidXQKPiBpdCBzaG91bGQg bm90IGJlIG1lIHdobyBjb21tZW50IG9uIHRoYXQgOikKClRoaXMgaXMgdHJ1ZSwgaXQgaXMgbm90 IGEgcGVyaW9kaWMgdGltZXIuIFdlIGFyZSBqdXN0IHVzaW5nIGFuIElSUVNBRkUKdGltZXIgdG8g Y2FsbCBnZW5lcmljX2hhbmRsZV9kb21haW5faXJxKCkgZnJvbSBpdCdzIGhhbmRsZXIsIGJlY2F1 c2Ugd2UKY2FuJ3QgZG8gaXQgZHVyaW5nIHRoZSBjb25maWcgc3BhY2UgYWNjZXNzLgoKTWFyZWsK Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFy bS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9y ZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1r ZXJuZWwK