From: Jakub Kicinski <kuba@kernel.org>
To: Chunhao Lin <hau@realtek.com>
Cc: <hkallweit1@gmail.com>, <netdev@vger.kernel.org>, <nic_swsd@realtek.com>
Subject: Re: [PATCH net-next] r8169: add rtl_disable_rxdvgate()
Date: Tue, 27 Sep 2022 17:38:10 -0700 [thread overview]
Message-ID: <20220927173810.6caad4f3@kernel.org> (raw)
In-Reply-To: <20220926074813.3619-1-hau@realtek.com>
On Mon, 26 Sep 2022 15:48:13 +0800 Chunhao Lin wrote:
> rtl_disable_rxdvgate() is used for disable RXDV_GATE.
> It is opposite function of rtl_enable_rxdvgate().
You should mention that you're dropping the udelay() and
if you know why it was there in the first place - why it's
no longer needed.
next prev parent reply other threads:[~2022-09-28 0:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-26 7:48 [PATCH net-next] r8169: add rtl_disable_rxdvgate() Chunhao Lin
2022-09-28 0:38 ` Jakub Kicinski [this message]
2022-09-28 12:23 ` Hau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220927173810.6caad4f3@kernel.org \
--to=kuba@kernel.org \
--cc=hau@realtek.com \
--cc=hkallweit1@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.