From: Jakub Kicinski <kuba@kernel.org>
To: Jiri Pirko <jiri@resnulli.us>
Cc: netdev@vger.kernel.org, davem@davemloft.net, pabeni@redhat.com,
edumazet@google.com, andrew@lunn.ch, vivien.didelot@gmail.com,
f.fainelli@gmail.com, olteanv@gmail.com, tariqt@nvidia.com,
moshe@nvidia.com, saeedm@nvidia.com
Subject: Re: [patch net-next v2 3/7] net: devlink: add port_init/fini() helpers to allow pre-register/post-unregister functions
Date: Tue, 27 Sep 2022 18:10:41 -0700 [thread overview]
Message-ID: <20220927181041.7be7b305@kernel.org> (raw)
In-Reply-To: <20220927075645.2874644-4-jiri@resnulli.us>
On Tue, 27 Sep 2022 09:56:41 +0200 Jiri Pirko wrote:
> To be consistent with devlink regions, devlink port regions are going to
> be forbidden to be created once devlink port is registered. Prepare for
> this and introduce new set of helpers to allow driver to initialize
> devlink pointer and region list before devlink_register() is called
> That allows port regions to be created before devlink port registration
> and destroyed after devlink port unregistration.
The patches look good but I think the commit message needs an update,
no? We no longer plan to forbid the late registration IIRC.
next prev parent reply other threads:[~2022-09-28 1:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-27 7:56 [patch net-next v2 0/7] devlink: sanitize per-port region creation/destruction Jiri Pirko
2022-09-27 7:56 ` [patch net-next v2 1/7] net: devlink: introduce port registered assert helper and use it Jiri Pirko
2022-09-27 7:56 ` [patch net-next v2 2/7] net: devlink: introduce a flag to indicate devlink port being registered Jiri Pirko
2022-09-27 7:56 ` [patch net-next v2 3/7] net: devlink: add port_init/fini() helpers to allow pre-register/post-unregister functions Jiri Pirko
2022-09-28 1:10 ` Jakub Kicinski [this message]
2022-09-28 7:40 ` Jiri Pirko
2022-09-27 7:56 ` [patch net-next v2 4/7] net: dsa: move port_setup/teardown to be called outside devlink port registered area Jiri Pirko
2022-09-27 7:56 ` [patch net-next v2 5/7] net: dsa: don't leave dangling pointers in dp->pl when failing Jiri Pirko
2022-09-27 7:56 ` [patch net-next v2 6/7] net: dsa: don't do devlink port setup early Jiri Pirko
2022-09-27 7:56 ` [patch net-next v2 7/7] net: dsa: remove bool devlink_port_setup Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220927181041.7be7b305@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=jiri@resnulli.us \
--cc=moshe@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.