From: Lukas Wunner <lukas@wunner.de>
To: Mark Brown <broonie@kernel.org>
Cc: Yang Yingliang <yangyingliang@huawei.com>,
linux-spi@vger.kernel.org,
Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [PATCH -next 1/2] spi: introduce devm_spi_alloc_controller()
Date: Tue, 27 Sep 2022 22:19:01 +0200 [thread overview]
Message-ID: <20220927201901.GB24652@wunner.de> (raw)
In-Reply-To: <YzMsc1IM/73CMEeg@sirena.org.uk>
On Tue, Sep 27, 2022 at 06:01:39PM +0100, Mark Brown wrote:
> On Tue, Sep 27, 2022 at 03:31:29PM +0200, Lukas Wunner wrote:
> > On Tue, Sep 27, 2022 at 07:57:05PM +0800, Yang Yingliang wrote:
> > > Do you mean to introduce two more proper wrappers to instead of
> > > devm_spi_alloc_master/slave() ?
>
> > Honestly I don't think there's room for (or a need for) improvement here.
>
> The issue here is that we're trying to get rid of the master/slave
> terminology.
Converting drivers to use spi_controller everywhere in lieu of
spi_master is fine, but drivers need to specify whether the
spi_controller is a master or a slave and Geert's design is
to specify that on allocation. Which makes sense because
that's the moment the spi_controller comes to life, there's
no earlier moment where one could specify the type.
Thanks,
Lukas
next prev parent reply other threads:[~2022-09-27 20:19 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-26 14:29 [PATCH -next 1/2] spi: introduce devm_spi_alloc_controller() Yang Yingliang
2022-09-26 14:29 ` [PATCH -next 2/2] spi: xilinx: switch to use spi_controller_*() functions Yang Yingliang
2022-09-27 3:45 ` [PATCH -next 1/2] spi: introduce devm_spi_alloc_controller() Lukas Wunner
2022-09-27 7:11 ` Geert Uytterhoeven
2022-09-27 11:21 ` Mark Brown
2022-09-27 11:57 ` Yang Yingliang
2022-09-27 13:31 ` Lukas Wunner
2022-09-27 17:01 ` Mark Brown
2022-09-27 20:19 ` Lukas Wunner [this message]
2022-09-27 20:22 ` Mark Brown
2022-09-27 20:43 ` Geert Uytterhoeven
2022-09-28 11:15 ` Mark Brown
2022-09-28 15:01 ` Yang Yingliang
2022-09-28 16:08 ` Mark Brown
2022-09-28 15:11 ` Lukas Wunner
2022-09-28 15:58 ` Mark Brown
2022-09-28 17:14 ` Geert Uytterhoeven
2022-09-28 6:34 ` Yang Yingliang
2022-09-28 11:10 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220927201901.GB24652@wunner.de \
--to=lukas@wunner.de \
--cc=broonie@kernel.org \
--cc=geert@linux-m68k.org \
--cc=linux-spi@vger.kernel.org \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.