From: Jakub Kicinski <kuba@kernel.org>
To: Ruan Jinjie <ruanjinjie@huawei.com>
Cc: <davem@davemloft.net>, <edumazet@google.com>, <pabeni@redhat.com>,
<linmq006@gmail.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] net: i82596: Add __init/__exit annotations to module init/exit funcs
Date: Wed, 28 Sep 2022 07:07:34 -0700 [thread overview]
Message-ID: <20220928070734.7a519e18@kernel.org> (raw)
In-Reply-To: <987b807d-9f10-414a-524c-40e3d9f69e72@huawei.com>
On Wed, 28 Sep 2022 11:13:24 +0800 Ruan Jinjie wrote:
> On 2022/9/27 22:52, Jakub Kicinski wrote:
> > On Mon, 26 Sep 2022 19:54:56 +0800 ruanjinjie wrote:
> >> Add missing __init/__exit annotations to module init/exit funcs
> >
> > How many of these do you have? Do you use a tool to find the cases
> > where the annotations can be used?
> >
> I think Linux kernel drivers have many of these problems.I use grep
> command to compare all the driver C files and find where the annotations
> can be used.
>
> > Please read Documentation/process/researcher-guidelines.rst
> > and make sure you comply with what is expected in the commit message.
>
> Thank you very much! Some key information is missing from the commit
> message. Should I update the commit message and resubmit the patch?
TBH I don't think this is worth fixing. The functions which will be
discarded are tiny.
prev parent reply other threads:[~2022-09-28 14:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-26 11:54 [PATCH -next] net: i82596: Add __init/__exit annotations to module init/exit funcs ruanjinjie
2022-09-27 14:52 ` Jakub Kicinski
2022-09-28 3:13 ` Ruan Jinjie
2022-09-28 14:07 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220928070734.7a519e18@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linmq006@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ruanjinjie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.