From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Bjorn Andersson <andersson@kernel.org>,
Prashant Malani <pmalani@chromium.org>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org
Cc: Daniel Scally <djrscally@gmail.com>,
"Rafael J. Wysocki" <rafael@kernel.org>
Subject: [PATCH v2 4/5] device property: Constify device child node APIs
Date: Wed, 28 Sep 2022 13:57:45 +0300 [thread overview]
Message-ID: <20220928105746.51208-5-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20220928105746.51208-1-andriy.shevchenko@linux.intel.com>
The device parameter is not altered in the device child node APIs,
constify them.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Reviewed-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
drivers/base/property.c | 10 +++++-----
include/linux/property.h | 12 ++++++------
2 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/base/property.c b/drivers/base/property.c
index 1a1616c9b599..04eb5e0ab407 100644
--- a/drivers/base/property.c
+++ b/drivers/base/property.c
@@ -763,10 +763,10 @@ EXPORT_SYMBOL_GPL(fwnode_get_next_available_child_node);
* @dev: Device to find the next child node for.
* @child: Handle to one of the device's child nodes or a null handle.
*/
-struct fwnode_handle *device_get_next_child_node(struct device *dev,
+struct fwnode_handle *device_get_next_child_node(const struct device *dev,
struct fwnode_handle *child)
{
- const struct fwnode_handle *fwnode = dev_fwnode(dev);
+ const struct fwnode_handle *fwnode = dev_fwnode_const(dev);
struct fwnode_handle *next;
if (IS_ERR_OR_NULL(fwnode))
@@ -800,10 +800,10 @@ EXPORT_SYMBOL_GPL(fwnode_get_named_child_node);
* @dev: Device to find the named child node for.
* @childname: String to match child node name against.
*/
-struct fwnode_handle *device_get_named_child_node(struct device *dev,
+struct fwnode_handle *device_get_named_child_node(const struct device *dev,
const char *childname)
{
- return fwnode_get_named_child_node(dev_fwnode(dev), childname);
+ return fwnode_get_named_child_node(dev_fwnode_const(dev), childname);
}
EXPORT_SYMBOL_GPL(device_get_named_child_node);
@@ -859,7 +859,7 @@ EXPORT_SYMBOL_GPL(fwnode_device_is_available);
* device_get_child_node_count - return the number of child nodes for device
* @dev: Device to cound the child nodes for
*/
-unsigned int device_get_child_node_count(struct device *dev)
+unsigned int device_get_child_node_count(const struct device *dev)
{
struct fwnode_handle *child;
unsigned int count = 0;
diff --git a/include/linux/property.h b/include/linux/property.h
index fe440211e529..31dd6cbea9b0 100644
--- a/include/linux/property.h
+++ b/include/linux/property.h
@@ -110,16 +110,16 @@ struct fwnode_handle *fwnode_get_next_available_child_node(
for (child = fwnode_get_next_available_child_node(fwnode, NULL); child;\
child = fwnode_get_next_available_child_node(fwnode, child))
-struct fwnode_handle *device_get_next_child_node(
- struct device *dev, struct fwnode_handle *child);
+struct fwnode_handle *device_get_next_child_node(const struct device *dev,
+ struct fwnode_handle *child);
#define device_for_each_child_node(dev, child) \
for (child = device_get_next_child_node(dev, NULL); child; \
child = device_get_next_child_node(dev, child))
-struct fwnode_handle *fwnode_get_named_child_node(
- const struct fwnode_handle *fwnode, const char *childname);
-struct fwnode_handle *device_get_named_child_node(struct device *dev,
+struct fwnode_handle *fwnode_get_named_child_node(const struct fwnode_handle *fwnode,
+ const char *childname);
+struct fwnode_handle *device_get_named_child_node(const struct device *dev,
const char *childname);
struct fwnode_handle *fwnode_handle_get(struct fwnode_handle *fwnode);
@@ -128,7 +128,7 @@ void fwnode_handle_put(struct fwnode_handle *fwnode);
int fwnode_irq_get(const struct fwnode_handle *fwnode, unsigned int index);
int fwnode_irq_get_byname(const struct fwnode_handle *fwnode, const char *name);
-unsigned int device_get_child_node_count(struct device *dev);
+unsigned int device_get_child_node_count(const struct device *dev);
static inline bool device_property_read_bool(struct device *dev,
const char *propname)
--
2.35.1
next prev parent reply other threads:[~2022-09-28 10:58 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-28 10:57 [PATCH v2 0/5] device property: Consitify a few APIs and correct dev_fwnode() Andy Shevchenko
2022-09-28 10:57 ` [PATCH v2 1/5] device property: Keep dev_fwnode() and dev_fwnode_const() separate Andy Shevchenko
2022-09-28 11:05 ` Greg Kroah-Hartman
2022-09-30 14:30 ` Sakari Ailus
2022-09-30 14:43 ` Greg Kroah-Hartman
2022-10-03 11:02 ` Sakari Ailus
2022-10-03 15:07 ` Greg Kroah-Hartman
2022-10-03 16:17 ` Greg Kroah-Hartman
2022-10-03 20:08 ` Sakari Ailus
2022-10-04 7:55 ` Greg Kroah-Hartman
2022-10-04 8:14 ` Andy Shevchenko
2022-10-04 8:24 ` Greg Kroah-Hartman
2022-10-04 8:25 ` Andy Shevchenko
2022-10-04 9:21 ` Andy Shevchenko
2022-10-04 9:15 ` Sakari Ailus
2022-10-03 11:54 ` Rafael J. Wysocki
2022-10-03 12:00 ` Sakari Ailus
2022-10-03 15:05 ` Greg Kroah-Hartman
2022-09-28 10:57 ` [PATCH v2 2/5] device property: Constify fwnode connection match APIs Andy Shevchenko
2022-09-28 10:57 ` [PATCH v2 3/5] device property: Constify parameter in fwnode_graph_is_endpoint() Andy Shevchenko
2022-09-28 10:57 ` Andy Shevchenko [this message]
2022-09-28 10:57 ` [PATCH v2 5/5] device property: Constify parameter in device_dma_supported() and device_get_dma_attr() Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220928105746.51208-5-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=andersson@kernel.org \
--cc=djrscally@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=pmalani@chromium.org \
--cc=rafael@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.