From: Doug Berger <opendmb@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Jonathan Corbet <corbet@lwn.net>, Mike Rapoport <rppt@kernel.org>,
Borislav Petkov <bp@suse.de>,
"Paul E. McKenney" <paulmck@kernel.org>,
Neeraj Upadhyay <quic_neeraju@quicinc.com>,
Randy Dunlap <rdunlap@infradead.org>,
Damien Le Moal <damien.lemoal@opensource.wdc.com>,
Muchun Song <songmuchun@bytedance.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Mel Gorman <mgorman@suse.de>,
Mike Kravetz <mike.kravetz@oracle.com>,
Florian Fainelli <f.fainelli@gmail.com>,
David Hildenbrand <david@redhat.com>,
Oscar Salvador <osalvador@suse.de>,
Michal Hocko <mhocko@suse.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, Doug Berger <opendmb@gmail.com>
Subject: [PATCH v2 1/9] lib/show_mem.c: display MovableOnly
Date: Wed, 28 Sep 2022 15:32:53 -0700 [thread overview]
Message-ID: <20220928223301.375229-2-opendmb@gmail.com> (raw)
In-Reply-To: <20220928223301.375229-1-opendmb@gmail.com>
The comment for commit c78e93630d15 ("mm: do not walk all of
system memory during show_mem") indicates it "also corrects the
reporting of HighMem as HighMem/MovableOnly as ZONE_MOVABLE has
similar problems to HighMem with respect to lowmem/highmem
exhaustion."
Presuming the similar problems are with regard to the general
exclusion of kernel allocations from either zone, I believe it
makes sense to include all ZONE_MOVABLE memory even on systems
without HighMem.
To the extent that this was the intent of the original commit I
have included a "Fixes" tag, but it seems unnecessary to submit
to linux-stable.
Fixes: c78e93630d15 ("mm: do not walk all of system memory during show_mem")
Signed-off-by: Doug Berger <opendmb@gmail.com>
---
lib/show_mem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/show_mem.c b/lib/show_mem.c
index 1c26c14ffbb9..337c870a5e59 100644
--- a/lib/show_mem.c
+++ b/lib/show_mem.c
@@ -27,7 +27,7 @@ void show_mem(unsigned int filter, nodemask_t *nodemask)
total += zone->present_pages;
reserved += zone->present_pages - zone_managed_pages(zone);
- if (is_highmem_idx(zoneid))
+ if (zoneid == ZONE_MOVABLE || is_highmem_idx(zoneid))
highmem += zone->present_pages;
}
}
--
2.25.1
next prev parent reply other threads:[~2022-09-28 22:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-28 22:32 [PATCH v2 0/9] mm: introduce Designated Movable Blocks Doug Berger
2022-09-28 22:32 ` Doug Berger [this message]
2022-09-28 22:32 ` [PATCH v2 2/9] mm/vmstat: show start_pfn when zone spans pages Doug Berger
2022-09-29 8:15 ` David Hildenbrand
2022-10-01 1:28 ` Doug Berger
2022-10-05 18:09 ` David Hildenbrand
2022-10-12 23:57 ` Doug Berger
2022-10-13 11:44 ` Michal Hocko
2022-09-28 22:32 ` [PATCH v2 3/9] mm/page_alloc: calculate node_spanned_pages from pfns Doug Berger
2022-09-28 22:32 ` [PATCH v2 4/9] mm/page_alloc.c: allow oversized movablecore Doug Berger
2022-09-28 22:32 ` [PATCH v2 5/9] mm/page_alloc: introduce init_reserved_pageblock() Doug Berger
2022-09-28 22:32 ` [PATCH v2 6/9] memblock: introduce MEMBLOCK_MOVABLE flag Doug Berger
2022-09-28 22:32 ` [PATCH v2 7/9] mm/dmb: Introduce Designated Movable Blocks Doug Berger
2022-09-28 22:33 ` [PATCH v2 8/9] mm/page_alloc: make alloc_contig_pages DMB aware Doug Berger
2022-09-28 22:33 ` [PATCH v2 9/9] mm/page_alloc: allow base for movablecore Doug Berger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220928223301.375229-2-opendmb@gmail.com \
--to=opendmb@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bp@suse.de \
--cc=corbet@lwn.net \
--cc=damien.lemoal@opensource.wdc.com \
--cc=david@redhat.com \
--cc=f.fainelli@gmail.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@suse.com \
--cc=mike.kravetz@oracle.com \
--cc=osalvador@suse.de \
--cc=paulmck@kernel.org \
--cc=quic_neeraju@quicinc.com \
--cc=rdunlap@infradead.org \
--cc=rppt@kernel.org \
--cc=songmuchun@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.