From: "Flint.Wang" <hmsjwzb@zoho.com>
To: wqu@suse.com
Cc: hmsjwzb@zoho.com, stringbox8@zoho.com, Chris Mason <clm@fb.com>,
Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] btrfs:remove redundant index_rbio_pages in raid56_rmw_stripe
Date: Thu, 29 Sep 2022 09:44:01 +0800 [thread overview]
Message-ID: <20220929014402.2450-1-hmsjwzb@zoho.com> (raw)
The index_rbio_pages in raid56_rmw_stripe is redundant.
It is invoked in finish_rmw anyway.
Signed-off-by: Flint.Wang <hmsjwzb@zoho.com>
---
fs/btrfs/raid56.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/fs/btrfs/raid56.c b/fs/btrfs/raid56.c
index f6395e8288d69..44266b2c5b86e 100644
--- a/fs/btrfs/raid56.c
+++ b/fs/btrfs/raid56.c
@@ -1546,8 +1546,6 @@ static int raid56_rmw_stripe(struct btrfs_raid_bio *rbio)
if (ret)
goto cleanup;
- index_rbio_pages(rbio);
-
atomic_set(&rbio->error, 0);
/* Build a list of bios to read all the missing data sectors. */
for (total_sector_nr = 0; total_sector_nr < nr_data_sectors;
--
2.37.0
next reply other threads:[~2022-09-29 1:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-29 1:44 Flint.Wang [this message]
2022-09-29 1:49 ` [PATCH] btrfs:remove redundant index_rbio_pages in raid56_rmw_stripe hmsjwzb
2022-09-29 3:08 ` Qu Wenruo
2022-09-29 3:13 ` Qu Wenruo
2022-09-29 6:41 ` hmsjwzb
2022-09-29 7:00 ` Qu Wenruo
2022-09-29 5:14 ` hmsjwzb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220929014402.2450-1-hmsjwzb@zoho.com \
--to=hmsjwzb@zoho.com \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stringbox8@zoho.com \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.