From: Jakub Kicinski <kuba@kernel.org>
To: Sabrina Dubroca <sd@queasysnail.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next 08/12] macsec: use NLA_POLICY_VALIDATE_FN to validate IFLA_MACSEC_CIPHER_SUITE
Date: Thu, 29 Sep 2022 09:08:40 -0700 [thread overview]
Message-ID: <20220929090840.062e1ace@kernel.org> (raw)
In-Reply-To: <5d4541915e5229c0329ff8e6618439ca21767b18.1664379352.git.sd@queasysnail.net>
On Wed, 28 Sep 2022 18:17:21 +0200 Sabrina Dubroca wrote:
> Unfortunately, since the value of MACSEC_DEFAULT_CIPHER_ID doesn't fit
> near the others, we can't use a simple range in the policy.
This one warns:
drivers/net/macsec.c:4122:6: warning: variable 'csid' set but not used [-Wunused-but-set-variable]
u64 csid = MACSEC_DEFAULT_CIPHER_ID;
^
next prev parent reply other threads:[~2022-09-29 16:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-28 16:17 [PATCH net-next 00/12] macsec: replace custom netlink attribute checks with policy-level checks Sabrina Dubroca
2022-09-28 16:17 ` [PATCH net-next 01/12] macsec: replace custom checks on MACSEC_SA_ATTR_AN with NLA_POLICY_MAX Sabrina Dubroca
2022-09-28 16:17 ` [PATCH net-next 02/12] macsec: replace custom checks on MACSEC_*_ATTR_ACTIVE " Sabrina Dubroca
2022-09-28 16:17 ` [PATCH net-next 03/12] macsec: replace custom checks on MACSEC_SA_ATTR_SALT with NLA_POLICY_EXACT_LEN Sabrina Dubroca
2022-09-28 16:17 ` [PATCH net-next 04/12] macsec: replace custom checks on MACSEC_SA_ATTR_KEYID " Sabrina Dubroca
2022-09-28 16:17 ` [PATCH net-next 05/12] macsec: use NLA_POLICY_VALIDATE_FN to validate MACSEC_SA_ATTR_PN Sabrina Dubroca
2022-09-28 16:17 ` [PATCH net-next 06/12] macsec: add NLA_POLICY_MAX for MACSEC_OFFLOAD_ATTR_TYPE and IFLA_MACSEC_OFFLOAD Sabrina Dubroca
2022-09-28 16:17 ` [PATCH net-next 07/12] macsec: replace custom checks on IFLA_MACSEC_ICV_LEN with NLA_POLICY_RANGE Sabrina Dubroca
2022-09-28 16:17 ` [PATCH net-next 08/12] macsec: use NLA_POLICY_VALIDATE_FN to validate IFLA_MACSEC_CIPHER_SUITE Sabrina Dubroca
2022-09-28 21:07 ` kernel test robot
2022-09-28 21:50 ` kernel test robot
2022-09-29 16:08 ` Jakub Kicinski [this message]
2022-09-28 16:17 ` [PATCH net-next 09/12] macsec: validate IFLA_MACSEC_VALIDATION with NLA_POLICY_MAX Sabrina Dubroca
2022-09-28 16:27 ` [PATCH net-next 10/12] macsec: replace custom checks for IFLA_MACSEC_* flags " Sabrina Dubroca
2022-09-28 16:28 ` [PATCH net-next 11/12] macsec: replace custom check on IFLA_MACSEC_ENCODING_SA " Sabrina Dubroca
2022-09-28 16:29 ` [PATCH net-next 12/12] macsec: remove validate_add_rxsc Sabrina Dubroca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220929090840.062e1ace@kernel.org \
--to=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sd@queasysnail.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.