From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org C5EBD83ECC DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org A687580B76 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664476067; bh=peXm6EYz/EMFFA8zuW/FKucf85TPZxTNbaodSHoZ7Wg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Kv7xhea2uFIbwtuFQLZh9XSjU1NQfjbcVqi7NBdfo1YmhLPr/oFL/8Xy7h8nVd63Y 1QbyuerlojcUMR9UJXqyqMMe/stYLXuAEzjAn5YgYL+gSYYe2Mgq5Jy1q1QOi5phs9 LUXrQ/s2M+7o3FfgPVpda31wV2wVBaOYzo8yfTohR2fDzhGsJx5Pf63zWtPQKojM9F jn5yUhRAxSZA/Yu9rBhiUcBtbQl8G7FuabZv9yLUhOJjlvUZ798HikAJYp4pUIjm// HnqLKE0lE+TxmEdaYgq6OQOzGouYBxg3CmBkmarKcPIbw5qPRqYRZam7X/YTCqQye3 IoYyggPAxMHZw== Date: Thu, 29 Sep 2022 11:27:44 -0700 From: Jakub Kicinski Message-ID: <20220929112744.27cc969b@kernel.org> In-Reply-To: <12587604af1ed79be4d3a1607987483a@kapio-technology.com> References: <20220928150256.115248-1-netdev@kapio-technology.com> <20220929091036.3812327f@kernel.org> <12587604af1ed79be4d3a1607987483a@kapio-technology.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Bridge] [PATCH v6 net-next 0/9] Extend locked port feature with FDB locked flag (MAC-Auth/MAB) List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: netdev@kapio-technology.com Cc: Andrew Lunn , Alexandre Belloni , Nikolay Aleksandrov , Kurt Kanzenbach , Eric Dumazet , linux-kselftest@vger.kernel.org, Joachim Wiberg , Shuah Khan , Ivan Vecera , Florian Fainelli , Daniel Borkmann , Ido Schimmel , bridge@lists.linux-foundation.org, Russell King , linux-arm-kernel@lists.infradead.org, Roopa Prabhu , Paolo Abeni , Vivien Didelot , Woojung Huh , Landen Chao , Jiri Pirko , Amit Cohen , Christian Marangi , Hauke Mehrtens , Hans Schultz , Sean Wang , DENG Qingfang , Claudiu Manoil , linux-mediatek@lists.infradead.org, Matthias Brugger , Yuwei Wang , Petr Machata , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Florent Fourcot , UNGLinuxDriver@microchip.com, Vladimir Oltean , davem@davemloft.net On Thu, 29 Sep 2022 18:37:09 +0200 netdev@kapio-technology.com wrote: > On 2022-09-29 18:10, Jakub Kicinski wrote: > > On Wed, 28 Sep 2022 17:02:47 +0200 Hans Schultz wrote: =20 > >> From: "Hans J. Schultz" > >>=20 > >> This patch set extends the locked port feature for devices > >> that are behind a locked port, but do not have the ability to > >> authorize themselves as a supplicant using IEEE 802.1X. > >> Such devices can be printers, meters or anything related to > >> fixed installations. Instead of 802.1X authorization, devices > >> can get access based on their MAC addresses being whitelisted. =20 > >=20 > > Try a allmodconfig build on latest net-next, seems broken. =20 >=20 > I have all different switch drivers enabled and I see no compile=20 > warnings or errors.=20 Just do what I told you - rebase on net-next, allmodconfig. > I guess I will get a robot update if that is the=20 > case but please be specific as to what does not build. The maintainers simply don't have time to hold everyone by the hand. Sometimes I wish it was still okay to yell at people who post code which does not build. Oh well. ../drivers/net/dsa/qca/qca8k-common.c:810:5: error: conflicting types for = =E2=80=98qca8k_port_fdb_del=E2=80=99 int qca8k_port_fdb_del(struct dsa_switch *ds, int port, ^~~~~~~~~~~~~~~~~~ In file included from ../drivers/net/dsa/qca/qca8k-common.c:13: ../drivers/net/dsa/qca/qca8k.h:483:5: note: previous declaration of =E2=80= =98qca8k_port_fdb_del=E2=80=99 was here int qca8k_port_fdb_del(struct dsa_switch *ds, int port, ^~~~~~~~~~~~~~~~~~ ../drivers/net/dsa/qca/qca8k-common.c: In function =E2=80=98qca8k_port_fdb_= del=E2=80=99: ../drivers/net/dsa/qca/qca8k-common.c:818:6: error: =E2=80=98fdb_flags=E2= =80=99 undeclared (first use in this function); did you mean =E2=80=98tsq_f= lags=E2=80=99? if (fdb_flags) ^~~~~~~~~ tsq_flags ../drivers/net/dsa/qca/qca8k-common.c:818:6: note: each undeclared identifi= er is reported only once for each function it appears in make[5]: *** [../scripts/Makefile.build:249: drivers/net/dsa/qca/qca8k-comm= on.o] Error 1 make[5]: *** Waiting for unfinished jobs.... make[4]: *** [../scripts/Makefile.build:465: drivers/net/dsa/qca] Error 2 make[4]: *** Waiting for unfinished jobs.... ../drivers/net/dsa/sja1105/sja1105_main.c: In function =E2=80=98sja1105_fas= t_age=E2=80=99: ../drivers/net/dsa/sja1105/sja1105_main.c:1941:61: error: incompatible type= for argument 5 of =E2=80=98sja1105_fdb_del=E2=80=99 rc =3D sja1105_fdb_del(ds, port, macaddr, l2_lookup.vlanid, db); ^~ ../drivers/net/dsa/sja1105/sja1105_main.c:1831:11: note: expected =E2=80=98= u16=E2=80=99 {aka =E2=80=98short unsigned int=E2=80=99} but argument is of = type =E2=80=98struct dsa_db=E2=80=99 u16 fdb_flags, struct dsa_db db) ~~~~^~~~~~~~~ ../drivers/net/dsa/sja1105/sja1105_main.c:1941:8: error: too few arguments = to function =E2=80=98sja1105_fdb_del=E2=80=99 rc =3D sja1105_fdb_del(ds, port, macaddr, l2_lookup.vlanid, db); ^~~~~~~~~~~~~~~ ../drivers/net/dsa/sja1105/sja1105_main.c:1829:12: note: declared here static int sja1105_fdb_del(struct dsa_switch *ds, int port, ^~~~~~~~~~~~~~~ ../drivers/net/dsa/sja1105/sja1105_main.c: In function =E2=80=98sja1105_mdb= _del=E2=80=99: ../drivers/net/dsa/sja1105/sja1105_main.c:1962:56: error: incompatible type= for argument 5 of =E2=80=98sja1105_fdb_del=E2=80=99 return sja1105_fdb_del(ds, port, mdb->addr, mdb->vid, db); ^~ ../drivers/net/dsa/sja1105/sja1105_main.c:1831:11: note: expected =E2=80=98= u16=E2=80=99 {aka =E2=80=98short unsigned int=E2=80=99} but argument is of = type =E2=80=98struct dsa_db=E2=80=99 u16 fdb_flags, struct dsa_db db) ~~~~^~~~~~~~~ ../drivers/net/dsa/sja1105/sja1105_main.c:1962:9: error: too few arguments = to function =E2=80=98sja1105_fdb_del=E2=80=99 return sja1105_fdb_del(ds, port, mdb->addr, mdb->vid, db); ^~~~~~~~~~~~~~~ ../drivers/net/dsa/sja1105/sja1105_main.c:1829:12: note: declared here static int sja1105_fdb_del(struct dsa_switch *ds, int port, ^~~~~~~~~~~~~~~ ../drivers/net/dsa/sja1105/sja1105_main.c:1963:1: error: control reaches en= d of non-void function [-Werror=3Dreturn-type] } ^ cc1: some warnings being treated as errors make[5]: *** [../scripts/Makefile.build:249: drivers/net/dsa/sja1105/sja110= 5_main.o] Error 1 make[5]: *** Waiting for unfinished jobs.... make[4]: *** [../scripts/Makefile.build:465: drivers/net/dsa/sja1105] Error= 2 make[3]: *** [../scripts/Makefile.build:465: drivers/net/dsa] Error 2 make[3]: *** Waiting for unfinished jobs.... make[2]: *** [../scripts/Makefile.build:465: drivers/net] Error 2 make[1]: *** [/home/kicinski/linux/Makefile:1852: drivers] Error 2 make[1]: *** Waiting for unfinished jobs.... make: *** [Makefile:222: __sub-make] Error 2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 449B1C4332F for ; Thu, 29 Sep 2022 18:28:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234128AbiI2S2X (ORCPT ); Thu, 29 Sep 2022 14:28:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51760 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234987AbiI2S1w (ORCPT ); Thu, 29 Sep 2022 14:27:52 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9F1501438C8; Thu, 29 Sep 2022 11:27:49 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 4DEB3B82646; Thu, 29 Sep 2022 18:27:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7D73EC433C1; Thu, 29 Sep 2022 18:27:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664476067; bh=peXm6EYz/EMFFA8zuW/FKucf85TPZxTNbaodSHoZ7Wg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Kv7xhea2uFIbwtuFQLZh9XSjU1NQfjbcVqi7NBdfo1YmhLPr/oFL/8Xy7h8nVd63Y 1QbyuerlojcUMR9UJXqyqMMe/stYLXuAEzjAn5YgYL+gSYYe2Mgq5Jy1q1QOi5phs9 LUXrQ/s2M+7o3FfgPVpda31wV2wVBaOYzo8yfTohR2fDzhGsJx5Pf63zWtPQKojM9F jn5yUhRAxSZA/Yu9rBhiUcBtbQl8G7FuabZv9yLUhOJjlvUZ798HikAJYp4pUIjm// HnqLKE0lE+TxmEdaYgq6OQOzGouYBxg3CmBkmarKcPIbw5qPRqYRZam7X/YTCqQye3 IoYyggPAxMHZw== Date: Thu, 29 Sep 2022 11:27:44 -0700 From: Jakub Kicinski To: netdev@kapio-technology.com Cc: davem@davemloft.net, netdev@vger.kernel.org, Florian Fainelli , Andrew Lunn , Vivien Didelot , Vladimir Oltean , Eric Dumazet , Paolo Abeni , Kurt Kanzenbach , Hauke Mehrtens , Woojung Huh , UNGLinuxDriver@microchip.com, Sean Wang , Landen Chao , DENG Qingfang , Matthias Brugger , Claudiu Manoil , Alexandre Belloni , Jiri Pirko , Ivan Vecera , Roopa Prabhu , Nikolay Aleksandrov , Shuah Khan , Russell King , Christian Marangi , Daniel Borkmann , Yuwei Wang , Petr Machata , Ido Schimmel , Florent Fourcot , Hans Schultz , Joachim Wiberg , Amit Cohen , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, bridge@lists.linux-foundation.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v6 net-next 0/9] Extend locked port feature with FDB locked flag (MAC-Auth/MAB) Message-ID: <20220929112744.27cc969b@kernel.org> In-Reply-To: <12587604af1ed79be4d3a1607987483a@kapio-technology.com> References: <20220928150256.115248-1-netdev@kapio-technology.com> <20220929091036.3812327f@kernel.org> <12587604af1ed79be4d3a1607987483a@kapio-technology.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Thu, 29 Sep 2022 18:37:09 +0200 netdev@kapio-technology.com wrote: > On 2022-09-29 18:10, Jakub Kicinski wrote: > > On Wed, 28 Sep 2022 17:02:47 +0200 Hans Schultz wrote: =20 > >> From: "Hans J. Schultz" > >>=20 > >> This patch set extends the locked port feature for devices > >> that are behind a locked port, but do not have the ability to > >> authorize themselves as a supplicant using IEEE 802.1X. > >> Such devices can be printers, meters or anything related to > >> fixed installations. Instead of 802.1X authorization, devices > >> can get access based on their MAC addresses being whitelisted. =20 > >=20 > > Try a allmodconfig build on latest net-next, seems broken. =20 >=20 > I have all different switch drivers enabled and I see no compile=20 > warnings or errors.=20 Just do what I told you - rebase on net-next, allmodconfig. > I guess I will get a robot update if that is the=20 > case but please be specific as to what does not build. The maintainers simply don't have time to hold everyone by the hand. Sometimes I wish it was still okay to yell at people who post code which does not build. Oh well. ../drivers/net/dsa/qca/qca8k-common.c:810:5: error: conflicting types for = =E2=80=98qca8k_port_fdb_del=E2=80=99 int qca8k_port_fdb_del(struct dsa_switch *ds, int port, ^~~~~~~~~~~~~~~~~~ In file included from ../drivers/net/dsa/qca/qca8k-common.c:13: ../drivers/net/dsa/qca/qca8k.h:483:5: note: previous declaration of =E2=80= =98qca8k_port_fdb_del=E2=80=99 was here int qca8k_port_fdb_del(struct dsa_switch *ds, int port, ^~~~~~~~~~~~~~~~~~ ../drivers/net/dsa/qca/qca8k-common.c: In function =E2=80=98qca8k_port_fdb_= del=E2=80=99: ../drivers/net/dsa/qca/qca8k-common.c:818:6: error: =E2=80=98fdb_flags=E2= =80=99 undeclared (first use in this function); did you mean =E2=80=98tsq_f= lags=E2=80=99? if (fdb_flags) ^~~~~~~~~ tsq_flags ../drivers/net/dsa/qca/qca8k-common.c:818:6: note: each undeclared identifi= er is reported only once for each function it appears in make[5]: *** [../scripts/Makefile.build:249: drivers/net/dsa/qca/qca8k-comm= on.o] Error 1 make[5]: *** Waiting for unfinished jobs.... make[4]: *** [../scripts/Makefile.build:465: drivers/net/dsa/qca] Error 2 make[4]: *** Waiting for unfinished jobs.... ../drivers/net/dsa/sja1105/sja1105_main.c: In function =E2=80=98sja1105_fas= t_age=E2=80=99: ../drivers/net/dsa/sja1105/sja1105_main.c:1941:61: error: incompatible type= for argument 5 of =E2=80=98sja1105_fdb_del=E2=80=99 rc =3D sja1105_fdb_del(ds, port, macaddr, l2_lookup.vlanid, db); ^~ ../drivers/net/dsa/sja1105/sja1105_main.c:1831:11: note: expected =E2=80=98= u16=E2=80=99 {aka =E2=80=98short unsigned int=E2=80=99} but argument is of = type =E2=80=98struct dsa_db=E2=80=99 u16 fdb_flags, struct dsa_db db) ~~~~^~~~~~~~~ ../drivers/net/dsa/sja1105/sja1105_main.c:1941:8: error: too few arguments = to function =E2=80=98sja1105_fdb_del=E2=80=99 rc =3D sja1105_fdb_del(ds, port, macaddr, l2_lookup.vlanid, db); ^~~~~~~~~~~~~~~ ../drivers/net/dsa/sja1105/sja1105_main.c:1829:12: note: declared here static int sja1105_fdb_del(struct dsa_switch *ds, int port, ^~~~~~~~~~~~~~~ ../drivers/net/dsa/sja1105/sja1105_main.c: In function =E2=80=98sja1105_mdb= _del=E2=80=99: ../drivers/net/dsa/sja1105/sja1105_main.c:1962:56: error: incompatible type= for argument 5 of =E2=80=98sja1105_fdb_del=E2=80=99 return sja1105_fdb_del(ds, port, mdb->addr, mdb->vid, db); ^~ ../drivers/net/dsa/sja1105/sja1105_main.c:1831:11: note: expected =E2=80=98= u16=E2=80=99 {aka =E2=80=98short unsigned int=E2=80=99} but argument is of = type =E2=80=98struct dsa_db=E2=80=99 u16 fdb_flags, struct dsa_db db) ~~~~^~~~~~~~~ ../drivers/net/dsa/sja1105/sja1105_main.c:1962:9: error: too few arguments = to function =E2=80=98sja1105_fdb_del=E2=80=99 return sja1105_fdb_del(ds, port, mdb->addr, mdb->vid, db); ^~~~~~~~~~~~~~~ ../drivers/net/dsa/sja1105/sja1105_main.c:1829:12: note: declared here static int sja1105_fdb_del(struct dsa_switch *ds, int port, ^~~~~~~~~~~~~~~ ../drivers/net/dsa/sja1105/sja1105_main.c:1963:1: error: control reaches en= d of non-void function [-Werror=3Dreturn-type] } ^ cc1: some warnings being treated as errors make[5]: *** [../scripts/Makefile.build:249: drivers/net/dsa/sja1105/sja110= 5_main.o] Error 1 make[5]: *** Waiting for unfinished jobs.... make[4]: *** [../scripts/Makefile.build:465: drivers/net/dsa/sja1105] Error= 2 make[3]: *** [../scripts/Makefile.build:465: drivers/net/dsa] Error 2 make[3]: *** Waiting for unfinished jobs.... make[2]: *** [../scripts/Makefile.build:465: drivers/net] Error 2 make[1]: *** [/home/kicinski/linux/Makefile:1852: drivers] Error 2 make[1]: *** Waiting for unfinished jobs.... make: *** [Makefile:222: __sub-make] Error 2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3CBCFC433F5 for ; Thu, 29 Sep 2022 18:28:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=84TzHvEaY73uTR+uAq6XWec/ubS5xoMPbmowYXC0GtE=; b=P/AJChEvHQoudp UeLEzEOsn/YiSM90pRk6rywWR4xBMUFFntrnqX1EQPWiD8fE0V1JVWrlkdEmUI1qV450yFsJL0dTL uDyhyW5L28S1tS1ovrW8USemmrmxKZIaEysM+LxMXrZ8W8a1z+olmVryqzUGUdF6ZAE/un8ZELE1D uMdO/yk+xJSlhP8MFaOPwYr0uh/iCZ105XosP6sXUgBt5V1JbyUr2aZekQsLLeUSREOlqOzVIsP2B C636kgX1fzpbVcwKFzlMqnhFpJta3JdtfdxtjhJoFlVi63Y9LydMYi81Vak0MKALSnXKK+tGUznzZ cMdEG0H7Z5gsqznlncwg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1odyGH-004vJe-AD; Thu, 29 Sep 2022 18:27:53 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1odyGD-004vI6-RK; Thu, 29 Sep 2022 18:27:51 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 3685CB825AC; Thu, 29 Sep 2022 18:27:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7D73EC433C1; Thu, 29 Sep 2022 18:27:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664476067; bh=peXm6EYz/EMFFA8zuW/FKucf85TPZxTNbaodSHoZ7Wg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Kv7xhea2uFIbwtuFQLZh9XSjU1NQfjbcVqi7NBdfo1YmhLPr/oFL/8Xy7h8nVd63Y 1QbyuerlojcUMR9UJXqyqMMe/stYLXuAEzjAn5YgYL+gSYYe2Mgq5Jy1q1QOi5phs9 LUXrQ/s2M+7o3FfgPVpda31wV2wVBaOYzo8yfTohR2fDzhGsJx5Pf63zWtPQKojM9F jn5yUhRAxSZA/Yu9rBhiUcBtbQl8G7FuabZv9yLUhOJjlvUZ798HikAJYp4pUIjm// HnqLKE0lE+TxmEdaYgq6OQOzGouYBxg3CmBkmarKcPIbw5qPRqYRZam7X/YTCqQye3 IoYyggPAxMHZw== Date: Thu, 29 Sep 2022 11:27:44 -0700 From: Jakub Kicinski To: netdev@kapio-technology.com Cc: davem@davemloft.net, netdev@vger.kernel.org, Florian Fainelli , Andrew Lunn , Vivien Didelot , Vladimir Oltean , Eric Dumazet , Paolo Abeni , Kurt Kanzenbach , Hauke Mehrtens , Woojung Huh , UNGLinuxDriver@microchip.com, Sean Wang , Landen Chao , DENG Qingfang , Matthias Brugger , Claudiu Manoil , Alexandre Belloni , Jiri Pirko , Ivan Vecera , Roopa Prabhu , Nikolay Aleksandrov , Shuah Khan , Russell King , Christian Marangi , Daniel Borkmann , Yuwei Wang , Petr Machata , Ido Schimmel , Florent Fourcot , Hans Schultz , Joachim Wiberg , Amit Cohen , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, bridge@lists.linux-foundation.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v6 net-next 0/9] Extend locked port feature with FDB locked flag (MAC-Auth/MAB) Message-ID: <20220929112744.27cc969b@kernel.org> In-Reply-To: <12587604af1ed79be4d3a1607987483a@kapio-technology.com> References: <20220928150256.115248-1-netdev@kapio-technology.com> <20220929091036.3812327f@kernel.org> <12587604af1ed79be4d3a1607987483a@kapio-technology.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220929_112750_181706_09F1F050 X-CRM114-Status: GOOD ( 22.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCAyOSBTZXAgMjAyMiAxODozNzowOSArMDIwMCBuZXRkZXZAa2FwaW8tdGVjaG5vbG9n eS5jb20gd3JvdGU6Cj4gT24gMjAyMi0wOS0yOSAxODoxMCwgSmFrdWIgS2ljaW5za2kgd3JvdGU6 Cj4gPiBPbiBXZWQsIDI4IFNlcCAyMDIyIDE3OjAyOjQ3ICswMjAwIEhhbnMgU2NodWx0eiB3cm90 ZTogIAo+ID4+IEZyb206ICJIYW5zIEouIFNjaHVsdHoiIDxuZXRkZXZAa2FwaW8tdGVjaG5vbG9n eS5jb20+Cj4gPj4gCj4gPj4gVGhpcyBwYXRjaCBzZXQgZXh0ZW5kcyB0aGUgbG9ja2VkIHBvcnQg ZmVhdHVyZSBmb3IgZGV2aWNlcwo+ID4+IHRoYXQgYXJlIGJlaGluZCBhIGxvY2tlZCBwb3J0LCBi dXQgZG8gbm90IGhhdmUgdGhlIGFiaWxpdHkgdG8KPiA+PiBhdXRob3JpemUgdGhlbXNlbHZlcyBh cyBhIHN1cHBsaWNhbnQgdXNpbmcgSUVFRSA4MDIuMVguCj4gPj4gU3VjaCBkZXZpY2VzIGNhbiBi ZSBwcmludGVycywgbWV0ZXJzIG9yIGFueXRoaW5nIHJlbGF0ZWQgdG8KPiA+PiBmaXhlZCBpbnN0 YWxsYXRpb25zLiBJbnN0ZWFkIG9mIDgwMi4xWCBhdXRob3JpemF0aW9uLCBkZXZpY2VzCj4gPj4g Y2FuIGdldCBhY2Nlc3MgYmFzZWQgb24gdGhlaXIgTUFDIGFkZHJlc3NlcyBiZWluZyB3aGl0ZWxp c3RlZC4gIAo+ID4gCj4gPiBUcnkgYSBhbGxtb2Rjb25maWcgYnVpbGQgb24gbGF0ZXN0IG5ldC1u ZXh0LCBzZWVtcyBicm9rZW4uICAKPiAKPiBJIGhhdmUgYWxsIGRpZmZlcmVudCBzd2l0Y2ggZHJp dmVycyBlbmFibGVkIGFuZCBJIHNlZSBubyBjb21waWxlIAo+IHdhcm5pbmdzIG9yIGVycm9ycy4g CgpKdXN0IGRvIHdoYXQgSSB0b2xkIHlvdSAtIHJlYmFzZSBvbiBuZXQtbmV4dCwgYWxsbW9kY29u ZmlnLgoKPiBJIGd1ZXNzIEkgd2lsbCBnZXQgYSByb2JvdCB1cGRhdGUgaWYgdGhhdCBpcyB0aGUg Cj4gY2FzZSBidXQgcGxlYXNlIGJlIHNwZWNpZmljIGFzIHRvIHdoYXQgZG9lcyBub3QgYnVpbGQu CgpUaGUgbWFpbnRhaW5lcnMgc2ltcGx5IGRvbid0IGhhdmUgdGltZSB0byBob2xkIGV2ZXJ5b25l IGJ5IHRoZSBoYW5kLgpTb21ldGltZXMgSSB3aXNoIGl0IHdhcyBzdGlsbCBva2F5IHRvIHllbGwg YXQgcGVvcGxlIHdobyBwb3N0IGNvZGUKd2hpY2ggZG9lcyBub3QgYnVpbGQuIE9oIHdlbGwuCgou Li9kcml2ZXJzL25ldC9kc2EvcWNhL3FjYThrLWNvbW1vbi5jOjgxMDo1OiBlcnJvcjogY29uZmxp Y3RpbmcgdHlwZXMgZm9yIOKAmHFjYThrX3BvcnRfZmRiX2RlbOKAmQogaW50IHFjYThrX3BvcnRf ZmRiX2RlbChzdHJ1Y3QgZHNhX3N3aXRjaCAqZHMsIGludCBwb3J0LAogICAgIF5+fn5+fn5+fn5+ fn5+fn5+fgpJbiBmaWxlIGluY2x1ZGVkIGZyb20gLi4vZHJpdmVycy9uZXQvZHNhL3FjYS9xY2E4 ay1jb21tb24uYzoxMzoKLi4vZHJpdmVycy9uZXQvZHNhL3FjYS9xY2E4ay5oOjQ4Mzo1OiBub3Rl OiBwcmV2aW91cyBkZWNsYXJhdGlvbiBvZiDigJhxY2E4a19wb3J0X2ZkYl9kZWzigJkgd2FzIGhl cmUKIGludCBxY2E4a19wb3J0X2ZkYl9kZWwoc3RydWN0IGRzYV9zd2l0Y2ggKmRzLCBpbnQgcG9y dCwKICAgICBefn5+fn5+fn5+fn5+fn5+fn4KLi4vZHJpdmVycy9uZXQvZHNhL3FjYS9xY2E4ay1j b21tb24uYzogSW4gZnVuY3Rpb24g4oCYcWNhOGtfcG9ydF9mZGJfZGVs4oCZOgouLi9kcml2ZXJz L25ldC9kc2EvcWNhL3FjYThrLWNvbW1vbi5jOjgxODo2OiBlcnJvcjog4oCYZmRiX2ZsYWdz4oCZ IHVuZGVjbGFyZWQgKGZpcnN0IHVzZSBpbiB0aGlzIGZ1bmN0aW9uKTsgZGlkIHlvdSBtZWFuIOKA mHRzcV9mbGFnc+KAmT8KICBpZiAoZmRiX2ZsYWdzKQogICAgICBefn5+fn5+fn4KICAgICAgdHNx X2ZsYWdzCi4uL2RyaXZlcnMvbmV0L2RzYS9xY2EvcWNhOGstY29tbW9uLmM6ODE4OjY6IG5vdGU6 IGVhY2ggdW5kZWNsYXJlZCBpZGVudGlmaWVyIGlzIHJlcG9ydGVkIG9ubHkgb25jZSBmb3IgZWFj aCBmdW5jdGlvbiBpdCBhcHBlYXJzIGluCm1ha2VbNV06ICoqKiBbLi4vc2NyaXB0cy9NYWtlZmls ZS5idWlsZDoyNDk6IGRyaXZlcnMvbmV0L2RzYS9xY2EvcWNhOGstY29tbW9uLm9dIEVycm9yIDEK bWFrZVs1XTogKioqIFdhaXRpbmcgZm9yIHVuZmluaXNoZWQgam9icy4uLi4KbWFrZVs0XTogKioq IFsuLi9zY3JpcHRzL01ha2VmaWxlLmJ1aWxkOjQ2NTogZHJpdmVycy9uZXQvZHNhL3FjYV0gRXJy b3IgMgptYWtlWzRdOiAqKiogV2FpdGluZyBmb3IgdW5maW5pc2hlZCBqb2JzLi4uLgouLi9kcml2 ZXJzL25ldC9kc2Evc2phMTEwNS9zamExMTA1X21haW4uYzogSW4gZnVuY3Rpb24g4oCYc2phMTEw NV9mYXN0X2FnZeKAmToKLi4vZHJpdmVycy9uZXQvZHNhL3NqYTExMDUvc2phMTEwNV9tYWluLmM6 MTk0MTo2MTogZXJyb3I6IGluY29tcGF0aWJsZSB0eXBlIGZvciBhcmd1bWVudCA1IG9mIOKAmHNq YTExMDVfZmRiX2RlbOKAmQogICByYyA9IHNqYTExMDVfZmRiX2RlbChkcywgcG9ydCwgbWFjYWRk ciwgbDJfbG9va3VwLnZsYW5pZCwgZGIpOwogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXn4KLi4vZHJpdmVycy9uZXQvZHNhL3NqYTEx MDUvc2phMTEwNV9tYWluLmM6MTgzMToxMTogbm90ZTogZXhwZWN0ZWQg4oCYdTE24oCZIHtha2Eg 4oCYc2hvcnQgdW5zaWduZWQgaW504oCZfSBidXQgYXJndW1lbnQgaXMgb2YgdHlwZSDigJhzdHJ1 Y3QgZHNhX2Ri4oCZCiAgICAgICB1MTYgZmRiX2ZsYWdzLCBzdHJ1Y3QgZHNhX2RiIGRiKQogICAg ICAgfn5+fl5+fn5+fn5+fgouLi9kcml2ZXJzL25ldC9kc2Evc2phMTEwNS9zamExMTA1X21haW4u YzoxOTQxOjg6IGVycm9yOiB0b28gZmV3IGFyZ3VtZW50cyB0byBmdW5jdGlvbiDigJhzamExMTA1 X2ZkYl9kZWzigJkKICAgcmMgPSBzamExMTA1X2ZkYl9kZWwoZHMsIHBvcnQsIG1hY2FkZHIsIGwy X2xvb2t1cC52bGFuaWQsIGRiKTsKICAgICAgICBefn5+fn5+fn5+fn5+fn4KLi4vZHJpdmVycy9u ZXQvZHNhL3NqYTExMDUvc2phMTEwNV9tYWluLmM6MTgyOToxMjogbm90ZTogZGVjbGFyZWQgaGVy ZQogc3RhdGljIGludCBzamExMTA1X2ZkYl9kZWwoc3RydWN0IGRzYV9zd2l0Y2ggKmRzLCBpbnQg cG9ydCwKICAgICAgICAgICAgXn5+fn5+fn5+fn5+fn5+Ci4uL2RyaXZlcnMvbmV0L2RzYS9zamEx MTA1L3NqYTExMDVfbWFpbi5jOiBJbiBmdW5jdGlvbiDigJhzamExMTA1X21kYl9kZWzigJk6Ci4u L2RyaXZlcnMvbmV0L2RzYS9zamExMTA1L3NqYTExMDVfbWFpbi5jOjE5NjI6NTY6IGVycm9yOiBp bmNvbXBhdGlibGUgdHlwZSBmb3IgYXJndW1lbnQgNSBvZiDigJhzamExMTA1X2ZkYl9kZWzigJkK ICByZXR1cm4gc2phMTEwNV9mZGJfZGVsKGRzLCBwb3J0LCBtZGItPmFkZHIsIG1kYi0+dmlkLCBk Yik7CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgXn4KLi4vZHJpdmVycy9uZXQvZHNhL3NqYTExMDUvc2phMTEwNV9tYWluLmM6MTgzMToxMTog bm90ZTogZXhwZWN0ZWQg4oCYdTE24oCZIHtha2Eg4oCYc2hvcnQgdW5zaWduZWQgaW504oCZfSBi dXQgYXJndW1lbnQgaXMgb2YgdHlwZSDigJhzdHJ1Y3QgZHNhX2Ri4oCZCiAgICAgICB1MTYgZmRi X2ZsYWdzLCBzdHJ1Y3QgZHNhX2RiIGRiKQogICAgICAgfn5+fl5+fn5+fn5+fgouLi9kcml2ZXJz L25ldC9kc2Evc2phMTEwNS9zamExMTA1X21haW4uYzoxOTYyOjk6IGVycm9yOiB0b28gZmV3IGFy Z3VtZW50cyB0byBmdW5jdGlvbiDigJhzamExMTA1X2ZkYl9kZWzigJkKICByZXR1cm4gc2phMTEw NV9mZGJfZGVsKGRzLCBwb3J0LCBtZGItPmFkZHIsIG1kYi0+dmlkLCBkYik7CiAgICAgICAgIF5+ fn5+fn5+fn5+fn5+fgouLi9kcml2ZXJzL25ldC9kc2Evc2phMTEwNS9zamExMTA1X21haW4uYzox ODI5OjEyOiBub3RlOiBkZWNsYXJlZCBoZXJlCiBzdGF0aWMgaW50IHNqYTExMDVfZmRiX2RlbChz dHJ1Y3QgZHNhX3N3aXRjaCAqZHMsIGludCBwb3J0LAogICAgICAgICAgICBefn5+fn5+fn5+fn5+ fn4KLi4vZHJpdmVycy9uZXQvZHNhL3NqYTExMDUvc2phMTEwNV9tYWluLmM6MTk2MzoxOiBlcnJv cjogY29udHJvbCByZWFjaGVzIGVuZCBvZiBub24tdm9pZCBmdW5jdGlvbiBbLVdlcnJvcj1yZXR1 cm4tdHlwZV0KIH0KIF4KY2MxOiBzb21lIHdhcm5pbmdzIGJlaW5nIHRyZWF0ZWQgYXMgZXJyb3Jz Cm1ha2VbNV06ICoqKiBbLi4vc2NyaXB0cy9NYWtlZmlsZS5idWlsZDoyNDk6IGRyaXZlcnMvbmV0 L2RzYS9zamExMTA1L3NqYTExMDVfbWFpbi5vXSBFcnJvciAxCm1ha2VbNV06ICoqKiBXYWl0aW5n IGZvciB1bmZpbmlzaGVkIGpvYnMuLi4uCm1ha2VbNF06ICoqKiBbLi4vc2NyaXB0cy9NYWtlZmls ZS5idWlsZDo0NjU6IGRyaXZlcnMvbmV0L2RzYS9zamExMTA1XSBFcnJvciAyCm1ha2VbM106ICoq KiBbLi4vc2NyaXB0cy9NYWtlZmlsZS5idWlsZDo0NjU6IGRyaXZlcnMvbmV0L2RzYV0gRXJyb3Ig MgptYWtlWzNdOiAqKiogV2FpdGluZyBmb3IgdW5maW5pc2hlZCBqb2JzLi4uLgptYWtlWzJdOiAq KiogWy4uL3NjcmlwdHMvTWFrZWZpbGUuYnVpbGQ6NDY1OiBkcml2ZXJzL25ldF0gRXJyb3IgMgpt YWtlWzFdOiAqKiogWy9ob21lL2tpY2luc2tpL2xpbnV4L01ha2VmaWxlOjE4NTI6IGRyaXZlcnNd IEVycm9yIDIKbWFrZVsxXTogKioqIFdhaXRpbmcgZm9yIHVuZmluaXNoZWQgam9icy4uLi4KbWFr ZTogKioqIFtNYWtlZmlsZToyMjI6IF9fc3ViLW1ha2VdIEVycm9yIDIKCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGlu ZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMu aW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK