Re: [PATCH v3 3/5] dt-bindings: media: add cat24c208 bindings

[Rob Herring <robh@kernel.org>]

On Wed, Sep 28, 2022 at 01:21:45PM +0200, Erling Ljunggren wrote:
> Add devicetree bindings for new cat24c208 EDID EEPROM driver.
> 
> Signed-off-by: Erling Ljunggren <hljunggr@cisco.com>
> ---
>  .../bindings/media/i2c/onnn,cat24c208.yaml    | 48 +++++++++++++++++++
>  1 file changed, 48 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/media/i2c/onnn,cat24c208.yaml
> 
> diff --git a/Documentation/devicetree/bindings/media/i2c/onnn,cat24c208.yaml b/Documentation/devicetree/bindings/media/i2c/onnn,cat24c208.yaml
> new file mode 100644
> index 000000000000..fcfaccb5e39f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/onnn,cat24c208.yaml
> @@ -0,0 +1,48 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/i2c/onnn,cat24c208.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: ON Semiconductor CAT24C208 EDID EEPROM driver
> +
> +maintainers:
> +  - Hans Verkuil <hverkuil-cisco@xs4all.nl>
> +
> +description: |
> +  CAT24C208 is a dual port i2c EEPROM designed for EDID storage.
> +
> +
> +properties:
> +  compatible:
> +    const: onnn,cat24c208
> +
> +  reg:
> +    maxItems: 1
> +
> +  hpd-gpios:
> +    maxItems: 1
> +    description:
> +      References to the GPIO that controls the HDMI hot-plug detection pin.
> +      The active flag indicates the GPIO level that enables hot-plug detection.

This node is supposed to represent a device, cat24c208, but that device 
I'm guessing knows nothing about HPD. That's a property of the connector 
and belongs in a connector node much like we have for the other side of 
display connections. It may seem like overkill, but it frequently 
evolves such that not having a connector node becomes a problem. See 
'hdmi-connector' binding for example.

Rob