From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1oe4YD-0000Cn-QB for mharc-grub-devel@gnu.org; Thu, 29 Sep 2022 21:10:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45078) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oe1aQ-0000Ty-Jg for grub-devel@gnu.org; Thu, 29 Sep 2022 18:00:55 -0400 Received: from mail-pf1-x429.google.com ([2607:f8b0:4864:20::429]:43729) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oe1aL-0005zc-Ag for grub-devel@gnu.org; Thu, 29 Sep 2022 18:00:53 -0400 Received: by mail-pf1-x429.google.com with SMTP id d82so2594337pfd.10 for ; Thu, 29 Sep 2022 15:00:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date; bh=QJ2kFSIgGfhXLWfU7CxMiRT0yPVoevnI2AJFPd/fqUU=; b=G01zoJr2x3mYqyrtFW5ELIe1aRQuElj1rtZYWdHh3z1NzoD8afWUx9eSGlrrAucz83 30jECBPpy071JnCueVZZxIl6/SfF9r1+d34MsJbszQJwCBJt3ejfZPOLE1BAbM+nRXdf rUEDYfqdi67gXUPN4lPM0guR3iPHEeqcAhpbVAdeVqvwBwnk4rkKh+g/5iu4f75/v+U4 CSGMrLzzOuKTA3B7bgG4twQ4RG4xwkdw6lp2XIwcJmU2DovWmY8m1v3sj7ZCWHoxpgcW Xx2kJ6/fiKiQSlYVH08TBjg/WF3lrJp5wDz/uD4B/6uYSeCXymSyN4iqiEL58DDUd1Tp BsTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date; bh=QJ2kFSIgGfhXLWfU7CxMiRT0yPVoevnI2AJFPd/fqUU=; b=6lE3li6BiSoDKiAfphg1Zr0nQWTtc8kfL1mA4/6zXP8uxDRtIlg3c/A7gm4oRndLs5 YcNpLanOc8UjZUNxIdaRLEzka+FEKlJUhtafQBhYIO6q3aXwTzPNivPkdDEYw4+hiM8P 0fMTM+DMd3UPjRQiH1BSIwVlGcXIEmidN6BdlSV2w7Y3zxK05vGfM+gRvYFnVA0sl8MO TZwG41Wl0GJSnaRopnz4U3zh+U1yLtME8iG1UnXDD7ZcKGznjz5rDyQ/FdMa7GrITz7y APxCFO4qZZIZes17AIr+s9vNULQBB5tcrjuhZFyGcYatoWJ5bDOZhwH1CzwVt0hg5ImH TM+Q== X-Gm-Message-State: ACrzQf2qSwBYYolQZ0N+zO5HEV4epAHxyxqyMEzGEUGIv9GCP/Y9X6Pi CVWk1fBMOkywUyMonm3g7XwwQncr8J6EmQ== X-Google-Smtp-Source: AMsMyM60MSIYs3xtppurK07q57sxnike2hr7qVml1LiMa9QcEE5P3pyRtAW+LInTpDwTfHSD7k7bcg== X-Received: by 2002:a65:580a:0:b0:439:befc:d2b0 with SMTP id g10-20020a65580a000000b00439befcd2b0mr4687331pgr.302.1664488844716; Thu, 29 Sep 2022 15:00:44 -0700 (PDT) Received: from DESKTOP-I1ETA6N.dc1.ventanamicro.com (c-174-50-177-95.hsd1.ca.comcast.net. [174.50.177.95]) by smtp.gmail.com with ESMTPSA id m2-20020a17090a668200b00203c0a1d56bsm245766pjj.35.2022.09.29.15.00.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Sep 2022 15:00:43 -0700 (PDT) From: Tuan Phan To: Cc: grub-devel@gnu.org, Tuan Phan Subject: [PATCH] Fix __clzsi2 logic Date: Thu, 29 Sep 2022 15:00:26 -0700 Message-Id: <20220929220026.29621-1-tphan@ventanamicro.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::429; envelope-from=tphan@ventanamicro.com; helo=mail-pf1-x429.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Thu, 29 Sep 2022 21:10:48 -0400 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Sep 2022 22:00:55 -0000 Fix the incorrect return value of __clzsi2 function. Fixes: e795b90 ("RISC-V: Add libgcc helpers for clz") Signed-off-by: Tuan Phan --- grub-core/kern/compiler-rt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/grub-core/kern/compiler-rt.c b/grub-core/kern/compiler-rt.c index 2057c2e0c..55ae9f97e 100644 --- a/grub-core/kern/compiler-rt.c +++ b/grub-core/kern/compiler-rt.c @@ -431,7 +431,7 @@ __clzsi2 (grub_uint32_t val) for (; j; j >>= 1) { - if ((temp = val) >> j) + if ((temp = (val >> j))) { if (j == 1) { -- 2.25.1