From: Jakub Kicinski <kuba@kernel.org>
To: Edward Cree <ecree.xilinx@gmail.com>
Cc: netdev@vger.kernel.org, linux-net-drivers@amd.com,
davem@davemloft.net, pabeni@redhat.com, edumazet@google.com,
habetsm.xilinx@gmail.com
Subject: Re: [PATCH v2 net-next 3/6] sfc: optional logging of TC offload errors
Date: Fri, 30 Sep 2022 07:19:51 -0700 [thread overview]
Message-ID: <20220930071951.61f81da6@kernel.org> (raw)
In-Reply-To: <16da471c-076b-90b3-3935-abd31c6ef4d3@gmail.com>
On Fri, 30 Sep 2022 10:03:01 +0100 Edward Cree wrote:
> On 29/09/2022 02:15, Jakub Kicinski wrote:
> > Hm. I wonder if throwing a tracepoint into the extack setting
> > machinery would be a reasonable stop gap for debugging.
>
> It has one (do_trace_netlink_extack()), but sadly that won't play
> so well with formatted extacks since AIUI trace needs a constant
> string (I'm just giving it the format string in my prototype).
> But yeah it's better than nothing.
We can add a new one which copies the data. Presumably we'd have a "set
an extack msg which needs to be freed" helper were we could place it?
It'd mean we cut off at a static length but good enough, I say.
next prev parent reply other threads:[~2022-09-30 14:20 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-26 18:57 [PATCH v2 net-next 0/6] sfc: bare bones TC offload ecree
2022-09-26 18:57 ` [PATCH v2 net-next 1/6] sfc: bind blocks for TC offload on EF100 ecree
2022-09-28 8:43 ` Martin Habets
2022-09-26 18:57 ` [PATCH v2 net-next 2/6] sfc: bind indirect " ecree
2022-09-26 18:57 ` [PATCH v2 net-next 3/6] sfc: optional logging of TC offload errors ecree
2022-09-28 17:44 ` Jakub Kicinski
2022-09-28 18:17 ` Edward Cree
2022-09-28 18:32 ` Jakub Kicinski
2022-09-28 18:58 ` Edward Cree
2022-09-28 19:07 ` Jakub Kicinski
2022-09-28 21:14 ` Edward Cree
2022-09-29 1:15 ` Jakub Kicinski
2022-09-30 9:03 ` Edward Cree
2022-09-30 14:19 ` Jakub Kicinski [this message]
2022-10-03 19:30 ` Edward Cree
2022-09-26 18:57 ` [PATCH v2 net-next 4/6] sfc: add a hashtable for offloaded TC rules ecree
2022-09-26 18:57 ` [PATCH v2 net-next 5/6] sfc: interrogate MAE capabilities at probe time ecree
2022-09-26 18:57 ` [PATCH v2 net-next 6/6] sfc: bare bones TC offload on EF100 ecree
2022-09-28 8:50 ` [PATCH v2 net-next 0/6] sfc: bare bones TC offload patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220930071951.61f81da6@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=habetsm.xilinx@gmail.com \
--cc=linux-net-drivers@amd.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.