From: Jakub Kicinski <kuba@kernel.org>
To: David Yang <mmyangfl@gmail.com>
Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH v4] net: mv643xx_eth: support MII/GMII/RGMII modes for Kirkwood
Date: Fri, 30 Sep 2022 17:59:42 -0700 [thread overview]
Message-ID: <20220930175942.76db1900@kernel.org> (raw)
In-Reply-To: <20220930222540.966357-1-mmyangfl@gmail.com>
On Sat, 1 Oct 2022 06:25:39 +0800 David Yang wrote:
> Support mode switch properly, which is not available before.
>
> If SoC has two Ethernet controllers, by setting both of them into MII
> mode, the first controller enters GMII mode, while the second
> controller is effectively disabled. This requires configuring (and
> maybe enabling) the second controller in the device tree, even though
> it cannot be used.
Well, this version does not build:
drivers/net/ethernet/marvell/mv643xx_eth.c:1252:38: error: member reference type 'struct device' is not a pointer; did you mean to use '.'?
of_device_is_compatible(dev->dev->of_node,
~~~~~~~~^~
.
next prev parent reply other threads:[~2022-10-01 1:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-30 19:49 [PATCH] net: mv643xx_eth: support MII/GMII/RGMII modes David Yang
2022-09-30 20:28 ` Andrew Lunn
2022-09-30 20:39 ` [PATCH v2] " David Yang
2022-10-04 8:52 ` Paolo Abeni
2022-09-30 20:47 ` [PATCH] " Yangfl
2022-09-30 21:05 ` Andrew Lunn
2022-09-30 21:35 ` [PATCH v3] net: mv643xx_eth: support MII/GMII/RGMII modes for Kirkwood David Yang
2022-09-30 22:25 ` [PATCH v4] " David Yang
2022-10-01 0:59 ` Jakub Kicinski [this message]
2022-10-01 8:42 ` [PATCH v5] " David Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220930175942.76db1900@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=mmyangfl@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.