From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Robert Marko <robimarko@gmail.com>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/mdio-tools: new package
Date: Sat, 1 Oct 2022 20:51:47 +0200 [thread overview]
Message-ID: <20221001185147.GP30794@scaer> (raw)
In-Reply-To: <20220928192324.1279960-1-robimarko@gmail.com>
Robert, All,
On 2022-09-28 21:23 +0200, Robert Marko spake thusly:
> mdio-tools are kernel module and accompanying tools for low-level
> debugging of devices attached on MDIO bus like PHY-s, switches etc.
>
> Userspace tools provide C22 or C45 reads and writes, benchmarking
> and even dedicated Marvell Link Street tools via the included
> kernel module.
>
> Signed-off-by: Robert Marko <robimarko@gmail.com>
> ---
[--SNIP--]
> diff --git a/package/mdio-tools/mdio-tools.mk b/package/mdio-tools/mdio-tools.mk
> new file mode 100644
> index 0000000000..e4ea6f8224
> --- /dev/null
> +++ b/package/mdio-tools/mdio-tools.mk
> @@ -0,0 +1,16 @@
> +################################################################################
> +#
> +# mdio-tools
> +#
> +################################################################################
> +
> +MDIO_TOOLS_VERSION = 1.2.0
> +MDIO_TOOLS_SITE = https://github.com/wkz/mdio-tools/releases/download/$(MDIO_TOOLS_VERSION)
> +MDIO_TOOLS_LICENSE = GPL-2.0-only
We do not strictly follow the SPDX nomenclature (because we somewhat
predate it), so for consistency, this should be just 'GPL-2.0'.
> +MDIO_TOOLS_LICENSE_FILES = COPYING
> +MDIO_TOOLS_DEPENDENCIES = libmnl
mdio-tools uses pkg-config to look for libmnl, so you also need to add
host-pkgconf to the _DEPENDENCES.
> +MDIO_TOOLS_MODULE_SUBDIRS = kernel
I did not have a thorough look, but doesn't mdio-tools need some kernel
options to always be enabled? IF so, you can do so with:
define MDIO_TOOLS_LINUX_CONFIG_FIXUPS
$(call KCONFIG_ENABLE_OPT,CONFIG_MDIO)
endef
(given the package name, it should at least require that, I'd guess, but
adapt as needed.)
If there had been only the license and host-pkgconf issues, I'd have
fixed those when applying. But the kernel options are a bit more
involved, and requie someone who actually knows and uses mdio-tools, to
come up with the required options. Can you look into that, please?
Regards,
Yann E. MORIN.
> +$(eval $(kernel-module))
> +$(eval $(autotools-package))
> --
> 2.37.3
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-10-01 18:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-28 19:23 [Buildroot] [PATCH] package/mdio-tools: new package Robert Marko
2022-10-01 18:51 ` Yann E. MORIN [this message]
2022-10-01 19:05 ` Robert Marko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221001185147.GP30794@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=robimarko@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.