From: Jakub Kicinski <kuba@kernel.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, kvalo@kernel.org, johannes@sipsolutions.net,
linux-wireless@vger.kernel.org, mkl@pengutronix.de,
linux-can@vger.kernel.org
Subject: Re: [PATCH net-next] net: drop the weight argument from netif_napi_add
Date: Sun, 2 Oct 2022 10:59:38 -0700 [thread overview]
Message-ID: <20221002105938.684fec1f@kernel.org> (raw)
In-Reply-To: <20221002172427.GA3027039@roeck-us.net>
On Sun, 2 Oct 2022 10:24:27 -0700 Guenter Roeck wrote:
> On Tue, Sep 27, 2022 at 06:27:53AM -0700, Jakub Kicinski wrote:
> > We tell driver developers to always pass NAPI_POLL_WEIGHT
> > as the weight to netif_napi_add(). This may be confusing
> > to newcomers, drop the weight argument, those who really
> > need to tweak the weight can use netif_napi_add_weight().
> >
> > Signed-off-by: Jakub Kicinski <kuba@kernel.org>
>
> That seems to have missed some (or at least one) file(s).
>
> Building mips:cavium_octeon_defconfig ... failed
> --------------
> Error log:
> drivers/net/ethernet/cavium/octeon/octeon_mgmt.c: In function 'octeon_mgmt_probe':
> drivers/net/ethernet/cavium/octeon/octeon_mgmt.c:1399:9: error: too many arguments to function 'netif_napi_add'
> 1399 | netif_napi_add(netdev, &p->napi, octeon_mgmt_napi_poll,
> | ^~~~~~~~~~~~~~
> In file included from include/linux/etherdevice.h:21,
> from drivers/net/ethernet/cavium/octeon/octeon_mgmt.c:11:
> include/linux/netdevice.h:2562:1: note: declared here
> 2562 | netif_napi_add(struct net_device *dev, struct napi_struct *napi,
Fix sent, sorry. I don't see any more problems grepping again now..
next prev parent reply other threads:[~2022-10-02 18:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-27 13:27 [PATCH net-next] net: drop the weight argument from netif_napi_add Jakub Kicinski
2022-09-27 13:31 ` Marc Kleine-Budde
2022-09-27 15:54 ` Jason A. Donenfeld
2022-09-27 17:54 ` Eric Dumazet
2022-09-27 18:17 ` Jakub Kicinski
2022-09-27 18:38 ` Eric Dumazet
2022-09-27 18:26 ` Dave Taht
2022-09-29 2:20 ` patchwork-bot+netdevbpf
2022-10-02 17:24 ` Guenter Roeck
2022-10-02 17:59 ` Jakub Kicinski [this message]
2022-10-02 23:02 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221002105938.684fec1f@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=johannes@sipsolutions.net \
--cc=kvalo@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.