From: Bjorn Helgaas <helgaas@kernel.org>
To: Jonathan Derrick <jonathan.derrick@linux.dev>
Cc: "Pali Rohár" <pali@kernel.org>, "Lukas Wunner" <lukas@wunner.de>,
"Vidya Sagar" <vidyas@nvidia.com>,
bhelgaas@google.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, lpieralisi@kernel.org,
kw@linux.com, thierry.reding@gmail.com, jonathanh@nvidia.com,
mani@kernel.org, Sergey.Semin@baikalelectronics.ru,
jszhang@kernel.org, linux-pci@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, kthota@nvidia.com,
mmaddireddy@nvidia.com, sagar.tv@gmail.com,
"Marek Behún" <kabel@kernel.org>
Subject: Re: [PATCH V1 0/4] GPIO based PCIe Hot-Plug support
Date: Mon, 3 Oct 2022 13:09:49 -0500 [thread overview]
Message-ID: <20221003180949.GA2104321@bhelgaas> (raw)
In-Reply-To: <2a465222-342a-418b-95af-9948f6ce9065@linux.dev>
On Sat, Oct 01, 2022 at 05:50:07PM -0600, Jonathan Derrick wrote:
> On 10/1/2022 10:20 AM, Pali Rohár wrote:
> ...
> > Would not it better to rather synthesise PCIe Slot Capabilities support
> > in your PCIe Root Port device (e.g. via pci-bridge-emul.c) and then let
> > existing PCI hotplug code to take care for hotplugging? Because it
> > already implements all required stuff for re-scanning, registering and
> > unregistering PCIe devices for Root Ports with Slot Capabilities. And I
> > think that there is no need to have just another (GPIO based)
> > implementation of PCI hotplug.
>
> I did that a few years ago (rejected), but can attest to the robustness of
> the pcie hotplug code on non-hotplug slots.
> https://lwn.net/Articles/811988/
I think the thread is here:
https://lore.kernel.org/linux-pci/1581120007-5280-1-git-send-email-jonathan.derrick@intel.com/
and I'm sorry that my response came across as "rejected". I intended
it as "this is good ideas and good work and we should keep going".
Bjorn
next prev parent reply other threads:[~2022-10-03 18:10 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-30 19:27 [PATCH V1 0/4] GPIO based PCIe Hot-Plug support Vidya Sagar
2022-09-30 19:27 ` [PATCH V1 1/4] dt-bindings: Add "hotplug-gpios" PCIe property Vidya Sagar
2022-10-01 15:56 ` Lukas Wunner
2022-10-01 16:10 ` Pali Rohár
2022-09-30 19:27 ` [PATCH V1 2/4] PCI/hotplug: Add GPIO PCIe hotplug driver Vidya Sagar
2022-09-30 19:27 ` [PATCH V1 3/4] PCI: tegra194: Add support to configure a pluggable slot Vidya Sagar
2022-09-30 19:27 ` [PATCH V1 4/4] PCI: tegra194: Enable GPIO based Hot-Plug support Vidya Sagar
2022-10-01 16:00 ` [PATCH V1 0/4] GPIO based PCIe " Lukas Wunner
2022-10-01 16:20 ` Pali Rohár
2022-10-01 23:50 ` Jonathan Derrick
2022-10-03 18:09 ` Bjorn Helgaas [this message]
2022-10-03 18:21 ` Pali Rohár
2022-10-03 19:18 ` Jonathan Derrick
2022-10-04 4:04 ` Vidya Sagar
2022-10-10 6:14 ` Vidya Sagar
2022-10-17 2:46 ` Vidya Sagar
2022-11-09 15:35 ` Manivannan Sadhasivam
2022-10-03 17:04 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221003180949.GA2104321@bhelgaas \
--to=helgaas@kernel.org \
--cc=Sergey.Semin@baikalelectronics.ru \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=jonathan.derrick@linux.dev \
--cc=jonathanh@nvidia.com \
--cc=jszhang@kernel.org \
--cc=kabel@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kthota@nvidia.com \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=lukas@wunner.de \
--cc=mani@kernel.org \
--cc=mmaddireddy@nvidia.com \
--cc=pali@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sagar.tv@gmail.com \
--cc=thierry.reding@gmail.com \
--cc=vidyas@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.