From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1ofQCi-000634-DS for mharc-grub-devel@gnu.org; Mon, 03 Oct 2022 14:30:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37714) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ofQCc-00061w-9B for grub-devel@gnu.org; Mon, 03 Oct 2022 14:30:07 -0400 Received: from mail-pj1-x1029.google.com ([2607:f8b0:4864:20::1029]:35479) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ofQCa-0002po-Lz for grub-devel@gnu.org; Mon, 03 Oct 2022 14:30:05 -0400 Received: by mail-pj1-x1029.google.com with SMTP id d1-20020a17090a6a4100b002095b319b9aso10156382pjm.0 for ; Mon, 03 Oct 2022 11:30:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=j0O20GODDIC7JPsFPfnhLR65OlvFh9NAu0yn1h7LqRE=; b=Rl8FIz+IXURL3m357n6hIcz0vKUfgE4VFP1IRPphIblDZRqVH93bUYYdDcPm2GfxN2 mNhI+7YVXTS6ArDNk6R5vHle5tT6If82hVxsXQQ+6AuipVifDG5NBkDbU5JbIcK9hiTp IZaL5+CUl/nic7o6HFcqdTt4BMiNQ5i4njQXAVUYULrnfqTzgJ4LZzudVWePVd0vMYu7 K13tIkUa7uf4Q/zLhdb0jm0thm1pKuhuym16gaHS0u7tTKCyf15sgtWmyRUaq0TF+91A 0loLFfhoFSApDIsl9ebG/3OMz2lQGbUW9b/5sOZFup/RhGM0sXT+Od4rApNfOrJauKXf TQQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=j0O20GODDIC7JPsFPfnhLR65OlvFh9NAu0yn1h7LqRE=; b=Esw3LGFbmQvXS9t2NUgJpvcJB9j+QSmS+KY21qqsY8dkWs2SJ9SfnY44JrHg8qwXAH 4V3/8tmwUwghUR4z3IOzSEQvoqfbDsYTTImdhrA77U1ukP9LdJkcyJ5OSVqQ0eQFy1a1 6omaUwZ0hGiB91s33cg6f3xwWNlj0eN0j233bIDudmpem1xM2mdLEb11CtSOzL8SoGUq 0pvAM+kXPJ/iVk9jW7Ey/DPvkgZMPPyO0cIQAjhO/ZIr2tSqHJGnCuGpV+c4auoXyVG5 Is9uItQ+Ivn9Zkb350kh9lN/X+FZbRdXRpyAxJ3/raSqKUBTrWTiWcumM7mhoUCA8Rs/ 8rog== X-Gm-Message-State: ACrzQf01oI6iuCUKAz/pdoKjABltMrZsQOruaXAIeVdEyeKjEf/ZVmgG VUVdhyaYt//yNhMfjKiK7VIl2tPiY3xGKw== X-Google-Smtp-Source: AMsMyM79c6F0fPaEQ24OjiXEn2h5UvmEw+rs2tCKZuVAIzSQUbnNBMrdpsMOzaAC8Fa7PlhRzjkXdw== X-Received: by 2002:a17:902:e801:b0:178:11e9:2ba2 with SMTP id u1-20020a170902e80100b0017811e92ba2mr22295271plg.26.1664821800655; Mon, 03 Oct 2022 11:30:00 -0700 (PDT) Received: from DESKTOP-I1ETA6N.dc1.ventanamicro.com (c-174-50-177-95.hsd1.ca.comcast.net. [174.50.177.95]) by smtp.gmail.com with ESMTPSA id im16-20020a170902bb1000b001730a1af0fbsm7484885plb.23.2022.10.03.11.29.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Oct 2022 11:30:00 -0700 (PDT) From: Tuan Phan To: Cc: grub-devel@gnu.org, Tuan Phan , Daniel Kiper Subject: [PATCH v2] Fix __clzsi2 logic Date: Mon, 3 Oct 2022 11:29:21 -0700 Message-Id: <20221003182921.15998-1-tphan@ventanamicro.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221003152600.n5gyqa3yichfapal@tomti.i.net-space.pl> References: <20221003152600.n5gyqa3yichfapal@tomti.i.net-space.pl> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::1029; envelope-from=tphan@ventanamicro.com; helo=mail-pj1-x1029.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Oct 2022 18:30:09 -0000 Fix the incorrect return value of __clzsi2 function. Fixes: e795b90 ("RISC-V: Add libgcc helpers for clz") Signed-off-by: Tuan Phan Reviewed-by: Daniel Kiper --- V2: Drop redundant brackets Signed-off-by: Tuan Phan --- grub-core/kern/compiler-rt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/grub-core/kern/compiler-rt.c b/grub-core/kern/compiler-rt.c index 2057c2e0c..738bb8420 100644 --- a/grub-core/kern/compiler-rt.c +++ b/grub-core/kern/compiler-rt.c @@ -431,7 +431,7 @@ __clzsi2 (grub_uint32_t val) for (; j; j >>= 1) { - if ((temp = val) >> j) + if (temp = (val >> j)) { if (j == 1) { -- 2.25.1