Re: [OE-core] [PATCH v2 3/5] u-boot: use openssl-native.bbclass

[Luca Ceresoli <luca.ceresoli@bootlin.com>]

Hello Mikko,

On Tue,  4 Oct 2022 18:28:07 +0300
"Mikko Rapeli" <mikko.rapeli@linaro.org> wrote:

> It sets all environment variables correctly for openssl-native.
> 
> Signed-off-by: Mikko Rapeli <mikko.rapeli@linaro.org>

I'm taking this patch for testing, however I have a question, see below.

> ---
>  meta/recipes-bsp/u-boot/u-boot.inc | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-bsp/u-boot/u-boot.inc b/meta/recipes-bsp/u-boot/u-boot.inc
> index f022aed732..cd9c578962 100644
> --- a/meta/recipes-bsp/u-boot/u-boot.inc
> +++ b/meta/recipes-bsp/u-boot/u-boot.inc
> @@ -17,7 +17,8 @@ PACKAGECONFIG ??= "openssl"
>  # u-boot will compile its own tools during the build, with specific
>  # configurations (aka when CONFIG_FIT_SIGNATURE is enabled) openssl is needed as
>  # a host build dependency.
> -PACKAGECONFIG[openssl] = ",,openssl-native"
> +OPENSSL_INHERIT .= "${@bb.utils.contains('PACKAGECONFIG', 'openssl', 'openssl-native', '', d)}"

What is the reason to use '.=' and not just '=' here?

> +inherit ${OPENSSL_INHERIT}
>  
>  # Allow setting an additional version string that will be picked up by the
>  # u-boot build system and appended to the u-boot version.  If the .scmversion



-- 
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com