From: Mauro Carvalho Chehab <mauro.chehab@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t v4 15/77] i915/gem_workarounds: Close device before exit
Date: Wed, 5 Oct 2022 09:44:44 +0200 [thread overview]
Message-ID: <20221005074546.55955-16-mauro.chehab@linux.intel.com> (raw)
In-Reply-To: <20221005074546.55955-1-mauro.chehab@linux.intel.com>
From: Chris Wilson <chris.p.wilson@intel.com>
Close the device fd before we check for leaks during the atexit
handlers.
Signed-off-by: Chris Wilson <chris.p.wilson@intel.com>
Reviewed-by: Nirmoy Das<nirmoy.das@intel.com>
Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
---
tests/i915/gem_workarounds.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/i915/gem_workarounds.c b/tests/i915/gem_workarounds.c
index fc5184925a88..5fb2d73fdd30 100644
--- a/tests/i915/gem_workarounds.c
+++ b/tests/i915/gem_workarounds.c
@@ -31,6 +31,7 @@
#include "i915/gem_create.h"
#include "igt.h"
#include "igt_device.h"
+#include "igt_types.h"
#define PAGE_SIZE 4096
#define PAGE_ALIGN(x) ALIGN(x, PAGE_SIZE)
@@ -238,7 +239,6 @@ static void check_workarounds(int fd, enum operation op, unsigned int flags)
igt_main
{
struct intel_mmio_data mmio_data;
- int device = -1;
const struct {
const char *name;
enum operation op;
@@ -258,6 +258,7 @@ igt_main
{ "-fd", FD },
{ }
}, *m;
+ igt_fd_t(device);
igt_fixture {
FILE *file;
--
2.37.3
next prev parent reply other threads:[~2022-10-05 7:46 UTC|newest]
Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-05 7:44 [igt-dev] [PATCH i-g-t v4 00/77] Ensure that file descriptors will be closed on exit Mauro Carvalho Chehab
2022-10-05 7:44 ` [igt-dev] [PATCH i-g-t v4 01/77] lib: Introduce typed cleanups Mauro Carvalho Chehab
[not found] ` <Yz1WCjOSxGBbtEyt@kamilkon-desk1>
2022-10-05 10:22 ` Mauro Carvalho Chehab
2022-10-05 7:44 ` [igt-dev] [PATCH i-g-t v4 02/77] i915/gem_basic: Close device before exit Mauro Carvalho Chehab
2022-10-05 7:44 ` [igt-dev] [PATCH i-g-t v4 03/77] i915/gem_flink_basic: " Mauro Carvalho Chehab
2022-10-05 7:44 ` [igt-dev] [PATCH i-g-t v4 04/77] i915/gem_linear_blits: " Mauro Carvalho Chehab
[not found] ` <8735c2sf1d.fsf@intel.com>
2022-10-05 13:13 ` Mauro Carvalho Chehab
[not found] ` <87wn9eqqju.fsf@intel.com>
2022-10-05 16:53 ` Mauro Carvalho Chehab
2022-10-05 7:44 ` [igt-dev] [PATCH i-g-t v4 05/77] i915/gem_blits: " Mauro Carvalho Chehab
2022-10-05 7:44 ` [igt-dev] [PATCH i-g-t v4 06/77] i915/gem_close: " Mauro Carvalho Chehab
2022-10-05 7:44 ` [igt-dev] [PATCH i-g-t v4 07/77] i915/gem_create: " Mauro Carvalho Chehab
2022-10-05 7:44 ` [igt-dev] [PATCH i-g-t v4 08/77] i915/gem_ctx_engines: " Mauro Carvalho Chehab
2022-10-05 7:44 ` [igt-dev] [PATCH i-g-t v4 09/77] i915/gem_ctx_shared: " Mauro Carvalho Chehab
2022-10-05 7:44 ` [igt-dev] [PATCH i-g-t v4 10/77] i915/gem_exec_alignment: " Mauro Carvalho Chehab
2022-10-05 7:44 ` [igt-dev] [PATCH i-g-t v4 11/77] i915/gem_render_copy: " Mauro Carvalho Chehab
2022-10-05 7:44 ` [igt-dev] [PATCH i-g-t v4 12/77] i915/gem_render_copy_redux: " Mauro Carvalho Chehab
2022-10-05 7:44 ` [igt-dev] [PATCH i-g-t v4 13/77] i915/gem_media_fill: " Mauro Carvalho Chehab
2022-10-05 7:44 ` [igt-dev] [PATCH i-g-t v4 14/77] i915/gem_userptr_blits: " Mauro Carvalho Chehab
2022-10-05 7:44 ` Mauro Carvalho Chehab [this message]
2022-10-05 7:44 ` [igt-dev] [PATCH i-g-t v4 16/77] i915/gem_unref_active_buffers: " Mauro Carvalho Chehab
2022-10-05 7:44 ` [igt-dev] [PATCH i-g-t v4 17/77] i915/gem_exec_endless: " Mauro Carvalho Chehab
2022-10-05 7:44 ` [igt-dev] [PATCH i-g-t v4 18/77] i915/gem_request_retire: " Mauro Carvalho Chehab
2022-10-05 7:44 ` [igt-dev] [PATCH i-g-t v4 19/77] i915/gem_unfence_active_buffers: " Mauro Carvalho Chehab
2022-10-05 7:44 ` [igt-dev] [PATCH i-g-t v4 20/77] i915/i915_pciid: " Mauro Carvalho Chehab
2022-10-05 7:44 ` [igt-dev] [PATCH i-g-t v4 21/77] kms_cursor_legacy: " Mauro Carvalho Chehab
2022-10-05 7:44 ` [igt-dev] [PATCH i-g-t v4 22/77] kms_flip: " Mauro Carvalho Chehab
2022-10-05 7:44 ` [igt-dev] [PATCH i-g-t v4 23/77] kms_pipe_crc_basic: " Mauro Carvalho Chehab
2022-10-05 7:44 ` [igt-dev] [PATCH i-g-t v4 24/77] kms_psr: " Mauro Carvalho Chehab
2022-10-05 7:44 ` [igt-dev] [PATCH i-g-t v4 25/77] kms_flip: " Mauro Carvalho Chehab
2022-10-05 7:44 ` [igt-dev] [PATCH i-g-t v4 26/77] kms_force_connector_basic: " Mauro Carvalho Chehab
2022-10-05 7:44 ` [igt-dev] [PATCH i-g-t v4 27/77] dumb_buffer: " Mauro Carvalho Chehab
2022-10-05 7:44 ` [igt-dev] [PATCH i-g-t v4 28/77] kms_atomic: " Mauro Carvalho Chehab
2022-10-05 7:44 ` [igt-dev] [PATCH i-g-t v4 29/77] kms_atomic_interruptible: " Mauro Carvalho Chehab
2022-10-05 7:44 ` [igt-dev] [PATCH i-g-t v4 30/77] kms_atomic_transition: " Mauro Carvalho Chehab
2022-10-05 7:45 ` [igt-dev] [PATCH i-g-t v4 31/77] i915/kms_big_fb: " Mauro Carvalho Chehab
2022-10-05 7:45 ` [igt-dev] [PATCH i-g-t v4 32/77] i915/kms_ccs: " Mauro Carvalho Chehab
2022-10-05 7:45 ` [igt-dev] [PATCH i-g-t v4 33/77] kms_color: " Mauro Carvalho Chehab
2022-10-05 7:45 ` [igt-dev] [PATCH i-g-t v4 34/77] kms_cursor_crc: " Mauro Carvalho Chehab
2022-10-05 7:45 ` [igt-dev] [PATCH i-g-t v4 35/77] i915/kms_big_joiner: " Mauro Carvalho Chehab
2022-10-05 7:45 ` [igt-dev] [PATCH i-g-t v4 36/77] i915/kms_cdclk: " Mauro Carvalho Chehab
2022-10-05 7:45 ` [igt-dev] [PATCH i-g-t v4 37/77] i915/kms_fence_pin_leak: " Mauro Carvalho Chehab
2022-10-05 7:45 ` [igt-dev] [PATCH i-g-t v4 38/77] i915/kms_flip_scaled_crc: " Mauro Carvalho Chehab
2022-10-05 7:45 ` [igt-dev] [PATCH i-g-t v4 39/77] i915/kms_flip_tiling: " Mauro Carvalho Chehab
2022-10-05 7:45 ` [igt-dev] [PATCH i-g-t v4 40/77] i915/kms_mmap_write_crc: " Mauro Carvalho Chehab
2022-10-05 7:45 ` [igt-dev] [PATCH i-g-t v4 41/77] i915/kms_pipe_b_c_ivb: " Mauro Carvalho Chehab
2022-10-05 7:45 ` [igt-dev] [PATCH i-g-t v4 42/77] i915/kms_psr2_sf: " Mauro Carvalho Chehab
2022-10-05 7:45 ` [igt-dev] [PATCH i-g-t v4 43/77] i915/kms_psr2_su: " Mauro Carvalho Chehab
2022-10-05 7:45 ` [igt-dev] [PATCH i-g-t v4 44/77] i915/kms_pwrite_crc: " Mauro Carvalho Chehab
2022-10-05 7:45 ` [igt-dev] [PATCH i-g-t v4 45/77] kms_flip_event_leak: " Mauro Carvalho Chehab
2022-10-05 7:45 ` [igt-dev] [PATCH i-g-t v4 46/77] kms_hdr: " Mauro Carvalho Chehab
2022-10-05 7:45 ` [igt-dev] [PATCH i-g-t v4 47/77] kms_invalid_mode: " Mauro Carvalho Chehab
2022-10-05 7:45 ` [igt-dev] [PATCH i-g-t v4 48/77] kms_panel_fitting: " Mauro Carvalho Chehab
2022-10-05 7:45 ` [igt-dev] [PATCH i-g-t v4 49/77] kms_plane: " Mauro Carvalho Chehab
2022-10-05 7:45 ` [igt-dev] [PATCH i-g-t v4 50/77] kms_plane_alpha_blend: " Mauro Carvalho Chehab
2022-10-05 7:45 ` [igt-dev] [PATCH i-g-t v4 51/77] kms_plane_cursor: " Mauro Carvalho Chehab
2022-10-05 7:45 ` [igt-dev] [PATCH i-g-t v4 52/77] kms_plane_multiple: " Mauro Carvalho Chehab
2022-10-05 7:45 ` [igt-dev] [PATCH i-g-t v4 53/77] kms_plane_scaling: " Mauro Carvalho Chehab
2022-10-05 7:45 ` [igt-dev] [PATCH i-g-t v4 54/77] kms_properties: " Mauro Carvalho Chehab
2022-10-05 7:45 ` [igt-dev] [PATCH i-g-t v4 55/77] kms_rotation_crc: " Mauro Carvalho Chehab
2022-10-05 7:45 ` [igt-dev] [PATCH i-g-t v4 56/77] kms_sequence: " Mauro Carvalho Chehab
2022-10-05 7:45 ` [igt-dev] [PATCH i-g-t v4 57/77] kms_universal_plane: " Mauro Carvalho Chehab
2022-10-05 7:45 ` [igt-dev] [PATCH i-g-t v4 58/77] kms_vblank: " Mauro Carvalho Chehab
2022-10-05 7:45 ` [igt-dev] [PATCH i-g-t v4 59/77] syncobj_wait: " Mauro Carvalho Chehab
2022-10-05 7:45 ` [igt-dev] [PATCH i-g-t v4 60/77] syncobj_basic: " Mauro Carvalho Chehab
2022-10-05 7:45 ` [igt-dev] [PATCH i-g-t v4 61/77] syncobj_timeline: " Mauro Carvalho Chehab
2022-10-05 7:45 ` [igt-dev] [PATCH i-g-t v4 62/77] drm_import_export: " Mauro Carvalho Chehab
2022-10-05 7:45 ` [igt-dev] [PATCH i-g-t v4 63/77] kms_dp_aux_dev: " Mauro Carvalho Chehab
2022-10-05 7:45 ` [igt-dev] [PATCH i-g-t v4 64/77] kms_hdmi_inject: " Mauro Carvalho Chehab
2022-10-05 7:45 ` [igt-dev] [PATCH i-g-t v4 65/77] kms_3d: " Mauro Carvalho Chehab
2022-10-05 7:45 ` [igt-dev] [PATCH i-g-t v4 66/77] kms_scaling_modes: " Mauro Carvalho Chehab
2022-10-05 7:45 ` [igt-dev] [PATCH i-g-t v4 67/77] kms_dither: " Mauro Carvalho Chehab
2022-10-05 8:44 ` Kamil Konieczny
2022-10-05 7:45 ` [igt-dev] [PATCH i-g-t v4 68/77] drm_read: " Mauro Carvalho Chehab
2022-10-05 7:45 ` [igt-dev] [PATCH i-g-t v4 69/77] kms_cursor_edge_walk: " Mauro Carvalho Chehab
2022-10-05 7:45 ` [igt-dev] [PATCH i-g-t v4 70/77] kms_plane_lowres: " Mauro Carvalho Chehab
2022-10-05 7:45 ` [igt-dev] [PATCH i-g-t v4 71/77] kms_content_protection: " Mauro Carvalho Chehab
2022-10-05 7:45 ` [igt-dev] [PATCH i-g-t v4 72/77] feature_discovery: " Mauro Carvalho Chehab
2022-10-05 7:45 ` [igt-dev] [PATCH i-g-t v4 73/77] i915/i915_pm_dc: " Mauro Carvalho Chehab
2022-10-05 7:45 ` [igt-dev] [PATCH i-g-t v4 74/77] core_auth: Close(master) " Mauro Carvalho Chehab
2022-10-05 7:45 ` [igt-dev] [PATCH i-g-t v4 75/77] i915/gem_exec_balancer: Close device " Mauro Carvalho Chehab
2022-10-05 7:45 ` [igt-dev] [PATCH i-g-t v4 76/77] i915/gem_ctx_isolation: " Mauro Carvalho Chehab
2022-10-05 7:45 ` [igt-dev] [PATCH i-g-t v4 77/77] igt_core: add a line break at the end of some internal_assert Mauro Carvalho Chehab
2022-10-05 8:42 ` Kamil Konieczny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221005074546.55955-16-mauro.chehab@linux.intel.com \
--to=mauro.chehab@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.