All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@denx.de>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: "Guilherme G. Piccoli" <gpiccoli@igalia.com>,
	"tglx@linutronix.de" <tglx@linutronix.de>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"x86@kernel.org" <x86@kernel.org>,
	"mingo@redhat.com" <mingo@redhat.com>,
	"bp@alien8.de" <bp@alien8.de>,
	"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
	"hpa@zytor.com" <hpa@zytor.com>,
	"Lutomirski, Andy" <luto@kernel.org>,
	"kernel-dev@igalia.com" <kernel-dev@igalia.com>,
	"kernel@gpiccoli.net" <kernel@gpiccoli.net>,
	"Yu, Fenghua" <fenghua.yu@intel.com>,
	Joshua Ashton <joshua@froggi.es>,
	Paul Gofman <pgofman@codeweavers.com>,
	Pavel Machek <pavel@denx.de>,
	Pierre-Loup Griffais <pgriffais@valvesoftware.com>,
	Melissa Wen <mwen@igalia.com>
Subject: Re: [PATCH] x86/split_lock: Restore warn mode (and add a new one) to avoid userspace regression
Date: Thu, 6 Oct 2022 11:04:18 +0200	[thread overview]
Message-ID: <20221006090418.GA14960@amd> (raw)
In-Reply-To: <SJ1PR11MB6083113884DD0B3031FE372CFC549@SJ1PR11MB6083.namprd11.prod.outlook.com>

[-- Attachment #1: Type: text/plain, Size: 1198 bytes --]

On Wed 2022-09-28 20:24:23, Luck, Tony wrote:
> > So let's revamp the idea of having another option/mode for the split
> > lock detector, which is hereby called "seq" (based on the original
> > "sequential" naming in [0]). Also introduces a Kconfig option to give
> > the option of Linux vendors have a choice what mode should be their
> > default. While at it, fix/improve the documentation about bus locking.
> >
> > [1] https://github.com/doitsujin/dxvk/issues/2938
> 
> Why not just use the workaround suggested in that bug report:
> 
>    "so manual switching from default setting to split_lock_detect=off helps as workaround here"
> 
> If you add this extra mode, I'm going to argue that the kernel default
> should be "seq" rather than "warn". So these game players will need
> to add a split_lock_detect=off (or warn) option.

Kernel should not cause userland regressions, and this is one. That
should make it pretty clear what the solution is.

And no, I don't like CONFIG option, either.

Best regards,
								Pavel
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

  parent reply	other threads:[~2022-10-06  9:04 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-28 14:21 [PATCH] x86/split_lock: Restore warn mode (and add a new one) to avoid userspace regression Guilherme G. Piccoli
2022-09-28 20:24 ` Luck, Tony
2022-09-28 20:50   ` Joshua Ashton
2022-09-28 20:56   ` Guilherme G. Piccoli
2022-10-06 20:15     ` Thomas Gleixner
2022-10-06 20:58       ` Guilherme G. Piccoli
2022-10-06  9:04   ` Pavel Machek [this message]
2022-10-06 15:07     ` Guilherme G. Piccoli
2022-09-28 21:50 ` Dave Hansen
2022-09-29 14:57   ` Guilherme G. Piccoli
2022-09-29 15:17     ` Dave Hansen
2022-09-29 15:30       ` Guilherme G. Piccoli
2022-09-29 16:26         ` Dave Hansen
2022-09-29 17:15           ` Guilherme G. Piccoli
2022-09-29 17:23           ` Paul Gofman
2022-09-29 15:37       ` Luck, Tony
2022-10-30 16:13         ` Lukas Straub
2022-09-29 17:17   ` Zebediah Figura

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221006090418.GA14960@amd \
    --to=pavel@denx.de \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=fenghua.yu@intel.com \
    --cc=gpiccoli@igalia.com \
    --cc=hpa@zytor.com \
    --cc=joshua@froggi.es \
    --cc=kernel-dev@igalia.com \
    --cc=kernel@gpiccoli.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mingo@redhat.com \
    --cc=mwen@igalia.com \
    --cc=pgofman@codeweavers.com \
    --cc=pgriffais@valvesoftware.com \
    --cc=tglx@linutronix.de \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.