From: Guillaume Nault <gnault@redhat.com>
To: Wojciech Drewek <wojciech.drewek@intel.com>
Cc: netdev@vger.kernel.org, dsahern@gmail.com, stephen@networkplumber.org
Subject: Re: [PATCH iproute2-next v2 3/3] f_flower: Introduce L2TPv3 support
Date: Thu, 6 Oct 2022 14:21:01 +0200 [thread overview]
Message-ID: <20221006122101.GD3328@localhost.localdomain> (raw)
In-Reply-To: <20221005104432.369341-4-wojciech.drewek@intel.com>
On Wed, Oct 05, 2022 at 12:44:32PM +0200, Wojciech Drewek wrote:
> @@ -291,11 +293,16 @@ entry.
> .I TTL
> is an unsigned 8 bit value in decimal format.
> .TP
> +.BI l2tpv3_sid " LSID"
> +Match on L2TPv3 session id field transported over IP or IPv6.
I'd rather say either just 'over IP.' (any version), or
'over IPv4 or IPv6.' (both versions written explicitly).
> +static int flower_parse_l2tpv3(char *str, __be16 eth_type, __u8 ip_proto,
> + struct nlmsghdr *n)
> +{
> + __be32 sid;
> + int ret;
> +
> + if ((eth_type != htons(ETH_P_IP) && eth_type != htons(ETH_P_IPV6)) ||
Testing eth_type shouldn't be necessary here, since
flower_parse_ip_proto() should have already verified that eth_type is
compatible with IPPROTO_L2TP. So eth_type can even be dropped from
the function parameters. Also the error message probably doesn't need
to talk about the ethertype as flower_parse_ip_proto() should have
already complained.
Apart from that,
Reviewed-by: Guillaume Nault <gnault@redhat.com>
next prev parent reply other threads:[~2022-10-06 12:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-05 10:44 [PATCH iproute2-next v2 0/3] L2TPv3 support in tc-flower Wojciech Drewek
2022-10-05 10:44 ` [PATCH iproute2-next v2 1/3] uapi: move IPPROTO_L2TP to in.h Wojciech Drewek
2022-10-05 10:44 ` [PATCH iproute2-next v2 2/3] uapi: Add TCA_FLOWER_KEY_L2TPV3_SID Wojciech Drewek
2022-10-05 10:44 ` [PATCH iproute2-next v2 3/3] f_flower: Introduce L2TPv3 support Wojciech Drewek
2022-10-06 12:21 ` Guillaume Nault [this message]
2022-10-06 12:09 ` [PATCH iproute2-next v2 0/3] L2TPv3 support in tc-flower Guillaume Nault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221006122101.GD3328@localhost.localdomain \
--to=gnault@redhat.com \
--cc=dsahern@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=wojciech.drewek@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.