From: "Michael S. Tsirkin" <mst@redhat.com>
To: Alvaro Karsz <alvaro.karsz@solid-run.com>
Cc: Jens Axboe <axboe@kernel.dk>, Paolo Bonzini <pbonzini@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH v3] virtio_blk: add SECURE ERASE command support
Date: Fri, 7 Oct 2022 09:12:00 -0400 [thread overview]
Message-ID: <20221007091127-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <CAJs=3_AD_KLZHwo1gxejYRUJ6ucdCxv=3RnpOQXs+KiBEV=K5A@mail.gmail.com>
On Thu, Sep 29, 2022 at 11:51:22AM +0300, Alvaro Karsz wrote:
> > However, this means that even if host exposes VIRTIO_BLK_F_SECURE_ERASE
> > the host can not be sure guest will use secure erase.
> > Is this or can be a security problem?
> > If yes let's be strict and fail probe as current code does.
> > If not let's be flexible and ensure forward compatibility.
>
>
> I can't think of any security problems.
> Stefan, what do you think?
> Are you ok with clearing the feature?
I applied as is for now, using validate callback can be done on top.
--
MSR
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2022-10-07 13:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-21 8:27 [PATCH v3] virtio_blk: add SECURE ERASE command support Alvaro Karsz
2022-09-22 17:45 ` Stefan Hajnoczi
2022-09-28 10:48 ` Alvaro Karsz
2022-09-28 13:15 ` Michael S. Tsirkin
2022-09-29 7:13 ` Alvaro Karsz
2022-09-29 7:20 ` Michael S. Tsirkin
2022-09-29 7:29 ` Alvaro Karsz
2022-09-29 7:45 ` Michael S. Tsirkin
2022-09-29 8:51 ` Alvaro Karsz
2022-10-07 13:12 ` Michael S. Tsirkin [this message]
2022-10-08 4:48 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221007091127-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=alvaro.karsz@solid-run.com \
--cc=axboe@kernel.dk \
--cc=pbonzini@redhat.com \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.