From: Tom Rini <trini@konsulko.com>
To: "Pali Rohár" <pali@kernel.org>
Cc: "Stefan Roese" <sr@denx.de>,
"Mark Kettenis" <kettenis@openbsd.org>,
"Andre Przywara" <andre.przywara@arm.com>,
"Marek Behún" <kabel@kernel.org>,
u-boot@lists.denx.de
Subject: Re: [PATCH] armv8: cache_v8: Fix pgtables setup when MMU is already enabled
Date: Fri, 7 Oct 2022 11:47:50 -0400 [thread overview]
Message-ID: <20221007154750.GC3044094@bill-the-cat> (raw)
In-Reply-To: <20220914113746.16701-1-pali@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 849 bytes --]
On Wed, Sep 14, 2022 at 01:37:46PM +0200, Pali Rohár wrote:
> When MMU is already enabled then dcache_enable() does not call mmu_setup()
> and so setup_all_pgtables() is also never called.
>
> In this situation when some driver calls mmu_set_region_dcache_behaviour()
> function then U-Boot crashes with error message:
>
> Emergency page table not setup.
>
> Fix this issue by explicitly calling setup_all_pgtables() in dcache_enable()
> function near condition for mmu_setup().
>
> This change fixes chainloading U-Boot from U-Boot on Turris Mox board which
> uses mvneta ethernet driver which calls mmu_set_region_dcache_behaviour().
>
> Signed-off-by: Pali Rohár <pali@kernel.org>
> Reviewed-by: Marek Behún <kabel@kernel.org>
> Reviewed-by: Stefan Roese <sr@denx.de>
Applied to u-boot/master, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
prev parent reply other threads:[~2022-10-07 15:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-14 11:37 [PATCH] armv8: cache_v8: Fix pgtables setup when MMU is already enabled Pali Rohár
2022-09-16 16:02 ` Marek Behún
2022-09-19 7:01 ` Stefan Roese
2022-10-07 15:47 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221007154750.GC3044094@bill-the-cat \
--to=trini@konsulko.com \
--cc=andre.przywara@arm.com \
--cc=kabel@kernel.org \
--cc=kettenis@openbsd.org \
--cc=pali@kernel.org \
--cc=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.