From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 246ABC433F5 for ; Sun, 9 Oct 2022 12:45:15 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C88ED84C4C; Sun, 9 Oct 2022 14:45:12 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="OAoYtU17"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 5281784E8A; Sun, 9 Oct 2022 14:45:11 +0200 (CEST) Received: from mail-qv1-xf2a.google.com (mail-qv1-xf2a.google.com [IPv6:2607:f8b0:4864:20::f2a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 1676584C0A for ; Sun, 9 Oct 2022 14:45:07 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf2a.google.com with SMTP id f14so5808381qvo.3 for ; Sun, 09 Oct 2022 05:45:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=WabxJXDWUTWN27PI39dALpYq9HlZDJrehU7OCoNk1Yc=; b=OAoYtU17WQMyIsFOpc5+/kAHXYuzIJrBiFOE6g8jrokVx4QpN1A/dE4nZIzr6tGlq8 qISv9V3iw3NHCzZOYGtxGVne2SpUtetmnvNAGoxXLjCv2xN1tBGlzt9zo8CyHdqd5rPI WheSno43DiDHDTeI1xPI8ip3cHRaC2PlQ2Gz0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=WabxJXDWUTWN27PI39dALpYq9HlZDJrehU7OCoNk1Yc=; b=V2jhnw3YbABX4lRYqDRONjcKP0Z84SycWNzl2b4akVAFlKAi9CZzJiSmKTOpKW5VtU Ya51kxoBBfJnxBbOVuEMrzQJ+jGoxbvv9mhc+kvL0Mjbd0bkElrYsQAUrFZNqGWxQtuN sauusXG9a/N7wQW6Geb5BWRjdsH23b8iCxIoviwOIjwm4LQYx7gwaJoCEVOzS+M8hlLd YnyxTNOzcyw1+v8270TBJIO5HOrqCpmQil5eEUfCkwuKBFvykj5xB1d3FBqKAnU2pB5H FGyu9+GYmcsCAZPEjcXY9Sx4zeV/GL5AbawABPJ3meBf0YAuASUwYkyGXhEHJNdXO+P0 Cq7A== X-Gm-Message-State: ACrzQf1viHicD5OfIQcO6QEpMLf3cQbgSfgdXIHWy5lOoPtnFSUCFWU9 0C8+gS6qBiJ8+dqIYXCU8EslGS+mCjhf4w== X-Google-Smtp-Source: AMsMyM7SRdxKlugJdvisQGxsrgT/Obd8kGO0LH2KbUC+F65/hqOXxKPWN6xZnVNgEcu4DMmLy8yghg== X-Received: by 2002:a05:6214:4101:b0:4af:8cdc:20c4 with SMTP id kc1-20020a056214410100b004af8cdc20c4mr11477000qvb.6.1665319505834; Sun, 09 Oct 2022 05:45:05 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-ad04-3cb2-8863-094e.res6.spectrum.com. [2603:6081:7b00:6400:ad04:3cb2:8863:94e]) by smtp.gmail.com with ESMTPSA id c4-20020a05620a268400b006cbcdc6efedsm7463266qkp.41.2022.10.09.05.45.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 09 Oct 2022 05:45:05 -0700 (PDT) Date: Sun, 9 Oct 2022 08:45:03 -0400 From: Tom Rini To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Marek =?iso-8859-1?Q?Beh=FAn?= , u-boot@lists.denx.de Subject: Re: Broken commit de47ff536363289f92f85ed1e4901724d238432d Message-ID: <20221009124503.GR3044094@bill-the-cat> References: <20220805154400.GA1146598@bill-the-cat> <20220805155135.r5dctspg2oohzdev@pali> <20220805155453.GC1146598@bill-the-cat> <20220805201701.7t37kxn64qaiye3n@pali> <20220805222019.GE1146598@bill-the-cat> <20220808095149.2e0ed3ff@thinkpad> <20220808133722.GM1146598@bill-the-cat> <20220817092908.diwaapf636fxpmuq@pali> <20220826145358.GG7942@bill-the-cat> <20221009124119.xp3tr4zqey7vv4q6@pali> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="70+REwb9CwaFqOhy" Content-Disposition: inline In-Reply-To: <20221009124119.xp3tr4zqey7vv4q6@pali> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --70+REwb9CwaFqOhy Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Oct 09, 2022 at 02:41:19PM +0200, Pali Roh=E1r wrote: > On Friday 26 August 2022 10:53:58 Tom Rini wrote: > > On Wed, Aug 17, 2022 at 11:29:08AM +0200, Pali Roh=E1r wrote: > > > On Monday 08 August 2022 09:37:22 Tom Rini wrote: > > > > On Mon, Aug 08, 2022 at 09:51:49AM +0200, Marek Beh=FAn wrote: > > > > > On Fri, 5 Aug 2022 18:20:19 -0400 > > > > > Tom Rini wrote: > > > > >=20 > > > > > > On Fri, Aug 05, 2022 at 10:17:01PM +0200, Pali Roh=E1r wrote: > > > > > > > On Friday 05 August 2022 11:54:53 Tom Rini wrote: =20 > > > > > > > > On Fri, Aug 05, 2022 at 05:51:35PM +0200, Pali Roh=E1r wrot= e: =20 > > > > > > > > > On Friday 05 August 2022 11:44:00 Tom Rini wrote: =20 > > > > > > > > > > On Fri, Aug 05, 2022 at 05:12:59PM +0200, Pali Roh=E1r = wrote: =20 > > > > > > > > > > > On Friday 05 August 2022 11:03:40 Tom Rini wrote: =20 > > > > > > > > > > > > On Fri, Aug 05, 2022 at 04:59:35PM +0200, Pali Roh= =E1r wrote: =20 > > > > > > > > > > > > > On Friday 05 August 2022 10:47:31 Tom Rini wrote:= =20 > > > > > > > > > > > > > > On Fri, Aug 05, 2022 at 04:21:24PM +0200, Pali = Roh=E1r wrote: =20 > > > > > > > > > > > > > > > On Wednesday 03 August 2022 12:13:18 Tom Rini= wrote: =20 > > > > > > > > > > > > > > > > On Wed, Aug 03, 2022 at 06:00:13PM +0200, P= ali Roh=E1r wrote: =20 > > > > > > > > > > > > > > > > > On Tuesday 02 August 2022 06:58:26 Tom Ri= ni wrote: =20 > > > > > > > > > > > > > > > > > > On Tue, Aug 02, 2022 at 11:13:38AM +020= 0, Pali Roh=E1r wrote: > > > > > > > > > > > > > > > > > > =20 > > > > > > > > > > > > > > > > > > > Hello Tom! > > > > > > > > > > > > > > > > > > >=20 > > > > > > > > > > > > > > > > > > > Your commit de47ff536363289f92f85ed1e= 4901724d238432d ("Convert > > > > > > > > > > > > > > > > > > > CONFIG_SYS_MPC85XX_NO_RESETVEC to Kco= nfig") seems to be broken. =20 > > > > > > > > > > > > > > > > > >=20 > > > > > > > > > > > > > > > > > > I thought I had managed to mirror the T= PL/SPL/full usage that was there > > > > > > > > > > > > > > > > > > prior, but apparently some got missed. = =20 > > > > > > > > > > > > > > > > >=20 > > > > > > > > > > > > > > > > > Yea, conversion to Kconfig seems that was= incorrect. =20 > > > > > > > > > > > > > > > >=20 > > > > > > > > > > > > > > > > As the config files were just unclear, but = you seem to understand what > > > > > > > > > > > > > > > > it's supposed to be, a patch to clean it up= would be most appreciated, > > > > > > > > > > > > > > > > thanks. > > > > > > > > > > > > > > > >=20 > > > > > > > > > > > > > > > > --=20 > > > > > > > > > > > > > > > > Tom =20 > > > > > > > > > > > > > > >=20 > > > > > > > > > > > > > > > Broken is also commit d433c74eecdce1e4952ef4e= 8c712a9289c0dfcc2. Seems > > > > > > > > > > > > > > > that all kconfig migration changes done after= that commit are broken. > > > > > > > > > > > > > > >=20 > > > > > > > > > > > > > > > I really do not have energy to investigate wh= at and how was broken due > > > > > > > > > > > > > > > to incorrect kconfig migration. > > > > > > > > > > > > > > >=20 > > > > > > > > > > > > > > >=20 > > > > > > > > > > > > > > > I did simple test. Applied following change: > > > > > > > > > > > > > > >=20 > > > > > > > > > > > > > > > diff --git a/include/configs/p1_p2_rdb_pc.h b= /include/configs/p1_p2_rdb_pc.h > > > > > > > > > > > > > > > index a6523753d5ca..489f24df0ab1 100644 > > > > > > > > > > > > > > > --- a/include/configs/p1_p2_rdb_pc.h > > > > > > > > > > > > > > > +++ b/include/configs/p1_p2_rdb_pc.h > > > > > > > > > > > > > > > @@ -624,3 +624,7 @@ __stringify(__PCIE_RST_CM= D)"\0" > > > > > > > > > > > > > > > "bootm $norbootaddr - $norfdtaddr" > > > > > > > > > > > > > > > =20 > > > > > > > > > > > > > > > #endif /* __CONFIG_H */ > > > > > > > > > > > > > > > + > > > > > > > > > > > > > > > +#ifdef CONFIG_SDCARD > > > > > > > > > > > > > > > +#error > > > > > > > > > > > > > > > +#endif > > > > > > > > > > > > > > >=20 > > > > > > > > > > > > > > > And then called: > > > > > > > > > > > > > > >=20 > > > > > > > > > > > > > > > make CROSS_COMPILE=3Dpowerpc-linux-gnuspe- P2= 020RDB-PC_defconfig u-boot.bin > > > > > > > > > > > > > > >=20 > > > > > > > > > > > > > > > And it failed, even when this defconfig file = is not SD card builds. =20 > > > > > > > > > > > > > >=20 > > > > > > > > > > > > > > Where is PBL in that case even then? =20 > > > > > > > > > > > > >=20 > > > > > > > > > > > > > P2020 (and older) are pre-PBL boards, they do not= support NXP PBL > > > > > > > > > > > > > header. =20 > > > > > > > > > > > >=20 > > > > > > > > > > > > Ah, OK, then it should just be removing TARGET_P202= 0RDB from the choice > > > > > > > > > > > > on "Freescale PBL load location". > > > > > > > > > > > >=20 > > > > > > > > > > > > --=20 > > > > > > > > > > > > Tom =20 > > > > > > > > > > >=20 > > > > > > > > > > > I just do not understand. > > > > > > > > > > >=20 > > > > > > > > > > > P10** and P20** do not support NXP PBL. They support = only pre-PBL and > > > > > > > > > > > for SD card pre-PBL support I added option FSL_PREPBL= _ESDHC_BOOT_SECTOR. > > > > > > > > > > >=20 > > > > > > > > > > > But CONFIG_SDCARD is automatically set when SYS_EXTRA= _OPTIONS contains > > > > > > > > > > > "SDCARD" string and CONFIG_SDCARD is used then also i= n P10** and P20** > > > > > > > > > > > SD-card version of SPL to load proper U-Boot. =20 > > > > > > > > > >=20 > > > > > > > > > > So CONFIG_SDCARD was over-loaded? That's very frustrati= ng. That's what > > > > > > > > > > needs to be corrected then. =20 > > > > > > > > >=20 > > > > > > > > > But it was correct, no? CONFIG_SDCARD ensures that U-Boot= is compiled in > > > > > > > > > mode in which can be booted from SD card. Or what do you = have in mind as > > > > > > > > > purpose of this symbol? > > > > > > > > >=20 > > > > > > > > > The issue is that your Kconfig migration changes enabled = CONFIG_SDCARD > > > > > > > > > also when building (parallel) NOR version of U-Boot. =20 > > > > > > > >=20 > > > > > > > > To me, the biggest issue is that "CONFIG_SDCARD" exists. It= 's very much > > > > > > > > non-descriptive and that for some platforms it means "we ha= ve NXP PBL" > > > > > > > > and others means "we're booting from SDCARD". The former sh= ould be > > > > > > > > renamed to be descriptive, and the latter should re-use CON= FIG_SD_CARD > > > > > > > > which is still a bad name, but what everyone else uses, so = makes > > > > > > > > renaming it later to something less bad easier. =20 > > > > > > >=20 > > > > > > > So I hope that you will do something with it. I already spent= lot of > > > > > > > time to fix and improve powerpc support, but the result is th= at my > > > > > > > patches are on the list, mostly ignored; but changes which ar= e breaking > > > > > > > powerpc support are happily merging. In this state I'm loosin= g any > > > > > > > motivation to continue development as it is needed to do agai= n to find > > > > > > > out what new is broken. =20 > > > > > >=20 > > > > > > I'm not planning to try and further fiddle with those symbols. A > > > > > > simple revert is not possible as CONFIG_SYS_EXTRA_OPTIONS is go= ne. I > > > > > > assume that Marek will be picking up your PowerPC patches at th= is point, > > > > > > so any further work you're doing in that area shouldn't be dela= yed. > > > > > > I'll put re-examining this on my TODO list, but it's below fini= shing my > > > > > > CONFIG_SYS_* audit, and then renaming stuff to CFG_SYS. > > > > > >=20 > > > > > > You should fix whatever platforms you have access to and ignore= the > > > > > > rest, I feel likely to be removing most of them shortly at this= point. > > > > > >=20 > > > > >=20 > > > > > I shall try to fix this on our platform by "reverting" these to > > > > > different names, so that there are no new CONFIG_ macros. > > > >=20 > > > > OK, thanks. I'll "fix" the corenet_ds platforms with a removal patch > > > > soon, since they've been orphaned for a long while. > > >=20 > > > Any progress on fixing this issue? Currently all this stuff is not > > > working in u-boot master due to broken kconfig migration. And any > > > continuation in kconfig migration just makes it worse and harder to f= ix > > > later. > >=20 > > I've removed the corenet_ds platforms now. >=20 > I'm reminding this issue again. u-boot master branch is still broken. I don't really remember what the fix was at this point, but you should fix whatever boards you have and care about as it's a matter of selecting the correct option, yes? --=20 Tom --70+REwb9CwaFqOhy Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmNCwksACgkQFHw5/5Y0 tyx4HQv9EKbzRBDMVkcARtblA1rF78cOXwIUtLUYCbuLvz7Z/+9n7XBGNL2UKCa6 KN1JMn9etHKs0swbHmjF3MaRJ8s+wIUoUXAjlI9lpxoVunnTho9JNzbI9Q1l3e5d MOqNX0FfdNO+7zS1xLD28OyT0cKSjd+5XyRhB9Uaiq8+WinYKHM0Xt2R+YbOcIoy O0r0VZgzA1d1+xuCszVHtcS+19IKNmvKRkC3MTe83klfDvZiz5VSYojIy3H/Wt2O nYrv1EAAtllQgHryiAnWQ8UMFlloE4kpA4JfPx0tS7bPz0YtB8nyd0irsb11phtq ED81BCI6vv0k4erpdK6cPXjBi4cWowb6VZ40SD9BdavI1nSEXr8g431oPkraplwI 2GQeT3Nn6zLuUkx5reXGPPTlDWzg7Hex7A6HR2bnTNehQQqFJXX8KNlIgE9vlmnm cRGBPCa/nInxoRPrK43mu1UUmJQa2CzhsTIJpM2B09ASJ7DiiIkNA0TNFpJpM/sI mGCqWg54 =pts7 -----END PGP SIGNATURE----- --70+REwb9CwaFqOhy--