From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 99722C433F5 for ; Sun, 9 Oct 2022 16:32:14 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9831D84ED0; Sun, 9 Oct 2022 18:32:11 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="qAsvqCGh"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 9A14884EBB; Sun, 9 Oct 2022 18:32:10 +0200 (CEST) Received: from mail-qv1-xf2d.google.com (mail-qv1-xf2d.google.com [IPv6:2607:f8b0:4864:20::f2d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 1438484EBB for ; Sun, 9 Oct 2022 18:32:06 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf2d.google.com with SMTP id mx8so5981602qvb.8 for ; Sun, 09 Oct 2022 09:32:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=69oLcMo8KsomMpzpmmtsaj75tih9X2CSDhSNhi3xsJo=; b=qAsvqCGhnSvAY3f8/rgRF7E0GMr8IXa+o4qdTJxDjea1dlX0jOGHZaXvMl5USGQ/qR uYkoyZvCt9CsuyhiKhw7lt8KsnEPgHHuC1aHNLgeKgqGOjetoow5ajR8kWw7I7ttPC4Q 4fbHLZbZ6fmExv1XGin/xr8hmRtE00VD+UB/s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=69oLcMo8KsomMpzpmmtsaj75tih9X2CSDhSNhi3xsJo=; b=Ek9f19R53ZjMTPhxIwFM9U1fujbXkLkvs3LXqkf/H+ruj0pF1uvrw4aaqV3WJn9ibE 1L3QEfXjOHjTD6XH/Opvqrg6du1AD6AMDcO1YEjv7Nsn4e7BwXFtDr+kw/TbJG28kOAw bTCv5iCPJ3HMhUEMRVOVonYxBURr6Sj1nO/M3dJl+LbgFfCOXQkJOmR0urot/C5O6jTd uB80YYGMoYtnyLpsdFBuojH+3oxva9TPoQDTRslxo/GSgQuiPF+NPubtiGG8vowfAi2W ya7Sh6sASUeXX2ybt2DU3iDOUm+B4Feyxm4rrgor1sVyK+XoYqYAPAMd25VeHhbvFOMI aEQw== X-Gm-Message-State: ACrzQf0YjgiFgBMqZVv1FRR9YoEV8Kl1iL5/v8DaAHlOS+3Cqx6twiWa WUVq/rJp/4NRKszzk9mI9kP69g== X-Google-Smtp-Source: AMsMyM7qsTcmb9aibBSwG8gE0O0sb78fBqaFiCY/EeBdf2bbQ33m12WyaCFojMwU6SAnSzlLlcsonQ== X-Received: by 2002:a05:6214:2628:b0:4b1:9bad:6e9a with SMTP id gv8-20020a056214262800b004b19bad6e9amr11928368qvb.98.1665333124807; Sun, 09 Oct 2022 09:32:04 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-ad04-3cb2-8863-094e.res6.spectrum.com. [2603:6081:7b00:6400:ad04:3cb2:8863:94e]) by smtp.gmail.com with ESMTPSA id z2-20020ac86b82000000b00398946670f3sm2916274qts.1.2022.10.09.09.32.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 09 Oct 2022 09:32:04 -0700 (PDT) Date: Sun, 9 Oct 2022 12:32:02 -0400 From: Tom Rini To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Marek =?iso-8859-1?Q?Beh=FAn?= , u-boot@lists.denx.de Subject: Re: Broken commit de47ff536363289f92f85ed1e4901724d238432d Message-ID: <20221009163202.GS3044094@bill-the-cat> References: <20220805155453.GC1146598@bill-the-cat> <20220805201701.7t37kxn64qaiye3n@pali> <20220805222019.GE1146598@bill-the-cat> <20220808095149.2e0ed3ff@thinkpad> <20220808133722.GM1146598@bill-the-cat> <20220817092908.diwaapf636fxpmuq@pali> <20220826145358.GG7942@bill-the-cat> <20221009124119.xp3tr4zqey7vv4q6@pali> <20221009124503.GR3044094@bill-the-cat> <20221009131045.22majcsxppyhgimk@pali> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="O6Fik7hXuUMtLB5k" Content-Disposition: inline In-Reply-To: <20221009131045.22majcsxppyhgimk@pali> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --O6Fik7hXuUMtLB5k Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Oct 09, 2022 at 03:10:45PM +0200, Pali Roh=E1r wrote: > On Sunday 09 October 2022 08:45:03 Tom Rini wrote: > > On Sun, Oct 09, 2022 at 02:41:19PM +0200, Pali Roh=E1r wrote: > > > On Friday 26 August 2022 10:53:58 Tom Rini wrote: > > > > On Wed, Aug 17, 2022 at 11:29:08AM +0200, Pali Roh=E1r wrote: > > > > > On Monday 08 August 2022 09:37:22 Tom Rini wrote: > > > > > > On Mon, Aug 08, 2022 at 09:51:49AM +0200, Marek Beh=FAn wrote: > > > > > > > On Fri, 5 Aug 2022 18:20:19 -0400 > > > > > > > Tom Rini wrote: > > > > > > >=20 > > > > > > > > On Fri, Aug 05, 2022 at 10:17:01PM +0200, Pali Roh=E1r wrot= e: > > > > > > > > > On Friday 05 August 2022 11:54:53 Tom Rini wrote: =20 > > > > > > > > > > On Fri, Aug 05, 2022 at 05:51:35PM +0200, Pali Roh=E1r = wrote: =20 > > > > > > > > > > > On Friday 05 August 2022 11:44:00 Tom Rini wrote: =20 > > > > > > > > > > > > On Fri, Aug 05, 2022 at 05:12:59PM +0200, Pali Roh= =E1r wrote: =20 > > > > > > > > > > > > > On Friday 05 August 2022 11:03:40 Tom Rini wrote:= =20 > > > > > > > > > > > > > > On Fri, Aug 05, 2022 at 04:59:35PM +0200, Pali = Roh=E1r wrote: =20 > > > > > > > > > > > > > > > On Friday 05 August 2022 10:47:31 Tom Rini wr= ote: =20 > > > > > > > > > > > > > > > > On Fri, Aug 05, 2022 at 04:21:24PM +0200, P= ali Roh=E1r wrote: =20 > > > > > > > > > > > > > > > > > On Wednesday 03 August 2022 12:13:18 Tom = Rini wrote: =20 > > > > > > > > > > > > > > > > > > On Wed, Aug 03, 2022 at 06:00:13PM +020= 0, Pali Roh=E1r wrote: =20 > > > > > > > > > > > > > > > > > > > On Tuesday 02 August 2022 06:58:26 To= m Rini wrote: =20 > > > > > > > > > > > > > > > > > > > > On Tue, Aug 02, 2022 at 11:13:38AM = +0200, Pali Roh=E1r wrote: > > > > > > > > > > > > > > > > > > > > =20 > > > > > > > > > > > > > > > > > > > > > Hello Tom! > > > > > > > > > > > > > > > > > > > > >=20 > > > > > > > > > > > > > > > > > > > > > Your commit de47ff536363289f92f85= ed1e4901724d238432d ("Convert > > > > > > > > > > > > > > > > > > > > > CONFIG_SYS_MPC85XX_NO_RESETVEC to= Kconfig") seems to be broken. =20 > > > > > > > > > > > > > > > > > > > >=20 > > > > > > > > > > > > > > > > > > > > I thought I had managed to mirror t= he TPL/SPL/full usage that was there > > > > > > > > > > > > > > > > > > > > prior, but apparently some got miss= ed. =20 > > > > > > > > > > > > > > > > > > >=20 > > > > > > > > > > > > > > > > > > > Yea, conversion to Kconfig seems that= was incorrect. =20 > > > > > > > > > > > > > > > > > >=20 > > > > > > > > > > > > > > > > > > As the config files were just unclear, = but you seem to understand what > > > > > > > > > > > > > > > > > > it's supposed to be, a patch to clean i= t up would be most appreciated, > > > > > > > > > > > > > > > > > > thanks. > > > > > > > > > > > > > > > > > >=20 > > > > > > > > > > > > > > > > > > --=20 > > > > > > > > > > > > > > > > > > Tom =20 > > > > > > > > > > > > > > > > >=20 > > > > > > > > > > > > > > > > > Broken is also commit d433c74eecdce1e4952= ef4e8c712a9289c0dfcc2. Seems > > > > > > > > > > > > > > > > > that all kconfig migration changes done a= fter that commit are broken. > > > > > > > > > > > > > > > > >=20 > > > > > > > > > > > > > > > > > I really do not have energy to investigat= e what and how was broken due > > > > > > > > > > > > > > > > > to incorrect kconfig migration. > > > > > > > > > > > > > > > > >=20 > > > > > > > > > > > > > > > > >=20 > > > > > > > > > > > > > > > > > I did simple test. Applied following chan= ge: > > > > > > > > > > > > > > > > >=20 > > > > > > > > > > > > > > > > > diff --git a/include/configs/p1_p2_rdb_pc= =2Eh b/include/configs/p1_p2_rdb_pc.h > > > > > > > > > > > > > > > > > index a6523753d5ca..489f24df0ab1 100644 > > > > > > > > > > > > > > > > > --- a/include/configs/p1_p2_rdb_pc.h > > > > > > > > > > > > > > > > > +++ b/include/configs/p1_p2_rdb_pc.h > > > > > > > > > > > > > > > > > @@ -624,3 +624,7 @@ __stringify(__PCIE_RS= T_CMD)"\0" > > > > > > > > > > > > > > > > > "bootm $norbootaddr - $norfdtaddr" > > > > > > > > > > > > > > > > > =20 > > > > > > > > > > > > > > > > > #endif /* __CONFIG_H */ > > > > > > > > > > > > > > > > > + > > > > > > > > > > > > > > > > > +#ifdef CONFIG_SDCARD > > > > > > > > > > > > > > > > > +#error > > > > > > > > > > > > > > > > > +#endif > > > > > > > > > > > > > > > > >=20 > > > > > > > > > > > > > > > > > And then called: > > > > > > > > > > > > > > > > >=20 > > > > > > > > > > > > > > > > > make CROSS_COMPILE=3Dpowerpc-linux-gnuspe= - P2020RDB-PC_defconfig u-boot.bin > > > > > > > > > > > > > > > > >=20 > > > > > > > > > > > > > > > > > And it failed, even when this defconfig f= ile is not SD card builds. =20 > > > > > > > > > > > > > > > >=20 > > > > > > > > > > > > > > > > Where is PBL in that case even then? =20 > > > > > > > > > > > > > > >=20 > > > > > > > > > > > > > > > P2020 (and older) are pre-PBL boards, they do= not support NXP PBL > > > > > > > > > > > > > > > header. =20 > > > > > > > > > > > > > >=20 > > > > > > > > > > > > > > Ah, OK, then it should just be removing TARGET_= P2020RDB from the choice > > > > > > > > > > > > > > on "Freescale PBL load location". > > > > > > > > > > > > > >=20 > > > > > > > > > > > > > > --=20 > > > > > > > > > > > > > > Tom =20 > > > > > > > > > > > > >=20 > > > > > > > > > > > > > I just do not understand. > > > > > > > > > > > > >=20 > > > > > > > > > > > > > P10** and P20** do not support NXP PBL. They supp= ort only pre-PBL and > > > > > > > > > > > > > for SD card pre-PBL support I added option FSL_PR= EPBL_ESDHC_BOOT_SECTOR. > > > > > > > > > > > > >=20 > > > > > > > > > > > > > But CONFIG_SDCARD is automatically set when SYS_E= XTRA_OPTIONS contains > > > > > > > > > > > > > "SDCARD" string and CONFIG_SDCARD is used then al= so in P10** and P20** > > > > > > > > > > > > > SD-card version of SPL to load proper U-Boot. =20 > > > > > > > > > > > >=20 > > > > > > > > > > > > So CONFIG_SDCARD was over-loaded? That's very frust= rating. That's what > > > > > > > > > > > > needs to be corrected then. =20 > > > > > > > > > > >=20 > > > > > > > > > > > But it was correct, no? CONFIG_SDCARD ensures that U-= Boot is compiled in > > > > > > > > > > > mode in which can be booted from SD card. Or what do = you have in mind as > > > > > > > > > > > purpose of this symbol? > > > > > > > > > > >=20 > > > > > > > > > > > The issue is that your Kconfig migration changes enab= led CONFIG_SDCARD > > > > > > > > > > > also when building (parallel) NOR version of U-Boot. = =20 > > > > > > > > > >=20 > > > > > > > > > > To me, the biggest issue is that "CONFIG_SDCARD" exists= =2E It's very much > > > > > > > > > > non-descriptive and that for some platforms it means "w= e have NXP PBL" > > > > > > > > > > and others means "we're booting from SDCARD". The forme= r should be > > > > > > > > > > renamed to be descriptive, and the latter should re-use= CONFIG_SD_CARD > > > > > > > > > > which is still a bad name, but what everyone else uses,= so makes > > > > > > > > > > renaming it later to something less bad easier. =20 > > > > > > > > >=20 > > > > > > > > > So I hope that you will do something with it. I already s= pent lot of > > > > > > > > > time to fix and improve powerpc support, but the result i= s that my > > > > > > > > > patches are on the list, mostly ignored; but changes whic= h are breaking > > > > > > > > > powerpc support are happily merging. In this state I'm lo= osing any > > > > > > > > > motivation to continue development as it is needed to do = again to find > > > > > > > > > out what new is broken. =20 > > > > > > > >=20 > > > > > > > > I'm not planning to try and further fiddle with those symbo= ls. A > > > > > > > > simple revert is not possible as CONFIG_SYS_EXTRA_OPTIONS i= s gone. I > > > > > > > > assume that Marek will be picking up your PowerPC patches a= t this point, > > > > > > > > so any further work you're doing in that area shouldn't be = delayed. > > > > > > > > I'll put re-examining this on my TODO list, but it's below = finishing my > > > > > > > > CONFIG_SYS_* audit, and then renaming stuff to CFG_SYS. > > > > > > > >=20 > > > > > > > > You should fix whatever platforms you have access to and ig= nore the > > > > > > > > rest, I feel likely to be removing most of them shortly at = this point. > > > > > > > >=20 > > > > > > >=20 > > > > > > > I shall try to fix this on our platform by "reverting" these = to > > > > > > > different names, so that there are no new CONFIG_ macros. > > > > > >=20 > > > > > > OK, thanks. I'll "fix" the corenet_ds platforms with a removal = patch > > > > > > soon, since they've been orphaned for a long while. > > > > >=20 > > > > > Any progress on fixing this issue? Currently all this stuff is not > > > > > working in u-boot master due to broken kconfig migration. And any > > > > > continuation in kconfig migration just makes it worse and harder = to fix > > > > > later. > > > >=20 > > > > I've removed the corenet_ds platforms now. > > >=20 > > > I'm reminding this issue again. u-boot master branch is still broken. > >=20 > > I don't really remember what the fix was at this point, but you should > > fix whatever boards you have and care about as it's a matter of > > selecting the correct option, yes? >=20 > See: https://lore.kernel.org/u-boot/20220805142124.6swsha6aj62f33e3@pali/ > Broken is Kconfig migration which you done. I wrote in that email simple > test case how to check if it is OK or not. Yes, but I'm not un-migrating the symbol. As I think you're the only person who cares about mpc85xx platforms right now, is your platform working, or is there something that needs to be changed so that it does work? --=20 Tom --O6Fik7hXuUMtLB5k Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmNC934ACgkQFHw5/5Y0 tyx0vQv+OFrRnKo6HUNExgIN1JAqfXfSvLXcotjawkbkXeOx/7vQqekBq185vCoc OPMJFDG6K2H4TrZ5R8D1w3WCIDGhj4Y+hn7aPM0Np/JsjmbH1kvNbihDWthBPGTC 5OqtUg+3JSVRrQFBK8BfRWg3SGXgel72XQwOO0ovGnaYRsD18TbQoFAQueE9seUT W/4VtDLpHq9dP8CKt71cLvFc2DL4t2rZ7NWPBpxg7dPsUVhXRdExpx7DvvYNvb5L +huWmdjSJsx1t0kmZbkpleRJsvOq+6Gek9bs9Q45McKkWQO5Udzbx68zjCj4a3wf 7lrgARolV3M5QxVisPfkcrCV2p0MX3vydMQuUSTckTv6Q+Mk9H4n2//g9j2NzGJ9 9vy/4FGFkgQuzceZ4rO4HTdHXVwRdvgG34Qkwv9ebvtcR/cY5hh0Wv83AHba72zs Ph81/NUnXeL6zfIdaVuh3M8OHWkj43qAe/YBjsmIAs+0AsSuBwzdS+8EdY4OPdXp PMjUKwB3 =Byn+ -----END PGP SIGNATURE----- --O6Fik7hXuUMtLB5k--