From: Christoph Hellwig <hch@lst.de>
To: Ming Lei <ming.lei@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>,
linux-nvme@lists.infradead.org, Yi Zhang <yi.zhang@redhat.com>,
Sagi Grimberg <sagi@grimberg.me>, Chao Leng <lengchao@huawei.com>,
Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCH V2] nvme: don't wait freeze during resetting
Date: Mon, 10 Oct 2022 10:25:33 +0200 [thread overview]
Message-ID: <20221010082533.GA24101@lst.de> (raw)
In-Reply-To: <20220926013404.2217794-1-ming.lei@redhat.com>
On Mon, Sep 26, 2022 at 09:34:04AM +0800, Ming Lei wrote:
> First it isn't necessary to call nvme_wait_freeze during reset.
> For nvme-pci, if tagset isn't allocated, there can't be any inflight
> IOs; otherwise blk_mq_update_nr_hw_queues can freeze & wait queues.
>
> Second, since commit bdd6316094e0 ("block: Allow unfreezing of a queue
> while requests are in progress"), it is fine to unfreeze queue without
> draining inflight IOs.
>
> Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
> Reviewed-by: Chao Leng <lengchao@huawei.com>
> Reviewed-by: Keith Busch <kbusch@kernel.org>
> Signed-off-by: Ming Lei <ming.lei@redhat.com>
> ---
> V2:
> - remove the change in rdma/tcp which may make non-mpath reset
> time much longer, as pointed by Sagi
So how can this be corret for PCI and apple but not for rdma and TCP?
Also please don't update two drivers in a single patch.
next prev parent reply other threads:[~2022-10-10 8:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-26 1:34 [PATCH V2] nvme: don't wait freeze during resetting Ming Lei
2022-10-10 8:25 ` Christoph Hellwig [this message]
2022-10-18 6:29 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221010082533.GA24101@lst.de \
--to=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=lengchao@huawei.com \
--cc=linux-nvme@lists.infradead.org \
--cc=ming.lei@redhat.com \
--cc=sagi@grimberg.me \
--cc=yi.zhang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.