All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Roesch <shr@devkernel.io>
To: kernel-team@fb.com, linux-block@vger.kernel.org, linux-mm@kvack.org
Cc: shr@devkernel.io, axboe@kernel.dk, clm@meta.com
Subject: [RFC PATCH v1 07/14] mm: add bdi_set_max_bytes() function.
Date: Mon, 10 Oct 2022 18:00:37 -0700	[thread overview]
Message-ID: <20221011010044.851537-8-shr@devkernel.io> (raw)
In-Reply-To: <20221011010044.851537-1-shr@devkernel.io>

This introduces the bdi_set_max_bytes() function. The max_bytes function
does not store the max_bytes value. Instead it converts the max_bytes
value into the corresponding ratio value.

Signed-off-by: Stefan Roesch <shr@devkernel.io>
---
 include/linux/backing-dev.h |  1 +
 mm/page-writeback.c         | 37 +++++++++++++++++++++++++++++++++++++
 2 files changed, 38 insertions(+)

diff --git a/include/linux/backing-dev.h b/include/linux/backing-dev.h
index 94fedf66c915..a10598f90d4d 100644
--- a/include/linux/backing-dev.h
+++ b/include/linux/backing-dev.h
@@ -108,6 +108,7 @@ static inline unsigned long wb_stat_error(void)
 unsigned long long bdi_get_max_bytes(struct backing_dev_info *bdi);
 int bdi_set_min_ratio(struct backing_dev_info *bdi, unsigned int min_ratio);
 int bdi_set_max_ratio(struct backing_dev_info *bdi, unsigned int max_ratio);
+int bdi_set_max_bytes(struct backing_dev_info *bdi, unsigned long long max_bytes);
 int bdi_set_strict_limit(struct backing_dev_info *bdi, unsigned int strict_limit);
 
 /*
diff --git a/mm/page-writeback.c b/mm/page-writeback.c
index 8b8936603783..a6594ebdcbd8 100644
--- a/mm/page-writeback.c
+++ b/mm/page-writeback.c
@@ -650,6 +650,28 @@ void wb_domain_exit(struct wb_domain *dom)
  */
 static unsigned int bdi_min_ratio;
 
+static int bdi_check_pages_limit(unsigned long pages)
+{
+	unsigned long max_dirty_pages = global_dirtyable_memory();
+
+	if (pages > max_dirty_pages / 2)
+		return -EINVAL;
+
+	return 0;
+}
+
+static unsigned long bdi_ratio_from_pages(unsigned long long pages)
+{
+	unsigned long background_thresh;
+	unsigned long dirty_thresh;
+	unsigned long ratio;
+
+	global_dirty_limits(&background_thresh, &dirty_thresh);
+	ratio = (pages * 100 * BDI_RATIO_SCALE) / dirty_thresh;
+
+	return ratio;
+}
+
 static unsigned long long bdi_get_bytes(unsigned int ratio)
 {
 	unsigned long background_thresh;
@@ -723,6 +745,21 @@ unsigned long long bdi_get_max_bytes(struct backing_dev_info *bdi)
 }
 EXPORT_SYMBOL_GPL(bdi_get_max_bytes);
 
+int bdi_set_max_bytes(struct backing_dev_info *bdi, unsigned long long max_bytes)
+{
+	int ret;
+	unsigned long pages = max_bytes >> PAGE_SHIFT;
+	unsigned long max_ratio;
+
+	ret = bdi_check_pages_limit(pages);
+	if (ret)
+		return ret;
+
+	max_ratio = bdi_ratio_from_pages(pages);
+	return __bdi_set_max_ratio(bdi, max_ratio);
+}
+EXPORT_SYMBOL_GPL(bdi_set_max_bytes);
+
 int bdi_set_strict_limit(struct backing_dev_info *bdi, unsigned int strict_limit)
 {
 	if (strict_limit > 1)
-- 
2.30.2


  parent reply	other threads:[~2022-10-11  1:24 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-11  1:00 [RFC PATCH v1 00/14] mm/block: add bdi sysfs knobs Stefan Roesch
2022-10-11  1:00 ` [RFC PATCH v1 01/14] mm: add bdi_set_strict_limit() function Stefan Roesch
2022-10-11  1:00 ` [RFC PATCH v1 02/14] mm: Add new knob /sys/class/bdi/<bdi>/strict_limit Stefan Roesch
2022-10-11  1:00 ` [RFC PATCH v1 03/14] mm: document new /sys/class/bdi/<bdi>/strict_limit knob Stefan Roesch
2022-10-11  1:00 ` [RFC PATCH v1 04/14] mm: Use part per 10000 for bdi ratios Stefan Roesch
2022-10-11  1:00 ` [RFC PATCH v1 05/14] mm: add bdi_get_max_bytes() function Stefan Roesch
2022-10-11  1:00 ` [RFC PATCH v1 06/14] mm: split off __bdi_set_max_ratio() function Stefan Roesch
2022-10-11  1:00 ` Stefan Roesch [this message]
2022-10-11  1:00 ` [RFC PATCH v1 08/14] mm: Add new knob /sys/class/bdi/<bdi>/max_bytes Stefan Roesch
2022-10-11  1:00 ` [RFC PATCH v1 09/14] mm: document new /sys/class/bdi/<bdi>/max_bytes knob Stefan Roesch
2022-10-11  1:00 ` [RFC PATCH v1 10/14] mm: add bdi_get_min_bytes() function Stefan Roesch
2022-10-11  1:00 ` [RFC PATCH v1 11/14] mm: split off __bdi_set_min_ratio() function Stefan Roesch
2022-10-11  1:00 ` [RFC PATCH v1 12/14] mm: add bdi_set_min_bytes() function Stefan Roesch
2022-10-11  1:00 ` [RFC PATCH v1 13/14] mm: add new /sys/class/bdi/<bdi>/min_bytes knob Stefan Roesch
2022-10-11  1:00 ` [RFC PATCH v1 14/14] mm: document " Stefan Roesch
2022-10-11 18:20 ` [RFC PATCH v1 00/14] mm/block: add bdi sysfs knobs Matthew Wilcox
2022-10-13 20:11   ` Stefan Roesch
2022-10-17  7:45 ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221011010044.851537-8-shr@devkernel.io \
    --to=shr@devkernel.io \
    --cc=axboe@kernel.dk \
    --cc=clm@meta.com \
    --cc=kernel-team@fb.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.