From: Peilin Ye <yepeilin.cs@gmail.com>
To: Leon Romanovsky <leon@kernel.org>
Cc: Eric Dumazet <edumazet@google.com>,
"David S. Miller" <davem@davemloft.net>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
David Ahern <dsahern@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Peilin Ye <peilin.ye@bytedance.com>,
Cong Wang <cong.wang@bytedance.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v3] net/sock: Introduce trace_sk_data_ready()
Date: Wed, 12 Oct 2022 10:57:17 -0700 [thread overview]
Message-ID: <20221012175717.GA26425@bytedance> (raw)
In-Reply-To: <Y0ZXiDiqxYb7yYmS@unreal>
On Wed, Oct 12, 2022 at 08:58:32AM +0300, Leon Romanovsky wrote:
> > + trace_sk_data_ready(sk, __func__);
> > pr_debug("Entering iscsi_target_sk_data_ready: conn: %p\n", conn);
>
> This can go.
<...>
> __func__ repetitive pattern hints that it is not best API interface.
>
>
> > +TRACE_EVENT(sk_data_ready,
> > +
> > + TP_PROTO(const struct sock *sk, const char *func),
> > +
> > + TP_ARGS(sk, func),
> > +
> > + TP_STRUCT__entry(
> > + __field(const void *, skaddr)
> > + __field(__u16, family)
> > + __field(__u16, protocol)
> > + __string(func, func)
>
> TRACE_EVENT() is macro defined in .h file, you can safely put __func__
> instead.
Thanks for the suggestions! I will update in v4.
Peilin Ye
next prev parent reply other threads:[~2022-10-12 17:57 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-28 22:15 [PATCH net-next] net/sock: Introduce trace_sk_data_ready() Peilin Ye
2022-09-29 16:18 ` Jakub Kicinski
2022-10-05 0:06 ` Peilin Ye
2022-09-29 16:19 ` Eric Dumazet
2022-10-05 0:14 ` Peilin Ye
2022-10-07 22:10 ` [PATCH net-next v2] " Peilin Ye
2022-10-08 0:38 ` kernel test robot
2022-10-08 1:11 ` Peilin Ye
2022-10-08 1:11 ` Peilin Ye
2022-10-08 0:48 ` kernel test robot
2022-10-11 19:58 ` [PATCH net-next v3] " Peilin Ye
2022-10-12 5:58 ` Leon Romanovsky
2022-10-12 17:57 ` Peilin Ye [this message]
2022-10-12 23:21 ` [PATCH net-next v4] " Peilin Ye
2022-10-13 9:43 ` Leon Romanovsky
2022-10-13 23:58 ` Peilin Ye
2022-10-14 0:00 ` [PATCH net-next v5] " Peilin Ye
2022-10-14 6:35 ` Leon Romanovsky
2022-11-10 2:28 ` Peilin Ye
2022-10-15 20:07 ` [PATCH net-next] " Cong Wang
2022-10-15 20:26 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221012175717.GA26425@bytedance \
--to=yepeilin.cs@gmail.com \
--cc=cong.wang@bytedance.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peilin.ye@bytedance.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.