From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7EAFC433FE for ; Wed, 12 Oct 2022 22:10:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230155AbiJLWKf (ORCPT ); Wed, 12 Oct 2022 18:10:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57112 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230054AbiJLWKP (ORCPT ); Wed, 12 Oct 2022 18:10:15 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B488B44560 for ; Wed, 12 Oct 2022 15:08:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1665612514; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=e1Csc5OKDLMm08qWQhJj0nFioDDfbxhqyYmrCk7iHHE=; b=KGFH2YlHvLrMbBRzhjzeIaDpOKpngMQcXphoNWQcmMq60SieZHdHr1X7o72DvGNIjY3bTm hLDc7PkCjBh/OyLDHZzLJlGn32jTWGnMoWoL3qqotXVSR9Lo/gjfXc40DVwO49isR1jgNf VBbu3nMX+Zhqt4Me7aqa+u4nfSL2udQ= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-528-hI43in_CNOqrZmzRe-vc3w-1; Wed, 12 Oct 2022 18:08:33 -0400 X-MC-Unique: hI43in_CNOqrZmzRe-vc3w-1 Received: by mail-wm1-f70.google.com with SMTP id c5-20020a1c3505000000b003c56da8e894so1810630wma.0 for ; Wed, 12 Oct 2022 15:08:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=e1Csc5OKDLMm08qWQhJj0nFioDDfbxhqyYmrCk7iHHE=; b=Hu1C5KGqurbUgX8XjCc9saCGCFw+0NYphnn8u9VKdmWagzZaKiPm7XR4Wj1NlfeXsl FHapQLBoa5rIrX/M1wEirPSZTp0x72osBZDIZO9exk3DgdEoP112gjKSHlRI/jKcv1w9 NqdJJJNadMwjprAwfqJjl8AMWw5EjuRs9B2/DVmKKANIqvTJcVi6ueymgw46JMU7Gaxf ekxmcG7yvKAZuQm/CKS7O3XuzYay6WldI6lJkxh1lXV0NUadO5WU+6SFZbP5TN/bkbB3 KwAk0GtjSy7g3+7vcDuMuYVHf5ND7W5NX6+e+c9iydN66eF1yYARH0OSt47G/28MRjx9 NPvQ== X-Gm-Message-State: ACrzQf1cJNuPQcQy7yTqiEHW3uGC3QH1wUnE8qZ68k5XZ56TYs+djTMk TCfhtfw3XrfhX1fZNZan76TToYvNyPJs9yoTD4B2JjCLcc94t3vyIvHMPYtsW7qmKiTD0J7pCmN KC3MAjNifo2cjFHi+WrYK X-Received: by 2002:adf:d1cc:0:b0:22e:6371:65ad with SMTP id b12-20020adfd1cc000000b0022e637165admr19590799wrd.326.1665612512756; Wed, 12 Oct 2022 15:08:32 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4Hfapj638ZSQQKBud2DiNS0QJza/l7oyJMq2zEMTl7MZoMYSzTy3MWiISMgB3bUUa2AIbrEw== X-Received: by 2002:adf:d1cc:0:b0:22e:6371:65ad with SMTP id b12-20020adfd1cc000000b0022e637165admr19590785wrd.326.1665612512531; Wed, 12 Oct 2022 15:08:32 -0700 (PDT) Received: from redhat.com ([2.54.162.123]) by smtp.gmail.com with ESMTPSA id a1-20020a05600c348100b003a5f4fccd4asm2812081wmq.35.2022.10.12.15.08.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Oct 2022 15:08:31 -0700 (PDT) Date: Wed, 12 Oct 2022 18:08:27 -0400 From: "Michael S. Tsirkin" To: Arnd Bergmann Cc: Linus Torvalds , xiujianfeng@huawei.com, kvm@vger.kernel.org, alvaro.karsz@solid-run.com, Jason Wang , angus.chen@jaguarmicro.com, wangdeming@inspur.com, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, virtualization@lists.linux-foundation.org, Netdev , Bjorn Helgaas , lingshan.zhu@intel.com, linuxppc-dev@lists.ozlabs.org, gavinl@nvidia.com Subject: Re: [GIT PULL] virtio: fixes, features Message-ID: <20221012180806-mutt-send-email-mst@kernel.org> References: <20221010132030-mutt-send-email-mst@kernel.org> <87r0zdmujf.fsf@mpe.ellerman.id.au> <20221012070532-mutt-send-email-mst@kernel.org> <87mta1marq.fsf@mpe.ellerman.id.au> <87edvdm7qg.fsf@mpe.ellerman.id.au> <20221012115023-mutt-send-email-mst@kernel.org> <38893b2e-c7a1-4ad2-b691-7fbcbbeb310f@app.fastmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <38893b2e-c7a1-4ad2-b691-7fbcbbeb310f@app.fastmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Wed, Oct 12, 2022 at 11:06:54PM +0200, Arnd Bergmann wrote: > On Wed, Oct 12, 2022, at 7:22 PM, Linus Torvalds wrote: > > > > The NO_IRQ thing is mainly actually defined by a few drivers that just > > never got converted to the proper world order, and even then you can > > see the confusion (ie some drivers use "-1", others use "0", and yet > > others use "((unsigned int)(-1)". > > The last time I looked at removing it for arch/arm/, one problem was > that there were a number of platforms using IRQ 0 as a valid number. > We have converted most of them in the meantime, leaving now only > mach-rpc and mach-footbridge. For the other platforms, we just > renumbered all interrupts to add one, but footbridge apparently > relies on hardcoded ISA interrupts in device drivers. For rpc, > it looks like IRQ 0 (printer) already wouldn't work, and it > looks like there was never a driver referencing it either. Do these two boxes even have pci? > I see that openrisc and parisc also still define NO_IRQ to -1, but at > least openrisc already relies on 0 being the invalid IRQ (from > CONFIG_IRQ_DOMAIN), probably parisc as well. > > Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C09B5C4332F for ; Wed, 12 Oct 2022 22:09:42 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Mnmz90GnZz3dqP for ; Thu, 13 Oct 2022 09:09:41 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=haSpoTMY; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=haSpoTMY; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=redhat.com (client-ip=170.10.129.124; helo=us-smtp-delivery-124.mimecast.com; envelope-from=mst@redhat.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=haSpoTMY; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=haSpoTMY; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Mnmy4355Bz3bjj for ; Thu, 13 Oct 2022 09:08:41 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1665612519; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=e1Csc5OKDLMm08qWQhJj0nFioDDfbxhqyYmrCk7iHHE=; b=haSpoTMYY896Twk1ShX0OHjKQ6KGljkslMnyxbPLBbOEEVNxhhj8PRE+2tUluv0NBjd+pl r0BwgfaZfjd/R653AvNH9zLEMK4mnkwhiaDXG953snG1qx5932sF9Q3Ezrx7xv/Qt2wxoM UIISZNxXZUyo/sZ5AlLWQdQQZzKXKwM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1665612519; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=e1Csc5OKDLMm08qWQhJj0nFioDDfbxhqyYmrCk7iHHE=; b=haSpoTMYY896Twk1ShX0OHjKQ6KGljkslMnyxbPLBbOEEVNxhhj8PRE+2tUluv0NBjd+pl r0BwgfaZfjd/R653AvNH9zLEMK4mnkwhiaDXG953snG1qx5932sF9Q3Ezrx7xv/Qt2wxoM UIISZNxXZUyo/sZ5AlLWQdQQZzKXKwM= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-613-wmA8nb_JNJS8342jTHxRnQ-1; Wed, 12 Oct 2022 18:08:33 -0400 X-MC-Unique: wmA8nb_JNJS8342jTHxRnQ-1 Received: by mail-wm1-f70.google.com with SMTP id 133-20020a1c028b000000b003c5e6b44ebaso1776526wmc.9 for ; Wed, 12 Oct 2022 15:08:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=e1Csc5OKDLMm08qWQhJj0nFioDDfbxhqyYmrCk7iHHE=; b=NHop5cD7daeVu2ZB2xrXBGyjnejQV3Wbn2SxxO/q+51R1wuv/ehQUebfl3dd0Eydvh m3p/rds+wEYt1Cceqhkha99RFfhnXD5T3tMeLAqXkiaYfvw2mMexWIdgFaxHKHj2yVjo XZ23HIj3LWZ7qwpnMUNGSwyXA1wnJF1AqSl5v88vgFWBeQ5+RJnU3i5PztYRjwHpc9/Z OmqgbYfntcTYl4qgfyy43u0C7eAKGd3Tc2J45174Jm631Cu8AruOUxJx4mgEUbKW09NT IAjJTeAW2iMsfOTt61aTBTQHd8MUdUhRYq31pE+EEArytW4zm3Ezieq5hgb3KFG5cx2q V2GA== X-Gm-Message-State: ACrzQf2SLFo3KqJjHKXxKDvxvV3C14EDfJNFqxFZcd9sP9bNCCP3ZU4j Fh801BznnTRkYN+o2yJUdSNH7Oxn4y7zBNMTpFmGrnx8oF/PMEB08yt7IvAdbZPx0ibFBSHBHZ2 T+/px9sq49WdYTzmRkl0nAquGfQ== X-Received: by 2002:adf:d1cc:0:b0:22e:6371:65ad with SMTP id b12-20020adfd1cc000000b0022e637165admr19590809wrd.326.1665612512761; Wed, 12 Oct 2022 15:08:32 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4Hfapj638ZSQQKBud2DiNS0QJza/l7oyJMq2zEMTl7MZoMYSzTy3MWiISMgB3bUUa2AIbrEw== X-Received: by 2002:adf:d1cc:0:b0:22e:6371:65ad with SMTP id b12-20020adfd1cc000000b0022e637165admr19590785wrd.326.1665612512531; Wed, 12 Oct 2022 15:08:32 -0700 (PDT) Received: from redhat.com ([2.54.162.123]) by smtp.gmail.com with ESMTPSA id a1-20020a05600c348100b003a5f4fccd4asm2812081wmq.35.2022.10.12.15.08.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Oct 2022 15:08:31 -0700 (PDT) Date: Wed, 12 Oct 2022 18:08:27 -0400 From: "Michael S. Tsirkin" To: Arnd Bergmann Subject: Re: [GIT PULL] virtio: fixes, features Message-ID: <20221012180806-mutt-send-email-mst@kernel.org> References: <20221010132030-mutt-send-email-mst@kernel.org> <87r0zdmujf.fsf@mpe.ellerman.id.au> <20221012070532-mutt-send-email-mst@kernel.org> <87mta1marq.fsf@mpe.ellerman.id.au> <87edvdm7qg.fsf@mpe.ellerman.id.au> <20221012115023-mutt-send-email-mst@kernel.org> <38893b2e-c7a1-4ad2-b691-7fbcbbeb310f@app.fastmail.com> MIME-Version: 1.0 In-Reply-To: <38893b2e-c7a1-4ad2-b691-7fbcbbeb310f@app.fastmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: xiujianfeng@huawei.com, kvm@vger.kernel.org, alvaro.karsz@solid-run.com, linux-pci@vger.kernel.org, Jason Wang , linuxppc-dev@lists.ozlabs.org, wangdeming@inspur.com, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, Netdev , angus.chen@jaguarmicro.com, Bjorn Helgaas , lingshan.zhu@intel.com, Linus Torvalds , gavinl@nvidia.com Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Wed, Oct 12, 2022 at 11:06:54PM +0200, Arnd Bergmann wrote: > On Wed, Oct 12, 2022, at 7:22 PM, Linus Torvalds wrote: > > > > The NO_IRQ thing is mainly actually defined by a few drivers that just > > never got converted to the proper world order, and even then you can > > see the confusion (ie some drivers use "-1", others use "0", and yet > > others use "((unsigned int)(-1)". > > The last time I looked at removing it for arch/arm/, one problem was > that there were a number of platforms using IRQ 0 as a valid number. > We have converted most of them in the meantime, leaving now only > mach-rpc and mach-footbridge. For the other platforms, we just > renumbered all interrupts to add one, but footbridge apparently > relies on hardcoded ISA interrupts in device drivers. For rpc, > it looks like IRQ 0 (printer) already wouldn't work, and it > looks like there was never a driver referencing it either. Do these two boxes even have pci? > I see that openrisc and parisc also still define NO_IRQ to -1, but at > least openrisc already relies on 0 being the invalid IRQ (from > CONFIG_IRQ_DOMAIN), probably parisc as well. > > Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D274AC4332F for ; Wed, 12 Oct 2022 22:08:52 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 5D0C860B58; Wed, 12 Oct 2022 22:08:52 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 5D0C860B58 Authentication-Results: smtp3.osuosl.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=XX+48jZW X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IIMHD8nVts25; Wed, 12 Oct 2022 22:08:51 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp3.osuosl.org (Postfix) with ESMTPS id EC29760757; Wed, 12 Oct 2022 22:08:50 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org EC29760757 Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id CE5FCC0032; Wed, 12 Oct 2022 22:08:50 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id 9FB3BC002D for ; Wed, 12 Oct 2022 22:08:49 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 71D07416C8 for ; Wed, 12 Oct 2022 22:08:49 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 71D07416C8 Authentication-Results: smtp4.osuosl.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=XX+48jZW X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rsWSwtaLPsNL for ; Wed, 12 Oct 2022 22:08:48 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 8589341505 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by smtp4.osuosl.org (Postfix) with ESMTPS id 8589341505 for ; Wed, 12 Oct 2022 22:08:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1665612527; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=e1Csc5OKDLMm08qWQhJj0nFioDDfbxhqyYmrCk7iHHE=; b=XX+48jZWvKaFm3q5NoTsJwvqcyNTvUrUk2992YGCNwx+plWlyMY7l8M5oZ+eeSBJsWO1GO 6/0vwFwx+cnb/Gso+pljGLLnjQG3FstaqLqadKV9Oz8y9/272UPROHJWt2YYuNgiBzP+Kf FfvVND/bdvGe3eoBc9BkC0nwDVCravc= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-191-QBSgEGVyPJy7QrmRe8Z4MQ-1; Wed, 12 Oct 2022 18:08:33 -0400 X-MC-Unique: QBSgEGVyPJy7QrmRe8Z4MQ-1 Received: by mail-wm1-f72.google.com with SMTP id r132-20020a1c448a000000b003c3a87d8abdso34495wma.2 for ; Wed, 12 Oct 2022 15:08:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=e1Csc5OKDLMm08qWQhJj0nFioDDfbxhqyYmrCk7iHHE=; b=JNQrYZmkQeip00qNEgUlaJOb8yntvU+4L8o3GevVMNognQZTFhHwmtzxJl2l9VS24g DOEsZ0fsBPlnCt0eQchZMBWfHh3YESepPaf6myxrnGD2f6xLZb4fzioyZYnw/lEI+V/w q0ZmxIZnNizOE3+3adHyJ2ZrmoVPcB+jZrixkRHBG66Un3b275+xvyZjOg8lCZVBQThA aKxXOdDK8o/Gj34bhg8phwu3H5WIEuN+kvteJ01zL8Cwaw5MJxw0KVINLSMBE6XfqyIi mQy3Wxdesf18DZD5kln19QPjNw7tQ7ofVN0x5Ll1pNc9CFTLjyAualmk2ZFk/Vhxt+V0 y2aQ== X-Gm-Message-State: ACrzQf3AqRdzDpSu2J2wJnAL16E4rBR2h5V95JcoqGvEfijRkkt2vjnL sx/yg8xi8e6d7OobO5sYOvmcVOJ0Z8eKqA1/r3YfEUs6mcU0zDDy9nljFeuN6ytKFWm2xtPUw/B fW4vjUCOtM6iwLKjG42YQGcfJmTaOosfmzY5uQc5XoQ== X-Received: by 2002:adf:d1cc:0:b0:22e:6371:65ad with SMTP id b12-20020adfd1cc000000b0022e637165admr19590803wrd.326.1665612512759; Wed, 12 Oct 2022 15:08:32 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4Hfapj638ZSQQKBud2DiNS0QJza/l7oyJMq2zEMTl7MZoMYSzTy3MWiISMgB3bUUa2AIbrEw== X-Received: by 2002:adf:d1cc:0:b0:22e:6371:65ad with SMTP id b12-20020adfd1cc000000b0022e637165admr19590785wrd.326.1665612512531; Wed, 12 Oct 2022 15:08:32 -0700 (PDT) Received: from redhat.com ([2.54.162.123]) by smtp.gmail.com with ESMTPSA id a1-20020a05600c348100b003a5f4fccd4asm2812081wmq.35.2022.10.12.15.08.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Oct 2022 15:08:31 -0700 (PDT) Date: Wed, 12 Oct 2022 18:08:27 -0400 From: "Michael S. Tsirkin" To: Arnd Bergmann Subject: Re: [GIT PULL] virtio: fixes, features Message-ID: <20221012180806-mutt-send-email-mst@kernel.org> References: <20221010132030-mutt-send-email-mst@kernel.org> <87r0zdmujf.fsf@mpe.ellerman.id.au> <20221012070532-mutt-send-email-mst@kernel.org> <87mta1marq.fsf@mpe.ellerman.id.au> <87edvdm7qg.fsf@mpe.ellerman.id.au> <20221012115023-mutt-send-email-mst@kernel.org> <38893b2e-c7a1-4ad2-b691-7fbcbbeb310f@app.fastmail.com> MIME-Version: 1.0 In-Reply-To: <38893b2e-c7a1-4ad2-b691-7fbcbbeb310f@app.fastmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Cc: xiujianfeng@huawei.com, kvm@vger.kernel.org, linux-pci@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, wangdeming@inspur.com, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, Netdev , angus.chen@jaguarmicro.com, Bjorn Helgaas , lingshan.zhu@intel.com, Linus Torvalds , gavinl@nvidia.com X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" On Wed, Oct 12, 2022 at 11:06:54PM +0200, Arnd Bergmann wrote: > On Wed, Oct 12, 2022, at 7:22 PM, Linus Torvalds wrote: > > > > The NO_IRQ thing is mainly actually defined by a few drivers that just > > never got converted to the proper world order, and even then you can > > see the confusion (ie some drivers use "-1", others use "0", and yet > > others use "((unsigned int)(-1)". > > The last time I looked at removing it for arch/arm/, one problem was > that there were a number of platforms using IRQ 0 as a valid number. > We have converted most of them in the meantime, leaving now only > mach-rpc and mach-footbridge. For the other platforms, we just > renumbered all interrupts to add one, but footbridge apparently > relies on hardcoded ISA interrupts in device drivers. For rpc, > it looks like IRQ 0 (printer) already wouldn't work, and it > looks like there was never a driver referencing it either. Do these two boxes even have pci? > I see that openrisc and parisc also still define NO_IRQ to -1, but at > least openrisc already relies on 0 being the invalid IRQ (from > CONFIG_IRQ_DOMAIN), probably parisc as well. > > Arnd _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization