From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC4F7C4321E for ; Thu, 13 Oct 2022 01:37:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229925AbiJMBhb (ORCPT ); Wed, 12 Oct 2022 21:37:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36406 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229681AbiJMBh2 (ORCPT ); Wed, 12 Oct 2022 21:37:28 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A28814D8FF; Wed, 12 Oct 2022 18:37:26 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 76BCD616EB; Thu, 13 Oct 2022 00:23:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 55025C433D6; Thu, 13 Oct 2022 00:23:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1665620607; bh=Pb1LzrXPC82IIIm7m5LUcYzeme4hYX2EJViSVH+XwQQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ClG1xAsZ5J2jMwjqDvhkbhB0Qq/25tR7y8TVnF+ChiR5it5W9K+aVsGT+Kg6ZW1Iy eu5rjzum9aBgF/4h2saYTMRlqAyK5xF8M13JZQyq9MTGaTewsiJsHH066lOBrXV2R5 /78t1AdNgeoYY9LvTB3MWkyk7/BjAog98bKFsOfjBGSWc5GjvxO0S4mrX9tuSNoXnm ygPRuf8friu5kMyrxrjiILRls8EGQJ0MaEkPVsi2rja/i3hAoiUpkoE/bKoYsNeHYW kULTQ3nzaUZhl2PHwyJKQrrY8ny6JMvDGWYYX4xDlNt0Qvu95YVnVgaIfUsHEQ6eL0 7iUu6TcVYeJMQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Maxime Ripard , =?UTF-8?q?Noralf=20Tr=C3=B8nnes?= , Stefan Wahren , Stephen Boyd , Sasha Levin , mturquette@baylibre.com, f.fainelli@gmail.com, rjui@broadcom.com, sbranden@broadcom.com, nsaenz@kernel.org, iivanov@suse.de, linux-clk@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH AUTOSEL 5.15 46/47] clk: bcm2835: Make peripheral PLLC critical Date: Wed, 12 Oct 2022 20:21:21 -0400 Message-Id: <20221013002124.1894077-46-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221013002124.1894077-1-sashal@kernel.org> References: <20221013002124.1894077-1-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org From: Maxime Ripard [ Upstream commit 6c5422851d8be8c7451e968fd2e6da41b6109e17 ] When testing for a series affecting the VEC, it was discovered that turning off and on the VEC clock is crashing the system. It turns out that, when disabling the VEC clock, it's the only child of the PLLC-per clock which will also get disabled. The source of the crash is PLLC-per being disabled. It's likely that some other device might not take a clock reference that it actually needs, but it's unclear which at this point. Let's make PLLC-per critical so that we don't have that crash. Reported-by: Noralf Trønnes Signed-off-by: Maxime Ripard Link: https://lore.kernel.org/r/20220926084509.12233-1-maxime@cerno.tech Reviewed-by: Stefan Wahren Acked-by: Noralf Trønnes Signed-off-by: Stephen Boyd Signed-off-by: Sasha Levin --- drivers/clk/bcm/clk-bcm2835.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/bcm/clk-bcm2835.c b/drivers/clk/bcm/clk-bcm2835.c index 3667b4d731e7..298763e78263 100644 --- a/drivers/clk/bcm/clk-bcm2835.c +++ b/drivers/clk/bcm/clk-bcm2835.c @@ -1785,7 +1785,7 @@ static const struct bcm2835_clk_desc clk_desc_array[] = { .load_mask = CM_PLLC_LOADPER, .hold_mask = CM_PLLC_HOLDPER, .fixed_divider = 1, - .flags = CLK_SET_RATE_PARENT), + .flags = CLK_IS_CRITICAL | CLK_SET_RATE_PARENT), /* * PLLD is the display PLL, used to drive DSI display panels. -- 2.35.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7ACB7C4332F for ; Thu, 13 Oct 2022 00:37:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wxBbMJyp061ZGOAAgDrofpyBANTxGnDoDiGlYbXtBJI=; b=MLtxjOeEm1k2RI 6XDos6Po6oxUaEtNo3bzoKIdOtisDfn+ZavmTw0Ed6M0KhNSnAyBWbDA0dKOH7wPBH3vEYfYweww8 h2YXMmxH3l95ysqbtGPe5ABWrqubWZDE8hB05dWxV40bbVuoZRfnXZG0EOMmeIdTlT3/ESMHhdmMN FxVuFqkDb/mWf0q4VpqUefGATWto3AcOHZu6FqSwXaq/VRidyf+6J/Hjf8D13qwio/J0KeD0dP9yT uH1o1F3IloBoJRsuqnZJspIHJUIDRO8bIGT2sUqEijQN8715/ESry/0jwutG3Oms/VI8nwVysh42n Wed9sgKSVxmuklNogrZg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oimCO-009vJX-Ic; Thu, 13 Oct 2022 00:35:45 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oim0W-009pci-UC; Thu, 13 Oct 2022 00:23:30 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6F362616D7; Thu, 13 Oct 2022 00:23:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 55025C433D6; Thu, 13 Oct 2022 00:23:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1665620607; bh=Pb1LzrXPC82IIIm7m5LUcYzeme4hYX2EJViSVH+XwQQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ClG1xAsZ5J2jMwjqDvhkbhB0Qq/25tR7y8TVnF+ChiR5it5W9K+aVsGT+Kg6ZW1Iy eu5rjzum9aBgF/4h2saYTMRlqAyK5xF8M13JZQyq9MTGaTewsiJsHH066lOBrXV2R5 /78t1AdNgeoYY9LvTB3MWkyk7/BjAog98bKFsOfjBGSWc5GjvxO0S4mrX9tuSNoXnm ygPRuf8friu5kMyrxrjiILRls8EGQJ0MaEkPVsi2rja/i3hAoiUpkoE/bKoYsNeHYW kULTQ3nzaUZhl2PHwyJKQrrY8ny6JMvDGWYYX4xDlNt0Qvu95YVnVgaIfUsHEQ6eL0 7iUu6TcVYeJMQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Maxime Ripard , =?UTF-8?q?Noralf=20Tr=C3=B8nnes?= , Stefan Wahren , Stephen Boyd , Sasha Levin , mturquette@baylibre.com, f.fainelli@gmail.com, rjui@broadcom.com, sbranden@broadcom.com, nsaenz@kernel.org, iivanov@suse.de, linux-clk@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH AUTOSEL 5.15 46/47] clk: bcm2835: Make peripheral PLLC critical Date: Wed, 12 Oct 2022 20:21:21 -0400 Message-Id: <20221013002124.1894077-46-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221013002124.1894077-1-sashal@kernel.org> References: <20221013002124.1894077-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221012_172329_069786_ECC7ED90 X-CRM114-Status: GOOD ( 14.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org RnJvbTogTWF4aW1lIFJpcGFyZCA8bWF4aW1lQGNlcm5vLnRlY2g+CgpbIFVwc3RyZWFtIGNvbW1p dCA2YzU0MjI4NTFkOGJlOGM3NDUxZTk2OGZkMmU2ZGE0MWI2MTA5ZTE3IF0KCldoZW4gdGVzdGlu ZyBmb3IgYSBzZXJpZXMgYWZmZWN0aW5nIHRoZSBWRUMsIGl0IHdhcyBkaXNjb3ZlcmVkIHRoYXQK dHVybmluZyBvZmYgYW5kIG9uIHRoZSBWRUMgY2xvY2sgaXMgY3Jhc2hpbmcgdGhlIHN5c3RlbS4K Ckl0IHR1cm5zIG91dCB0aGF0LCB3aGVuIGRpc2FibGluZyB0aGUgVkVDIGNsb2NrLCBpdCdzIHRo ZSBvbmx5IGNoaWxkIG9mCnRoZSBQTExDLXBlciBjbG9jayB3aGljaCB3aWxsIGFsc28gZ2V0IGRp c2FibGVkLiBUaGUgc291cmNlIG9mIHRoZSBjcmFzaAppcyBQTExDLXBlciBiZWluZyBkaXNhYmxl ZC4KCkl0J3MgbGlrZWx5IHRoYXQgc29tZSBvdGhlciBkZXZpY2UgbWlnaHQgbm90IHRha2UgYSBj bG9jayByZWZlcmVuY2UgdGhhdAppdCBhY3R1YWxseSBuZWVkcywgYnV0IGl0J3MgdW5jbGVhciB3 aGljaCBhdCB0aGlzIHBvaW50LiBMZXQncyBtYWtlClBMTEMtcGVyIGNyaXRpY2FsIHNvIHRoYXQg d2UgZG9uJ3QgaGF2ZSB0aGF0IGNyYXNoLgoKUmVwb3J0ZWQtYnk6IE5vcmFsZiBUcsO4bm5lcyA8 bm9yYWxmQHRyb25uZXMub3JnPgpTaWduZWQtb2ZmLWJ5OiBNYXhpbWUgUmlwYXJkIDxtYXhpbWVA Y2Vybm8udGVjaD4KTGluazogaHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcvci8yMDIyMDkyNjA4NDUw OS4xMjIzMy0xLW1heGltZUBjZXJuby50ZWNoClJldmlld2VkLWJ5OiBTdGVmYW4gV2FocmVuIDxz dGVmYW4ud2FocmVuQGkyc2UuY29tPgpBY2tlZC1ieTogTm9yYWxmIFRyw7hubmVzIDxub3JhbGZA dHJvbm5lcy5vcmc+ClNpZ25lZC1vZmYtYnk6IFN0ZXBoZW4gQm95ZCA8c2JveWRAa2VybmVsLm9y Zz4KU2lnbmVkLW9mZi1ieTogU2FzaGEgTGV2aW4gPHNhc2hhbEBrZXJuZWwub3JnPgotLS0KIGRy aXZlcnMvY2xrL2JjbS9jbGstYmNtMjgzNS5jIHwgMiArLQogMSBmaWxlIGNoYW5nZWQsIDEgaW5z ZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvZHJpdmVycy9jbGsvYmNtL2Ns ay1iY20yODM1LmMgYi9kcml2ZXJzL2Nsay9iY20vY2xrLWJjbTI4MzUuYwppbmRleCAzNjY3YjRk NzMxZTcuLjI5ODc2M2U3ODI2MyAxMDA2NDQKLS0tIGEvZHJpdmVycy9jbGsvYmNtL2Nsay1iY20y ODM1LmMKKysrIGIvZHJpdmVycy9jbGsvYmNtL2Nsay1iY20yODM1LmMKQEAgLTE3ODUsNyArMTc4 NSw3IEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3QgYmNtMjgzNV9jbGtfZGVzYyBjbGtfZGVzY19hcnJh eVtdID0gewogCQkubG9hZF9tYXNrID0gQ01fUExMQ19MT0FEUEVSLAogCQkuaG9sZF9tYXNrID0g Q01fUExMQ19IT0xEUEVSLAogCQkuZml4ZWRfZGl2aWRlciA9IDEsCi0JCS5mbGFncyA9IENMS19T RVRfUkFURV9QQVJFTlQpLAorCQkuZmxhZ3MgPSBDTEtfSVNfQ1JJVElDQUwgfCBDTEtfU0VUX1JB VEVfUEFSRU5UKSwKIAogCS8qCiAJICogUExMRCBpcyB0aGUgZGlzcGxheSBQTEwsIHVzZWQgdG8g ZHJpdmUgRFNJIGRpc3BsYXkgcGFuZWxzLgotLSAKMi4zNS4xCgoKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxp c3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZy YWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=