From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 88319443B
	for <imx@lists.linux.dev>; Thu, 13 Oct 2022 23:12:31 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8FC34C433D6;
	Thu, 13 Oct 2022 23:12:30 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1665702751;
	bh=P6mYHp+DRLjwROKc+7ypL5XLojBKKdpSLTvsOv75fHk=;
	h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
	b=TweiAsVFd5CLBV+95vW5XPlNulUSZX73E9zrdjUTc2FVRzeH6N2UwruvHV7pKvn2J
	 zQEZHg2pAC+0dSpuBxzg/j6vFpAHTEtT70yCJAr+yT9n8VLbVxs/Y8n8MlkWDyxQXQ
	 YIAVwHE9fC0WKp3npgpM+WzLb7X6Ps37mp83MPTVtMt5J6NQfPzarBEzl+Zs+QG/TT
	 7Y0urrDeXo8CDAz/t7VrZCUVASC7uKD+4p0XGqXKrPzyIPqWO1nRxXT3hP2ucFxSkz
	 /ZB4i/cPHydyQO6zpTzlMIUXrY5JQRALSrPUIlOAynuplqZhLRcQze1rJE8lB6J/m2
	 qwI7u1kpHZRgg==
Date: Thu, 13 Oct 2022 16:12:29 -0700
From: Jakub Kicinski <kuba@kernel.org>
To: Shenwei Wang <shenwei.wang@nxp.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>, "David S. Miller"
 <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Paolo Abeni
 <pabeni@redhat.com>, Maxime Coquelin <mcoquelin.stm32@gmail.com>, Russell
 King <linux@armlinux.org.uk>, Andrew Lunn <andrew@lunn.ch>, Heiner Kallweit
 <hkallweit1@gmail.com>, Giuseppe Cavallaro <peppe.cavallaro@st.com>,
 Alexandre Torgue <alexandre.torgue@foss.st.com>, Jose Abreu
 <joabreu@synopsys.com>, "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
 "linux-stm32@st-md-mailman.stormreply.com\"        
 <linux-stm32@st-md-mailman.stormreply.com>,
 "linux-arm-kernel@lists.infradead.org\"        
 <linux-arm-kernel@lists.infradead.org>, "imx@lists.linux.dev"
 <imx@lists.linux.dev>, Russell King <rmk+kernel@armlinux.org.uk>
Subject: Re: [EXT] Re: [PATCH v5 1/2] net: phylink: add mac_managed_pm in
 phylink_config structure
Message-ID: <20221013161229.73471c88@kernel.org>
In-Reply-To: <PAXPR04MB9185C63C94CE032DCEE60AE689259@PAXPR04MB9185.eurprd04.prod.outlook.com>
References: <20221013133904.978802-1-shenwei.wang@nxp.com>
	<20221013133904.978802-2-shenwei.wang@nxp.com>
	<2c861748-b881-f464-abd1-1a1588e2a330@gmail.com>
	<PAXPR04MB9185C63C94CE032DCEE60AE689259@PAXPR04MB9185.eurprd04.prod.outlook.com>
Precedence: bulk
X-Mailing-List: imx@lists.linux.dev
List-Id: <imx.lists.linux.dev>
List-Subscribe: <mailto:imx+subscribe@lists.linux.dev>
List-Unsubscribe: <mailto:imx+unsubscribe@lists.linux.dev>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Thu, 13 Oct 2022 19:28:45 +0000 Shenwei Wang wrote:
> > Fixes: 47ac7b2f6a1f ("net: phy: Warn about incorrect
> > mdio_bus_phy_resume() state"
> >   
> 
> That was my original format. But it met the following warning when ran checkpatch.pl script:
> 
> ./scripts/checkpatch.pl 0001-net-phylink-add-mac_managed_pm-in-phylink_config-str.patch 
> WARNING: Please use correct Fixes: style 'Fixes: <12 chars of sha1> ("<title line>")' - ie: 'Fixes: e6a39ffcfe22 ("net: stmmac: Enable mac_managed_pm phylink config")'
> #20: 
> Fixes: 47ac7b2f6a1f ("net: phy: Warn about incorrect
> 
> That's why I changed to the current tag format.

It needs to be all on one line:

Fixes: 47ac7b2f6a1f ("net: phy: Warn about incorrect mdio_bus_phy_resume() state")

But I don't see 47ac7b2f6a1f in my trees, are you sure that's 
the upstream commit id?