From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFA03C4332F for ; Thu, 13 Oct 2022 20:04:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229692AbiJMUEC (ORCPT ); Thu, 13 Oct 2022 16:04:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60192 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229548AbiJMUEA (ORCPT ); Thu, 13 Oct 2022 16:04:00 -0400 Received: from mail-ot1-f46.google.com (mail-ot1-f46.google.com [209.85.210.46]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8628718DA85; Thu, 13 Oct 2022 13:03:59 -0700 (PDT) Received: by mail-ot1-f46.google.com with SMTP id p24-20020a9d6958000000b00661c528849eso686032oto.9; Thu, 13 Oct 2022 13:03:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=o/H8aAoz6l7rETFO7J3jM7BsdijuYpZHfTxeVocScgc=; b=IH97tXIEuqHnv8yF0buqqqae0R1x5DSmNdsl8xZQbJYM545pp6XznNlbmTrifm0MHk VhLti5fKSjtbzt3CC6W9oHJ9tTqhzIirByxaPnMvimswbnNyYyKNtkW8FGiDKtmAnrCW ODdqoUh4Aga/ZaoYkNGG3OkaRUO1oiWkfQ0cr655sgg3DKL7V5zym3ypCdl5GJ8YgK9r UPBRB2nOwIqqwE5Xh6WF5x70kGF+xeVeHWRo96Q85RBv+WYrh8Kiu365BJ58uPz5dQKD q19Zr5koCIZ06P52m0ywRieeyZc5yBae5rw1ADNNOcwRDNI3w5XPAz2GjRRg1RfNayOj DDxg== X-Gm-Message-State: ACrzQf0uamoJZVaDA9RvkUARyHR5qdRwaFb+20jltpC+rvaAox+ZxC/5 TYVQBL24dimiBNm9nxX2Eg== X-Google-Smtp-Source: AMsMyM7+PYtDsa7EQjA+sQghRK88ENkEV0dxZPFHUd138yZX381K//TyRVFizou9uBpgNYzKSxoABw== X-Received: by 2002:a05:6830:2706:b0:659:ddc3:58cf with SMTP id j6-20020a056830270600b00659ddc358cfmr812657otu.102.1665691438648; Thu, 13 Oct 2022 13:03:58 -0700 (PDT) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id o8-20020a9d4048000000b006619701dc1csm330188oti.54.2022.10.13.13.03.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Oct 2022 13:03:58 -0700 (PDT) Received: (nullmailer pid 161997 invoked by uid 1000); Thu, 13 Oct 2022 20:03:59 -0000 Date: Thu, 13 Oct 2022 15:03:59 -0500 From: Rob Herring To: Sascha Hauer Cc: linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Peter Chen , Peng Fan , Pengutronix Kernel Team , devicetree@vger.kernel.org Subject: Re: [PATCH 6/6] dt-bindings: usb: ci-hdrc-usb2: Add more phy tuning properties Message-ID: <20221013200359.GA150958-robh@kernel.org> References: <20221011082924.884123-1-s.hauer@pengutronix.de> <20221011082924.884123-7-s.hauer@pengutronix.de> <20221012160806.GA2189350-robh@kernel.org> <20221013101412.GI6702@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221013101412.GI6702@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Thu, Oct 13, 2022 at 12:14:12PM +0200, Sascha Hauer wrote: > On Wed, Oct 12, 2022 at 11:08:06AM -0500, Rob Herring wrote: > > On Tue, Oct 11, 2022 at 10:29:24AM +0200, Sascha Hauer wrote: > > > Following the example of samsung,picophy-dc-vol-level-adjust more > > > phy tuning properties are added for configuring the remaining bitfields > > > in the USBNC_n_PHY_CFG1 register. > > > > All these properties really doesn't scale. These properties should go > > in the phy node as they are properties or the phy. There's no rule that > > you can only read properties from the driver's device node. > > I understand and agree. > > On i.MX8M we currently use the usb-nop-xceiv. I guess it's not an option > to just add these properties there, so we'll need a phy node with a new > compatible like fsl,imx8mm-usbphy. The driver would basically just > register a usb-nop-xceiv and the node would be a container for the new > property. Does this sound sane? I think it would be fine if you do: compatible = "fsl,imx8mm-usbphy", "usb-nop-xceiv"; You'll have to rework the usb-nop-xceiv schema 'select' like we have to do for any compatible appearing in multiple schema files. Or don't have the fallback and add "fsl,imx8mm-usbphy" to the phy-generic.c driver. But that should be marked for stable for at least some compatibility with old kernels. For existing kernel binaries to work, you have to go with the former option. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DAD9AC433FE for ; Thu, 13 Oct 2022 20:05:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=a68hxr9ysYzNqDGKB7WapJv7D2RP/1cELiYXeeTG/rk=; b=nS2cDVpO2bOVaP bEVuH7qRfVRR+/EXWVGuJpxAl/AmnrXSIk2fFDKSM/VrFtKG47yqgb3K2C/g5+N3YQ8VkAqg2ftfG 7O5HVsxa34u3ZEovdSmV93Q413hHIgA8GEKhsAl9oZLny80OgKR5QhJjvcpp5ZHBxwZFwEzJUYIZ/ DyoQYpVUxccdDoODjfu98wZv0CG+iVK6kfeD93k3VMCfTDparvDggyx5VrGcS3/kI5bh8dvPtJ+0S LQzdSvA8fdLI8Zr7zHbKy3++C8M2WDZy8+47GorFtaAiI4cLo/JCI2OzjAlQAr7nzVu6RN2y9mc3q Cs36y5/yEJTX1Nx0K8oA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oj4R1-00CtTy-R0; Thu, 13 Oct 2022 20:04:03 +0000 Received: from mail-ot1-f45.google.com ([209.85.210.45]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oj4Qy-00CtTL-No for linux-arm-kernel@lists.infradead.org; Thu, 13 Oct 2022 20:04:02 +0000 Received: by mail-ot1-f45.google.com with SMTP id z11-20020a05683020cb00b00661a95cf920so681059otq.5 for ; Thu, 13 Oct 2022 13:03:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=o/H8aAoz6l7rETFO7J3jM7BsdijuYpZHfTxeVocScgc=; b=TrcbP23LfUBhECXynN007yehcGGAzfM8Owvf9qdE6uL+hy0qv1pDf+m7Wb8BcF/s9B 53DA8li6vRBdZT89d/22qd0lysBAvA7Ew0MFz+xbkQcJ08NebgfELY6Wktcgnqkq+9Ve ea0oCdxR1XVOYfU0pyzhC9qlfAmFU+5qUJsplgCyedmDGa2e9kj0v4s3gxwjoN/6f69p aJRzSEsjdqSbQ7FeQs3NXGAsXGroSW6ZU7dyv77Pog5xTDhAeSigWGe2Bq+Pa0L0j+J6 MZsww5Va1zEk7LMAIywgGnpoQV2cEfOI8YXrd0W2AdMgB4FbF+mwGE82fYP+tmeiUHs2 BwQQ== X-Gm-Message-State: ACrzQf2qNDoZIcWSYSVprX+G7h63WCSZN03DZnqVR0ijVrqLlkQxng6C QGpU+Ifzk5Re7R6zCfe0Yw== X-Google-Smtp-Source: AMsMyM7+PYtDsa7EQjA+sQghRK88ENkEV0dxZPFHUd138yZX381K//TyRVFizou9uBpgNYzKSxoABw== X-Received: by 2002:a05:6830:2706:b0:659:ddc3:58cf with SMTP id j6-20020a056830270600b00659ddc358cfmr812657otu.102.1665691438648; Thu, 13 Oct 2022 13:03:58 -0700 (PDT) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id o8-20020a9d4048000000b006619701dc1csm330188oti.54.2022.10.13.13.03.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Oct 2022 13:03:58 -0700 (PDT) Received: (nullmailer pid 161997 invoked by uid 1000); Thu, 13 Oct 2022 20:03:59 -0000 Date: Thu, 13 Oct 2022 15:03:59 -0500 From: Rob Herring To: Sascha Hauer Cc: linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Peter Chen , Peng Fan , Pengutronix Kernel Team , devicetree@vger.kernel.org Subject: Re: [PATCH 6/6] dt-bindings: usb: ci-hdrc-usb2: Add more phy tuning properties Message-ID: <20221013200359.GA150958-robh@kernel.org> References: <20221011082924.884123-1-s.hauer@pengutronix.de> <20221011082924.884123-7-s.hauer@pengutronix.de> <20221012160806.GA2189350-robh@kernel.org> <20221013101412.GI6702@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221013101412.GI6702@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221013_130400_791471_F249D887 X-CRM114-Status: GOOD ( 21.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Oct 13, 2022 at 12:14:12PM +0200, Sascha Hauer wrote: > On Wed, Oct 12, 2022 at 11:08:06AM -0500, Rob Herring wrote: > > On Tue, Oct 11, 2022 at 10:29:24AM +0200, Sascha Hauer wrote: > > > Following the example of samsung,picophy-dc-vol-level-adjust more > > > phy tuning properties are added for configuring the remaining bitfields > > > in the USBNC_n_PHY_CFG1 register. > > > > All these properties really doesn't scale. These properties should go > > in the phy node as they are properties or the phy. There's no rule that > > you can only read properties from the driver's device node. > > I understand and agree. > > On i.MX8M we currently use the usb-nop-xceiv. I guess it's not an option > to just add these properties there, so we'll need a phy node with a new > compatible like fsl,imx8mm-usbphy. The driver would basically just > register a usb-nop-xceiv and the node would be a container for the new > property. Does this sound sane? I think it would be fine if you do: compatible = "fsl,imx8mm-usbphy", "usb-nop-xceiv"; You'll have to rework the usb-nop-xceiv schema 'select' like we have to do for any compatible appearing in multiple schema files. Or don't have the fallback and add "fsl,imx8mm-usbphy" to the phy-generic.c driver. But that should be marked for stable for at least some compatibility with old kernels. For existing kernel binaries to work, you have to go with the former option. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel