From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Lang Daniel <d.lang@abatec.at>
Cc: "buildroot@buildroot.org" <buildroot@buildroot.org>
Subject: Re: [Buildroot] [PATCH 1/2] package/iwd: drop dbus check
Date: Fri, 14 Oct 2022 22:10:50 +0200 [thread overview]
Message-ID: <20221014201050.GG2503@scaer> (raw)
In-Reply-To: <VI1P190MB0493E0B331B7910A594A5A689F259@VI1P190MB0493.EURP190.PROD.OUTLOOK.COM>
Daniel, All,
On 2022-10-13 15:01 +0000, Lang Daniel via buildroot spake thusly:
> Since 6f5f6bcd8 dbus is selected when iwd is selected.
>
> Signed-off-by: Daniel Lang <d.lang@abatec.at>
> ---
> package/iwd/iwd.mk | 13 ++++---------
> 1 file changed, 4 insertions(+), 9 deletions(-)
>
> diff --git a/package/iwd/iwd.mk b/package/iwd/iwd.mk
> index fc10c5f1d4..8497fd1141 100644
> --- a/package/iwd/iwd.mk
> +++ b/package/iwd/iwd.mk
> @@ -17,15 +17,10 @@ IWD_AUTORECONF = YES
>
> IWD_CONF_OPTS = \
> --disable-manual-pages \
> - --enable-external-ell
> -IWD_DEPENDENCIES = ell
> -
> -ifeq ($(BR2_PACKAGE_DBUS),y)
> -IWD_CONF_OPTS += --enable-dbus-policy --with-dbus-datadir=/usr/share
> -IWD_DEPENDENCIES += dbus
> -else
> -IWD_CONF_OPTS += --disable-dbus-policy
> -endif
> + --enable-external-ell \
> + --enable-dbus-policy \
> + --with-dbus-datadir=/usr/share
> +IWD_DEPENDENCIES = ell dbus
Why keep a build-time dependency on dbus, if it really is a runtime
dependency as noted in Config.in ?
Can you double-check that iwd does not end up linked to libdbus?
Then, send an update: either drop the build dependency if it really is a
runtiem one, or fix the Config.in comment if it is still needed at build
time.
Regards,
Yann E. MORIN.
> ifeq ($(BR2_PACKAGE_READLINE),y)
> # iwd client depends on readline (GPL-3.0+)
> --
> 2.25.1
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2022-10-14 20:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-13 15:01 [Buildroot] [PATCH 1/2] package/iwd: drop dbus check Lang Daniel via buildroot
2022-10-14 20:10 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221014201050.GG2503@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=d.lang@abatec.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.