All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: linux-iio@vger.kernel.org
Cc: Matti Vaittinen <mazziesaccount@gmail.com>,
	Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>,
	Cosmin Tanislav <cosmin.tanislav@analog.com>,
	Jagath Jog J <jagathjog1996@gmail.com>,
	Sean Nyekjaer <sean@geanix.com>,
	Dmitry Rokosov <DDRokosov@sberdevices.ru>,
	Linus Walleij <linus.walleij@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Michael Hennerich <michael.hennerich@analog.com>,
	Lorenzo Bianconi <lorenzo@kernel.org>,
	Martyn Welch <martyn.welch@collabora.com>,
	Gwendal Grignou <gwendal@chromium.org>,
	Stephen Boyd <swboyd@chromium.org>,
	Tomasz Duszynski <tduszyns@gmail.com>,
	Jonathan Cameron <Jonathan.Cameron@huawei.com>
Subject: [PATCH 14/14] iio: pressure: ms5611: Switch to fully devm_ managed registration.
Date: Sun, 16 Oct 2022 17:34:09 +0100	[thread overview]
Message-ID: <20221016163409.320197-15-jic23@kernel.org> (raw)
In-Reply-To: <20221016163409.320197-1-jic23@kernel.org>

From: Jonathan Cameron <Jonathan.Cameron@huawei.com>

All the remaining calls in probe() have devm_ equivalents so
switching to those allows the remove() callbacks to be deleted.
No functional change.

Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Tomasz Duszynski <tduszyns@gmail.com>
---
 drivers/iio/pressure/ms5611.h      |  1 -
 drivers/iio/pressure/ms5611_core.c | 17 +++--------------
 drivers/iio/pressure/ms5611_i2c.c  |  6 ------
 drivers/iio/pressure/ms5611_spi.c  |  6 ------
 4 files changed, 3 insertions(+), 27 deletions(-)

diff --git a/drivers/iio/pressure/ms5611.h b/drivers/iio/pressure/ms5611.h
index 816e83befd23..f7066315fde3 100644
--- a/drivers/iio/pressure/ms5611.h
+++ b/drivers/iio/pressure/ms5611.h
@@ -58,6 +58,5 @@ struct ms5611_state {
 
 int ms5611_probe(struct iio_dev *indio_dev, struct device *dev,
 		 const char *name, int type);
-void ms5611_remove(struct iio_dev *indio_dev);
 
 #endif /* _MS5611_H */
diff --git a/drivers/iio/pressure/ms5611_core.c b/drivers/iio/pressure/ms5611_core.c
index b95ee6034548..75a98470dcea 100644
--- a/drivers/iio/pressure/ms5611_core.c
+++ b/drivers/iio/pressure/ms5611_core.c
@@ -431,34 +431,23 @@ int ms5611_probe(struct iio_dev *indio_dev, struct device *dev,
 	if (ret < 0)
 		return ret;
 
-	ret = iio_triggered_buffer_setup(indio_dev, NULL,
+	ret = devm_iio_triggered_buffer_setup(dev, indio_dev, NULL,
 					 ms5611_trigger_handler, NULL);
 	if (ret < 0) {
 		dev_err(dev, "iio triggered buffer setup failed\n");
 		return ret;
 	}
 
-	ret = iio_device_register(indio_dev);
+	ret = devm_iio_device_register(dev, indio_dev);
 	if (ret < 0) {
 		dev_err(dev, "unable to register iio device\n");
-		goto err_buffer_cleanup;
+		return ret;
 	}
 
 	return 0;
-
-err_buffer_cleanup:
-	iio_triggered_buffer_cleanup(indio_dev);
-	return ret;
 }
 EXPORT_SYMBOL_NS(ms5611_probe, IIO_MS5611);
 
-void ms5611_remove(struct iio_dev *indio_dev)
-{
-	iio_device_unregister(indio_dev);
-	iio_triggered_buffer_cleanup(indio_dev);
-}
-EXPORT_SYMBOL_NS(ms5611_remove, IIO_MS5611);
-
 MODULE_AUTHOR("Tomasz Duszynski <tduszyns@gmail.com>");
 MODULE_DESCRIPTION("MS5611 core driver");
 MODULE_LICENSE("GPL v2");
diff --git a/drivers/iio/pressure/ms5611_i2c.c b/drivers/iio/pressure/ms5611_i2c.c
index b681a4183909..2bab509a8c1d 100644
--- a/drivers/iio/pressure/ms5611_i2c.c
+++ b/drivers/iio/pressure/ms5611_i2c.c
@@ -105,11 +105,6 @@ static int ms5611_i2c_probe(struct i2c_client *client,
 	return ms5611_probe(indio_dev, &client->dev, id->name, id->driver_data);
 }
 
-static void ms5611_i2c_remove(struct i2c_client *client)
-{
-	ms5611_remove(i2c_get_clientdata(client));
-}
-
 static const struct of_device_id ms5611_i2c_matches[] = {
 	{ .compatible = "meas,ms5611" },
 	{ .compatible = "meas,ms5607" },
@@ -131,7 +126,6 @@ static struct i2c_driver ms5611_driver = {
 	},
 	.id_table = ms5611_id,
 	.probe = ms5611_i2c_probe,
-	.remove = ms5611_i2c_remove,
 };
 module_i2c_driver(ms5611_driver);
 
diff --git a/drivers/iio/pressure/ms5611_spi.c b/drivers/iio/pressure/ms5611_spi.c
index 432e912096f4..f0f5b46d8f9c 100644
--- a/drivers/iio/pressure/ms5611_spi.c
+++ b/drivers/iio/pressure/ms5611_spi.c
@@ -107,11 +107,6 @@ static int ms5611_spi_probe(struct spi_device *spi)
 			    spi_get_device_id(spi)->driver_data);
 }
 
-static void ms5611_spi_remove(struct spi_device *spi)
-{
-	ms5611_remove(spi_get_drvdata(spi));
-}
-
 static const struct of_device_id ms5611_spi_matches[] = {
 	{ .compatible = "meas,ms5611" },
 	{ .compatible = "meas,ms5607" },
@@ -133,7 +128,6 @@ static struct spi_driver ms5611_driver = {
 	},
 	.id_table = ms5611_id,
 	.probe = ms5611_spi_probe,
-	.remove = ms5611_spi_remove,
 };
 module_spi_driver(ms5611_driver);
 
-- 
2.37.2


  parent reply	other threads:[~2022-10-16 16:34 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-16 16:33 [PATCH 00/14] IIO: More devm_regulator[_bulk]_get_enable() users Jonathan Cameron
2022-10-16 16:33 ` [PATCH 01/14] iio: accel: adxl367: Use devm_regulator_bulk_get_enable() Jonathan Cameron
2022-10-17  5:26   ` Matti Vaittinen
2022-10-16 16:33 ` [PATCH 02/14] iio: accel: bma400: " Jonathan Cameron
2022-10-17  5:27   ` Matti Vaittinen
2022-12-04 18:15     ` Jonathan Cameron
2022-10-16 16:33 ` [PATCH 03/14] iio: accel: fxls8962af: Use devm_regulator_get_enable() Jonathan Cameron
2022-10-17  5:27   ` Matti Vaittinen
2022-10-17  9:23   ` Sean Nyekjaer
2022-10-16 16:33 ` [PATCH 04/14] iio: accel: kxcjk-1013: Use devm_regulator_bulk_get_enable() Jonathan Cameron
2022-10-17  5:28   ` Matti Vaittinen
2022-10-16 16:34 ` [PATCH 05/14] iio: accel: msa311: Use devm_regulator_get_enable() Jonathan Cameron
2022-10-18 15:14   ` Dmitry Rokosov
2022-10-16 16:34 ` [PATCH 06/14] iio: cdc: ad7150: " Jonathan Cameron
2022-10-17  5:27   ` Matti Vaittinen
2022-10-16 16:34 ` [PATCH 07/14] iio: st_sensors: core and lsm9ds0 switch to devm_regulator_bulk_get_enable() Jonathan Cameron
2022-10-17  5:44   ` Matti Vaittinen
2022-10-16 16:34 ` [PATCH 08/14] iio: frequency: ad9523: Use devm_regulator_get_enable() Jonathan Cameron
2022-10-17  5:48   ` Matti Vaittinen
2022-10-16 16:34 ` [PATCH 09/14] iio: humidity: hts211: " Jonathan Cameron
2022-10-17  5:53   ` Matti Vaittinen
2022-10-17  7:11   ` Lorenzo Bianconi
2022-10-16 16:34 ` [PATCH 10/14] iio: light: ltr501: Use devm_regulator_bulk_get_enable() Jonathan Cameron
2022-10-17  5:56   ` Matti Vaittinen
2022-10-17  6:03   ` Matti Vaittinen
2022-10-16 16:34 ` [PATCH 11/14] iio: light: noa1305: Use devm_regulator_get_enable() Jonathan Cameron
2022-10-17  6:06   ` Matti Vaittinen
2022-10-16 16:34 ` [PATCH 12/14] iio: proximity: sx_common: Use devm_regulator_bulk_get_enable() Jonathan Cameron
2022-10-17  6:09   ` Matti Vaittinen
2022-10-18 22:21   ` Stephen Boyd
2022-10-16 16:34 ` [PATCH 13/14] iio: pressure: ms5611: Use devm_regulator_get_enable() Jonathan Cameron
2022-10-17  6:26   ` Matti Vaittinen
2022-10-17  6:26   ` Matti Vaittinen
2022-12-04 18:19     ` Jonathan Cameron
2022-10-16 16:34 ` Jonathan Cameron [this message]
2022-10-17  6:30   ` [PATCH 14/14] iio: pressure: ms5611: Switch to fully devm_ managed registration Matti Vaittinen
2022-12-04 18:22     ` Jonathan Cameron
2022-10-17 11:27 ` [PATCH 00/14] IIO: More devm_regulator[_bulk]_get_enable() users Sa, Nuno
2022-10-23 13:03   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221016163409.320197-15-jic23@kernel.org \
    --to=jic23@kernel.org \
    --cc=DDRokosov@sberdevices.ru \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=cosmin.tanislav@analog.com \
    --cc=gwendal@chromium.org \
    --cc=jagathjog1996@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=lorenzo@kernel.org \
    --cc=martyn.welch@collabora.com \
    --cc=matti.vaittinen@fi.rohmeurope.com \
    --cc=mazziesaccount@gmail.com \
    --cc=michael.hennerich@analog.com \
    --cc=sean@geanix.com \
    --cc=swboyd@chromium.org \
    --cc=tduszyns@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.