From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C1BDC4332F for ; Mon, 17 Oct 2022 00:25:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229943AbiJQAZB (ORCPT ); Sun, 16 Oct 2022 20:25:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43588 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229963AbiJQAYv (ORCPT ); Sun, 16 Oct 2022 20:24:51 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 014171263E for ; Sun, 16 Oct 2022 17:24:39 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 5F935B80DAC for ; Mon, 17 Oct 2022 00:24:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0EF1AC433D6; Mon, 17 Oct 2022 00:24:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1665966276; bh=ctrQQqXGyLmieqvR7NfI0WwR4U0/NDfDlxcye2rn5QE=; h=Date:To:From:Subject:From; b=wCREUMhMhO4YY5/yv2qT2KrwY3Ni82PUA/w4WUY6Le0XpB4RvNi3JolE/g9S0PFz5 LV/4q59b3q1XmS8JlPUXggkFpC1aXF7EzYCiUaZh06LvpXTrmlVpePF3mduY45fobm wEET7+7+sWVEX7jw7ma5tYqhcizK/xIF6+liOzEQ= Date: Sun, 16 Oct 2022 17:24:35 -0700 To: mm-commits@vger.kernel.org, ysato@users.osdn.me, will@kernel.org, tsbogend@alpha.franken.de, stefan.kristiansson@saunalahti.fi, shorne@gmail.com, oleg@redhat.com, npiggin@gmail.com, mpe@ellerman.id.au, linux@armlinux.org.uk, jonas@southpole.se, James.Bottomley@HansenPartnership.com, dinguyen@kernel.org, deller@gmx.de, davem@davemloft.net, dalias@libc.org, christophe.leroy@csgroup.eu, catalin.marinas@arm.com, bcain@quicinc.com, s.shtylyov@omp.ru, akpm@linux-foundation.org From: Andrew Morton Subject: + powerpc-ptrace-user_regset_copyin_ignore-always-returns-0.patch added to mm-nonmm-unstable branch Message-Id: <20221017002436.0EF1AC433D6@smtp.kernel.org> Precedence: bulk Reply-To: linux-kernel@vger.kernel.org List-ID: X-Mailing-List: mm-commits@vger.kernel.org The patch titled Subject: powerpc: ptrace: user_regset_copyin_ignore() always returns 0 has been added to the -mm mm-nonmm-unstable branch. Its filename is powerpc-ptrace-user_regset_copyin_ignore-always-returns-0.patch This patch will shortly appear at https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/powerpc-ptrace-user_regset_copyin_ignore-always-returns-0.patch This patch will later appear in the mm-nonmm-unstable branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next via the mm-everything branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm and is updated there every 2-3 working days ------------------------------------------------------ From: Sergey Shtylyov Subject: powerpc: ptrace: user_regset_copyin_ignore() always returns 0 Date: Sat, 15 Oct 2022 00:22:32 +0300 user_regset_copyin_ignore() always returns 0, so checking its result seems pointless -- don't do this anymore... Link: https://lkml.kernel.org/r/20221014212235.10770-11-s.shtylyov@omp.ru Signed-off-by: Sergey Shtylyov Cc: Brian Cain Cc: Catalin Marinas Cc: Christophe Leroy Cc: David S. Miller Cc: Dinh Nguyen Cc: Helge Deller Cc: James Bottomley Cc: Jonas Bonn Cc: Michael Ellerman Cc: Nicholas Piggin Cc: Oleg Nesterov Cc: Rich Felker Cc: Russell King Cc: Stafford Horne Cc: Stefan Kristiansson Cc: Thomas Bogendoerfer Cc: Will Deacon Cc: Yoshinori Sato Signed-off-by: Andrew Morton --- arch/powerpc/kernel/ptrace/ptrace-tm.c | 10 +++++----- arch/powerpc/kernel/ptrace/ptrace-view.c | 10 +++++----- 2 files changed, 10 insertions(+), 10 deletions(-) --- a/arch/powerpc/kernel/ptrace/ptrace-tm.c~powerpc-ptrace-user_regset_copyin_ignore-always-returns-0 +++ a/arch/powerpc/kernel/ptrace/ptrace-tm.c @@ -170,9 +170,9 @@ int tm_cgpr_set(struct task_struct *targ (PT_MAX_PUT_REG + 1) * sizeof(reg)); if (PT_MAX_PUT_REG + 1 < PT_TRAP && !ret) - ret = user_regset_copyin_ignore(&pos, &count, &kbuf, &ubuf, - (PT_MAX_PUT_REG + 1) * sizeof(reg), - PT_TRAP * sizeof(reg)); + user_regset_copyin_ignore(&pos, &count, &kbuf, &ubuf, + (PT_MAX_PUT_REG + 1) * sizeof(reg), + PT_TRAP * sizeof(reg)); if (!ret && count > 0) { ret = user_regset_copyin(&pos, &count, &kbuf, &ubuf, ®, @@ -183,8 +183,8 @@ int tm_cgpr_set(struct task_struct *targ } if (!ret) - ret = user_regset_copyin_ignore(&pos, &count, &kbuf, &ubuf, - (PT_TRAP + 1) * sizeof(reg), -1); + user_regset_copyin_ignore(&pos, &count, &kbuf, &ubuf, + (PT_TRAP + 1) * sizeof(reg), -1); return ret; } --- a/arch/powerpc/kernel/ptrace/ptrace-view.c~powerpc-ptrace-user_regset_copyin_ignore-always-returns-0 +++ a/arch/powerpc/kernel/ptrace/ptrace-view.c @@ -267,9 +267,9 @@ static int gpr_set(struct task_struct *t (PT_MAX_PUT_REG + 1) * sizeof(reg)); if (PT_MAX_PUT_REG + 1 < PT_TRAP && !ret) - ret = user_regset_copyin_ignore(&pos, &count, &kbuf, &ubuf, - (PT_MAX_PUT_REG + 1) * sizeof(reg), - PT_TRAP * sizeof(reg)); + user_regset_copyin_ignore(&pos, &count, &kbuf, &ubuf, + (PT_MAX_PUT_REG + 1) * sizeof(reg), + PT_TRAP * sizeof(reg)); if (!ret && count > 0) { ret = user_regset_copyin(&pos, &count, &kbuf, &ubuf, ®, @@ -280,8 +280,8 @@ static int gpr_set(struct task_struct *t } if (!ret) - ret = user_regset_copyin_ignore(&pos, &count, &kbuf, &ubuf, - (PT_TRAP + 1) * sizeof(reg), -1); + user_regset_copyin_ignore(&pos, &count, &kbuf, &ubuf, + (PT_TRAP + 1) * sizeof(reg), -1); return ret; } _ Patches currently in -mm which might be from s.shtylyov@omp.ru are arc-ptrace-user_regset_copyin_ignore-always-returns-0.patch arm-ptrace-user_regset_copyin_ignore-always-returns-0.patch arm64-ptrace-user_regset_copyin_ignore-always-returns-0.patch hexagon-ptrace-user_regset_copyin_ignore-always-returns-0.patch ia64-ptrace-user_regset_copyin_ignore-always-returns-0.patch mips-ptrace-user_regset_copyin_ignore-always-returns-0.patch nios2-ptrace-user_regset_copyin_ignore-always-returns-0.patch openrisc-ptrace-user_regset_copyin_ignore-always-returns-0.patch parisc-ptrace-user_regset_copyin_ignore-always-returns-0.patch powerpc-ptrace-user_regset_copyin_ignore-always-returns-0.patch sh-ptrace-user_regset_copyin_ignore-always-returns-0.patch sparc-ptrace-user_regset_copyin_ignore-always-returns-0.patch regset-make-user_regset_copyin_ignore-void.patch