From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9351CC43217 for ; Mon, 17 Oct 2022 00:25:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229933AbiJQAZC (ORCPT ); Sun, 16 Oct 2022 20:25:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42214 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229970AbiJQAYy (ORCPT ); Sun, 16 Oct 2022 20:24:54 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6509A1AF05 for ; Sun, 16 Oct 2022 17:24:43 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 1E469B80E2B for ; Mon, 17 Oct 2022 00:24:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B9CFEC433C1; Mon, 17 Oct 2022 00:24:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1665966280; bh=1vM+bwz3pkic4l+zXCrRDgEkGkK2Ksxjwqlluo06A7g=; h=Date:To:From:Subject:From; b=dhdg/ml9CzGPUImToXArmNG1dBt4rEKP8/M/T/4ZsF57yFmJ3AWQdSuPlssly4jEb G/QHb7QZkByl0v0mLnthSRj8PFLjiq1VPYNXMZWeTCIb4n/lTC4Az8Yzj97xXRJKY7 kRQZj99vIEdYkIq1TKajR5SOaqdMcGWiAiUTEwpA= Date: Sun, 16 Oct 2022 17:24:40 -0700 To: mm-commits@vger.kernel.org, ysato@users.osdn.me, will@kernel.org, tsbogend@alpha.franken.de, stefan.kristiansson@saunalahti.fi, shorne@gmail.com, oleg@redhat.com, npiggin@gmail.com, mpe@ellerman.id.au, linux@armlinux.org.uk, jonas@southpole.se, James.Bottomley@HansenPartnership.com, dinguyen@kernel.org, deller@gmx.de, davem@davemloft.net, dalias@libc.org, christophe.leroy@csgroup.eu, catalin.marinas@arm.com, bcain@quicinc.com, s.shtylyov@omp.ru, akpm@linux-foundation.org From: Andrew Morton Subject: + sparc-ptrace-user_regset_copyin_ignore-always-returns-0.patch added to mm-nonmm-unstable branch Message-Id: <20221017002440.B9CFEC433C1@smtp.kernel.org> Precedence: bulk Reply-To: linux-kernel@vger.kernel.org List-ID: X-Mailing-List: mm-commits@vger.kernel.org The patch titled Subject: sparc: ptrace: user_regset_copyin_ignore() always returns 0 has been added to the -mm mm-nonmm-unstable branch. Its filename is sparc-ptrace-user_regset_copyin_ignore-always-returns-0.patch This patch will shortly appear at https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/sparc-ptrace-user_regset_copyin_ignore-always-returns-0.patch This patch will later appear in the mm-nonmm-unstable branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next via the mm-everything branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm and is updated there every 2-3 working days ------------------------------------------------------ From: Sergey Shtylyov Subject: sparc: ptrace: user_regset_copyin_ignore() always returns 0 Date: Sat, 15 Oct 2022 00:22:34 +0300 user_regset_copyin_ignore() always returns 0, so checking its result seems pointless -- don't do this anymore... Link: https://lkml.kernel.org/r/20221014212235.10770-13-s.shtylyov@omp.ru Signed-off-by: Sergey Shtylyov Cc: Brian Cain Cc: Catalin Marinas Cc: Christophe Leroy Cc: David S. Miller Cc: Dinh Nguyen Cc: Helge Deller Cc: James Bottomley Cc: Jonas Bonn Cc: Michael Ellerman Cc: Nicholas Piggin Cc: Oleg Nesterov Cc: Rich Felker Cc: Russell King Cc: Stafford Horne Cc: Stefan Kristiansson Cc: Thomas Bogendoerfer Cc: Will Deacon Cc: Yoshinori Sato Signed-off-by: Andrew Morton --- arch/sparc/kernel/ptrace_32.c | 9 +++++---- arch/sparc/kernel/ptrace_64.c | 23 +++++++++++------------ 2 files changed, 16 insertions(+), 16 deletions(-) --- a/arch/sparc/kernel/ptrace_32.c~sparc-ptrace-user_regset_copyin_ignore-always-returns-0 +++ a/arch/sparc/kernel/ptrace_32.c @@ -158,8 +158,9 @@ static int genregs32_set(struct task_str 35 * sizeof(u32), 36 * sizeof(u32)); if (ret || !count) return ret; - return user_regset_copyin_ignore(&pos, &count, &kbuf, &ubuf, - 36 * sizeof(u32), 38 * sizeof(u32)); + user_regset_copyin_ignore(&pos, &count, &kbuf, &ubuf, 36 * sizeof(u32), + 38 * sizeof(u32)); + return 0; } static int fpregs32_get(struct task_struct *target, @@ -203,8 +204,8 @@ static int fpregs32_set(struct task_stru 33 * sizeof(u32), 34 * sizeof(u32)); if (!ret) - ret = user_regset_copyin_ignore(&pos, &count, &kbuf, &ubuf, - 34 * sizeof(u32), -1); + user_regset_copyin_ignore(&pos, &count, &kbuf, &ubuf, + 34 * sizeof(u32), -1); return ret; } --- a/arch/sparc/kernel/ptrace_64.c~sparc-ptrace-user_regset_copyin_ignore-always-returns-0 +++ a/arch/sparc/kernel/ptrace_64.c @@ -332,8 +332,8 @@ static int genregs64_set(struct task_str } if (!ret) - ret = user_regset_copyin_ignore(&pos, &count, &kbuf, &ubuf, - 36 * sizeof(u64), -1); + user_regset_copyin_ignore(&pos, &count, &kbuf, &ubuf, + 36 * sizeof(u64), -1); return ret; } @@ -406,8 +406,8 @@ static int fpregs64_set(struct task_stru task_thread_info(target)->fpsaved[0] = fprs; if (!ret) - ret = user_regset_copyin_ignore(&pos, &count, &kbuf, &ubuf, - 35 * sizeof(u64), -1); + user_regset_copyin_ignore(&pos, &count, &kbuf, &ubuf, + 35 * sizeof(u64), -1); return ret; } @@ -473,10 +473,8 @@ static int setregs64_set(struct task_str 15 * sizeof(u64)); if (ret) return ret; - ret =user_regset_copyin_ignore(&pos, &count, &kbuf, &ubuf, - 15 * sizeof(u64), 16 * sizeof(u64)); - if (ret) - return ret; + user_regset_copyin_ignore(&pos, &count, &kbuf, &ubuf, + 15 * sizeof(u64), 16 * sizeof(u64)); /* TSTATE */ ret = user_regset_copyin(&pos, &count, &kbuf, &ubuf, &tstate, @@ -670,8 +668,9 @@ finish: pos *= sizeof(reg); count *= sizeof(reg); - return user_regset_copyin_ignore(&pos, &count, &kbuf, &ubuf, - 38 * sizeof(reg), -1); + user_regset_copyin_ignore(&pos, &count, &kbuf, &ubuf, + 38 * sizeof(reg), -1); + return 0; } static int fpregs32_get(struct task_struct *target, @@ -737,8 +736,8 @@ static int fpregs32_set(struct task_stru task_thread_info(target)->fpsaved[0] = fprs; if (!ret) - ret = user_regset_copyin_ignore(&pos, &count, &kbuf, &ubuf, - 34 * sizeof(u32), -1); + user_regset_copyin_ignore(&pos, &count, &kbuf, &ubuf, + 34 * sizeof(u32), -1); return ret; } _ Patches currently in -mm which might be from s.shtylyov@omp.ru are arc-ptrace-user_regset_copyin_ignore-always-returns-0.patch arm-ptrace-user_regset_copyin_ignore-always-returns-0.patch arm64-ptrace-user_regset_copyin_ignore-always-returns-0.patch hexagon-ptrace-user_regset_copyin_ignore-always-returns-0.patch ia64-ptrace-user_regset_copyin_ignore-always-returns-0.patch mips-ptrace-user_regset_copyin_ignore-always-returns-0.patch nios2-ptrace-user_regset_copyin_ignore-always-returns-0.patch openrisc-ptrace-user_regset_copyin_ignore-always-returns-0.patch parisc-ptrace-user_regset_copyin_ignore-always-returns-0.patch powerpc-ptrace-user_regset_copyin_ignore-always-returns-0.patch sh-ptrace-user_regset_copyin_ignore-always-returns-0.patch sparc-ptrace-user_regset_copyin_ignore-always-returns-0.patch regset-make-user_regset_copyin_ignore-void.patch