From: Kees Cook <keescook@chromium.org>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: "Guilherme G. Piccoli" <gpiccoli@igalia.com>,
Anton Vorontsov <anton@enomsg.org>,
Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH] pstore: migrate to crypto acomp interface (take 2)
Date: Mon, 17 Oct 2022 13:11:23 -0700 [thread overview]
Message-ID: <202210171307.32A5D9C07@keescook> (raw)
In-Reply-To: <CAMj1kXGmsJNg7En-55aRF+ApicPD_Opkh8Jw+oTorSOSO+cfuw@mail.gmail.com>
On Mon, Oct 17, 2022 at 09:45:08PM +0200, Ard Biesheuvel wrote:
> On Mon, 17 Oct 2022 at 21:40, Kees Cook <keescook@chromium.org> wrote:
> > Okay, so strictly speaking, eliminating the per-CPU allocation is an
> > improvement. Keeping scomp and doing in-place compression will let
> > pstore use "any" compressions method.
>
> I'm not following the point you are making here.
Sorry, I mean to say that if I leave scomp in pstore, nothing is "worse"
(i.e. the per-cpu allocation is present in both scomp and acomp). i.e.
no regression either way, but if we switch to a distinct library call,
it's an improvement on the memory utilization front.
> > Is there a crypto API that does _not_ preallocate the per-CPU stuff?
> > Because, as you say, it's a huge amount of memory on the bigger
> > systems...
>
> The library interface for each of the respective algorithms.
Where is the crypto API for just using the library interfaces, so I
don't have to be tied to a specific algo?
--
Kees Cook
next prev parent reply other threads:[~2022-10-17 20:14 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-06 23:41 [PATCH] pstore: migrate to crypto acomp interface (take 2) Kees Cook
2022-10-06 23:45 ` Kees Cook
2022-10-07 18:46 ` Guilherme G. Piccoli
2022-10-17 16:26 ` Guilherme G. Piccoli
2022-10-17 18:01 ` Kees Cook
2022-10-17 18:14 ` Ard Biesheuvel
2022-10-17 18:22 ` Guilherme G. Piccoli
2022-10-17 19:11 ` Ard Biesheuvel
2022-10-17 19:29 ` Kees Cook
2022-10-17 19:33 ` Ard Biesheuvel
2022-10-17 19:40 ` Kees Cook
2022-10-17 19:45 ` Ard Biesheuvel
2022-10-17 20:11 ` Kees Cook [this message]
2022-10-17 20:13 ` Ard Biesheuvel
2022-10-17 20:35 ` Kees Cook
2022-10-17 21:01 ` Ard Biesheuvel
2022-10-17 21:10 ` Guilherme G. Piccoli
2022-10-17 21:16 ` Ard Biesheuvel
2022-10-17 21:25 ` Guilherme G. Piccoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202210171307.32A5D9C07@keescook \
--to=keescook@chromium.org \
--cc=anton@enomsg.org \
--cc=ardb@kernel.org \
--cc=ccross@android.com \
--cc=gpiccoli@igalia.com \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.