From: Christoph Hellwig <hch@lst.de>
To: Chao Leng <lengchao@huawei.com>
Cc: linux-nvme@lists.infradead.org, linux-block@vger.kernel.org,
hch@lst.de, sagi@grimberg.me, kbusch@kernel.org,
ming.lei@redhat.com, axboe@kernel.dk,
"Paul E. McKenney" <paulmck@kernel.org>
Subject: Re: [PATCH v2 1/2] blk-mq: add tagset quiesce interface
Date: Mon, 17 Oct 2022 15:42:44 +0200 [thread overview]
Message-ID: <20221017134244.GA24775@lst.de> (raw)
In-Reply-To: <20221017133906.GA24492@lst.de>
On Mon, Oct 17, 2022 at 03:39:06PM +0200, Christoph Hellwig wrote:
> Having to allocate a struct rcu_synchronize for each of the potentially
> many queues here is a bit sad.
>
> Pull just explained the start_poll_synchronize_rcu interfaces at ALPSS
> last week, so I wonder if something like that would also be feasible
> for SRCU, as that would come in really handy here.
Alternatively I wonder if we could simply use a single srcu_struct
in the tag_set instead of one per-queue. That would potentially
increase the number of read side critical sections
blk_mq_wait_quiesce_done would have to wait for in tagsets with
multiple queues, but I wonder how much overhead that would be in
practive.
next prev parent reply other threads:[~2022-10-17 13:42 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-13 9:44 [PATCH v2 0/2] improve nvme quiesce time for large amount of namespaces Chao Leng
2022-10-13 9:44 ` [PATCH v2 1/2] blk-mq: add tagset quiesce interface Chao Leng
2022-10-13 10:28 ` Sagi Grimberg
2022-10-14 2:09 ` Chao Leng
2022-10-17 13:43 ` Christoph Hellwig
2022-10-18 9:51 ` Chao Leng
2022-10-17 13:39 ` Christoph Hellwig
2022-10-17 13:42 ` Christoph Hellwig [this message]
2022-10-18 8:39 ` Sagi Grimberg
2022-10-18 8:55 ` Christoph Hellwig
2022-10-18 9:06 ` Sagi Grimberg
2022-10-18 11:05 ` Christoph Hellwig
2022-10-18 9:52 ` Chao Leng
2022-10-17 15:21 ` Paul E. McKenney
2022-10-17 15:31 ` Christoph Hellwig
2022-10-17 22:41 ` Paul E. McKenney
2022-10-18 5:19 ` Christoph Hellwig
2022-10-19 0:35 ` Ming Lei
2022-10-19 7:15 ` Sagi Grimberg
2022-10-19 7:25 ` Christoph Hellwig
2022-10-19 7:27 ` Christoph Hellwig
2022-10-19 7:30 ` Sagi Grimberg
2022-10-19 7:32 ` Christoph Hellwig
2022-10-19 7:57 ` Sagi Grimberg
2022-10-19 8:17 ` Christoph Hellwig
2022-10-19 8:29 ` Sagi Grimberg
2022-10-18 9:52 ` Chao Leng
2022-10-18 15:04 ` Paul E. McKenney
2022-10-19 2:39 ` Chao Leng
2022-10-18 9:52 ` Chao Leng
2022-10-13 9:44 ` [PATCH v2 2/2] nvme: use blk_mq_[un]quiesce_tagset Chao Leng
2022-10-13 10:22 ` Sagi Grimberg
2022-10-14 2:09 ` Chao Leng
2022-10-17 13:48 ` Christoph Hellwig
2022-10-13 14:32 ` [PATCH v2 0/2] improve nvme quiesce time for large amount of namespaces Chaitanya Kulkarni
2022-10-14 2:12 ` Chao Leng
2022-10-15 0:30 ` Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221017134244.GA24775@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=kbusch@kernel.org \
--cc=lengchao@huawei.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=ming.lei@redhat.com \
--cc=paulmck@kernel.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.