All of lore.kernel.org
 help / color / mirror / Atom feed
From: Natalia Petrova <n.petrova@fintech.ru>
To: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>,
	"Jason Gunthorpe" <jgg@ziepe.ca>,
	Leon Romanovsky <leon@kernel.org>
Cc: Natalia Petrova <n.petrova@fintech.ru>,
	<linux-rdma@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<ldv-project@linuxtesting.org>,
	"Alexey Khoroshilov" <khoroshilov@ispras.ru>
Subject: [PATCH] rdmavt: avoid NULL pointer dereference in rvt_qp_exit()
Date: Mon, 17 Oct 2022 17:26:52 +0300	[thread overview]
Message-ID: <20221017142652.13906-1-n.petrova@fintech.ru> (raw)

rvt_qp_exit() checks 'rdi->qp_dev' for NULL, but the pointer is
dereferenced before that in rvt_free_all_qps().

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: f92e48718889 ("IB/rdmavt: Reset all QPs when the device is shut
down")
Signed-off-by: Natalia Petrova <n.petrova@fintech.ru>
Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
---
 drivers/infiniband/sw/rdmavt/qp.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/drivers/infiniband/sw/rdmavt/qp.c b/drivers/infiniband/sw/rdmavt/qp.c
index 3acab569fbb9..06e755975f61 100644
--- a/drivers/infiniband/sw/rdmavt/qp.c
+++ b/drivers/infiniband/sw/rdmavt/qp.c
@@ -459,13 +459,16 @@ static unsigned rvt_free_all_qps(struct rvt_dev_info *rdi)
  */
 void rvt_qp_exit(struct rvt_dev_info *rdi)
 {
-	u32 qps_inuse = rvt_free_all_qps(rdi);
+	u32 qps_inuse = 0;
+
+	if (!rdi->qp_dev)
+		return;
+
+	qps_inuse = rvt_free_all_qps(rdi);
 
 	if (qps_inuse)
 		rvt_pr_err(rdi, "QP memory leak! %u still in use\n",
 			   qps_inuse);
-	if (!rdi->qp_dev)
-		return;
 
 	kfree(rdi->qp_dev->qp_table);
 	free_qpn_table(&rdi->qp_dev->qpn_table);
-- 
2.34.1


             reply	other threads:[~2022-10-17 14:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-17 14:26 Natalia Petrova [this message]
2022-10-18  8:41 ` [PATCH] rdmavt: avoid NULL pointer dereference in rvt_qp_exit() Leon Romanovsky
2022-10-18 14:24   ` Dennis Dalessandro
2023-03-03 12:44     ` [PATCH v2] rdmavt: delete unnecessary NULL check Natalia Petrova
2023-03-14  9:26       ` Leon Romanovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221017142652.13906-1-n.petrova@fintech.ru \
    --to=n.petrova@fintech.ru \
    --cc=dennis.dalessandro@cornelisnetworks.com \
    --cc=jgg@ziepe.ca \
    --cc=khoroshilov@ispras.ru \
    --cc=ldv-project@linuxtesting.org \
    --cc=leon@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.