Re: [PATCH v4 01/10] acpi/tests/avocado/bits: initial commit of test scripts that are run by biosbits

["Michael S. Tsirkin" <mst@redhat.com>]

On Mon, Oct 17, 2022 at 11:13:55PM +0200, Philippe Mathieu-Daudé wrote:
> On 14/10/22 19:34, Ani Sinha wrote:
> > This is initial commit of cpuid, acpi and smbios python test scripts for
> > biosbits to execute. No change has been made to them from the original code
> > written by the biosbits author Josh Triplett. They are required to be installed
> > into the bits iso file and then run from within the virtual machine booted off
> > with biosbits iso.
> > 
> > The test scripts have a ".py2" extension in order to prevent avocado from
> > loading them. They are written in python 2.7 and are run from within bios bits.
> > There is no need for avocado to try to load them and call out errors on python3
> > specific syntaxes.
> > 
> > The original location of these tests are here:
> > https://github.com/biosbits/bits/blob/master/python/testacpi.py
> > https://github.com/biosbits/bits/blob/master/python/smbios.py
> > https://github.com/biosbits/bits/blob/master/python/testcpuid.py
> > 
> > For QEMU, we maintain a fork of the above repo here with numerious fixes:
> > https://gitlab.com/qemu-project/biosbits-bits
> > 
> > The acpi test for example is maintained here in the fork:
> > https://gitlab.com/qemu-project/biosbits-bits/-/raw/master/python/testacpi.py
> 
> I missed the previous iterations of this series, and wonder why copy
> these files in QEMU repository if they already are in a forked
> repository. Why not add the fork as a submodule?

People don't want to use submodules because their default
configuration in git is broken and git devs don't seem to
be willing to change this. Look for "submodules" in qemu archives.

> > Cc: Daniel P. Berrangé <berrange@redhat.com>
> > Cc: Paolo Bonzini <pbonzini@redhat.com>
> > Cc: Maydell Peter <peter.maydell@linaro.org>
> > Cc: John Snow <jsnow@redhat.com>
> > Cc: Thomas Huth <thuth@redhat.com>
> > Cc: Alex Bennée <alex.bennee@linaro.org>
> > Cc: Igor Mammedov <imammedo@redhat.com>
> > Cc: Michael Tsirkin <mst@redhat.com>
> > Signed-off-by: Ani Sinha <ani@anisinha.ca>
> > ---
> >   tests/avocado/acpi-bits/bits-tests/smbios.py2 | 2430 +++++++++++++++++
> >   .../avocado/acpi-bits/bits-tests/testacpi.py2 |  283 ++
> >   .../acpi-bits/bits-tests/testcpuid.py2        |   83 +
> >   3 files changed, 2796 insertions(+)
> >   create mode 100644 tests/avocado/acpi-bits/bits-tests/smbios.py2
> >   create mode 100644 tests/avocado/acpi-bits/bits-tests/testacpi.py2
> >   create mode 100644 tests/avocado/acpi-bits/bits-tests/testcpuid.py2