From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Date: Mon, 17 Oct 2022 13:51:38 -0500 Subject: [PATCH linux v2 1/3] spi: dt-bindings: aspeed: Add a ranges property In-Reply-To: <20221017091624.130227-2-clg@kaod.org> References: <20221017091624.130227-1-clg@kaod.org> <20221017091624.130227-2-clg@kaod.org> Message-ID: <20221017185138.GA2264550-robh@kernel.org> List-Id: To: linux-aspeed@lists.ozlabs.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Mon, Oct 17, 2022 at 11:16:22AM +0200, C?dric Le Goater wrote: > "ranges" predefines settings for the decoding ranges of each CS. Please explain the problem, not what the change is. > Cc: Naresh Solanki > Cc: Chin-Ting Kuo > Signed-off-by: C?dric Le Goater > --- > .../devicetree/bindings/spi/aspeed,ast2600-fmc.yaml | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/Documentation/devicetree/bindings/spi/aspeed,ast2600-fmc.yaml b/Documentation/devicetree/bindings/spi/aspeed,ast2600-fmc.yaml > index fa8f4ac20985..a11cbc4c4c5c 100644 > --- a/Documentation/devicetree/bindings/spi/aspeed,ast2600-fmc.yaml > +++ b/Documentation/devicetree/bindings/spi/aspeed,ast2600-fmc.yaml > @@ -38,6 +38,14 @@ properties: > interrupts: > maxItems: 1 > > + ranges: > + minItems: 1 > + maxItems: 5 > + description: | > + Defines the address mapping for child devices with four integer > + values for each chip-select line in use: > + 0 > + > required: > - compatible > - reg > @@ -58,6 +66,7 @@ examples: > compatible = "aspeed,ast2600-fmc"; > clocks = <&syscon ASPEED_CLK_AHB>; > interrupts = ; > + ranges = <0 0 0x20000000 0x2000000>, <1 0 0x22000000 0x2000000>; By having ranges here, 'reg' in child nodes become translatable addresses. But they are not because they are SPI chip-selects. Only memory mapped addresses should be translatable. Probably the ranges here should be in 'reg' of the controller. > > flash at 0 { > reg = < 0 >; > -- > 2.37.3 > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D11AC43217 for ; Mon, 17 Oct 2022 18:51:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230162AbiJQSvl (ORCPT ); Mon, 17 Oct 2022 14:51:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38104 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229520AbiJQSvk (ORCPT ); Mon, 17 Oct 2022 14:51:40 -0400 Received: from mail-oa1-f45.google.com (mail-oa1-f45.google.com [209.85.160.45]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 24617691A5; Mon, 17 Oct 2022 11:51:39 -0700 (PDT) Received: by mail-oa1-f45.google.com with SMTP id 586e51a60fabf-1364357a691so14292550fac.7; Mon, 17 Oct 2022 11:51:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GiJGN1wykXSQ00DVk7YPI2dlZqV1IWIoUviA+sQDHg0=; b=aFFM2cj8FVKLO9WHUnLln9BHixgHauwrvUFIze8pEmvCiee4au5WZBJL/amWOOlZx3 +LT7FZju2fq/N5Gnkv3I8PEfYZg++eO6+MMrmfGgtCVHy5oKSemQNOb04J0mywrLGZFR chRtqL6plb7xCKZjwQDVA8eEGTiyozAva71gAXUM0ZpL5sZDKI2UGqUq4eq8+XWNqHYy qJsLQ3WPFTDxjsqWIO5i92HvjL094k04XEBY3n7YuWohHJrf3hjsPuaDV67/iVNeBOeO V+4dLRgb7Cj07FUmYYTrEuoMNp4xDLhdLx5HmyJiurjHfSRcvWibBJI0AWjxdHtpHGNN RpNA== X-Gm-Message-State: ACrzQf1ArwvWRoKvQ5zOfREto6TRSdBge5AN49NElSMr0BjfchJa+9Mz Rnia/gBSwDSSvNn4oaGViDUu+kQT4g== X-Google-Smtp-Source: AMsMyM6U30yroNpKFEKjCm7TCa6yB+1N8pcSiQ3DbD3vbcRuDFpLFvQGdmxPGsO1PpfLcrfrsqc6TQ== X-Received: by 2002:a05:6870:6488:b0:131:a45b:a8ca with SMTP id cz8-20020a056870648800b00131a45ba8camr6395086oab.260.1666032698384; Mon, 17 Oct 2022 11:51:38 -0700 (PDT) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id 52-20020a9d0bb7000000b006619f38a686sm5073054oth.56.2022.10.17.11.51.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Oct 2022 11:51:37 -0700 (PDT) Received: (nullmailer pid 2273470 invoked by uid 1000); Mon, 17 Oct 2022 18:51:38 -0000 Date: Mon, 17 Oct 2022 13:51:38 -0500 From: Rob Herring To: =?iso-8859-1?Q?C=E9dric?= Le Goater Cc: linux-spi@vger.kernel.org, Mark Brown , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, Joel Stanley , Andrew Jeffery , Chin-Ting Kuo , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Naresh Solanki Subject: Re: [PATCH linux v2 1/3] spi: dt-bindings: aspeed: Add a ranges property Message-ID: <20221017185138.GA2264550-robh@kernel.org> References: <20221017091624.130227-1-clg@kaod.org> <20221017091624.130227-2-clg@kaod.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221017091624.130227-2-clg@kaod.org> Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org On Mon, Oct 17, 2022 at 11:16:22AM +0200, Cédric Le Goater wrote: > "ranges" predefines settings for the decoding ranges of each CS. Please explain the problem, not what the change is. > Cc: Naresh Solanki > Cc: Chin-Ting Kuo > Signed-off-by: Cédric Le Goater > --- > .../devicetree/bindings/spi/aspeed,ast2600-fmc.yaml | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/Documentation/devicetree/bindings/spi/aspeed,ast2600-fmc.yaml b/Documentation/devicetree/bindings/spi/aspeed,ast2600-fmc.yaml > index fa8f4ac20985..a11cbc4c4c5c 100644 > --- a/Documentation/devicetree/bindings/spi/aspeed,ast2600-fmc.yaml > +++ b/Documentation/devicetree/bindings/spi/aspeed,ast2600-fmc.yaml > @@ -38,6 +38,14 @@ properties: > interrupts: > maxItems: 1 > > + ranges: > + minItems: 1 > + maxItems: 5 > + description: | > + Defines the address mapping for child devices with four integer > + values for each chip-select line in use: > + 0 > + > required: > - compatible > - reg > @@ -58,6 +66,7 @@ examples: > compatible = "aspeed,ast2600-fmc"; > clocks = <&syscon ASPEED_CLK_AHB>; > interrupts = ; > + ranges = <0 0 0x20000000 0x2000000>, <1 0 0x22000000 0x2000000>; By having ranges here, 'reg' in child nodes become translatable addresses. But they are not because they are SPI chip-selects. Only memory mapped addresses should be translatable. Probably the ranges here should be in 'reg' of the controller. > > flash@0 { > reg = < 0 >; > -- > 2.37.3 > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 74728C4332F for ; Mon, 17 Oct 2022 18:52:23 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4MrmM92G6vz3ds9 for ; Tue, 18 Oct 2022 05:52:21 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=209.85.160.45; helo=mail-oa1-f45.google.com; envelope-from=robherring2@gmail.com; receiver=) Received: from mail-oa1-f45.google.com (mail-oa1-f45.google.com [209.85.160.45]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4MrmLR0sKpz3bb2; Tue, 18 Oct 2022 05:51:40 +1100 (AEDT) Received: by mail-oa1-f45.google.com with SMTP id 586e51a60fabf-132b8f6f1b2so14265056fac.11; Mon, 17 Oct 2022 11:51:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GiJGN1wykXSQ00DVk7YPI2dlZqV1IWIoUviA+sQDHg0=; b=nFE7vGVeqX5bc19hpSLF8O1RX1SRxKihMrjh6SQOCdaA0ty3FdulNqyD2ZEegcGAOZ oxNKlcLYIpZWZwu1ua/mQeRk0tyM2jJ5LbBd2u3aXO37Cdgcll2leGy6f+oKn07A3JL4 kFrSQLuNMHjqfgO7VANsMZPJsU7dXN1pHeV8XjOcl+upzGyT73eQtQAqXZas+IyoEWBn CyVDg1n6wz2ZX/PaMQhnYuaZktXYKnGz1/hmxRk8LOHO1bIg4JC0JAccgFwpwssy1n/i Sxf2yW3BI7KfV1/Zloef/Div3dU5YaIblonKY70gYs6eED5W6JPVDAjk6ArEhCiL9qfF Q/eA== X-Gm-Message-State: ACrzQf3OW4ZRlbOUt2AzjopmYSCUXLQ60I4vnkZ+IhVXqgNWZAvULZjW wiucR4bYuNDVaRqPu44Znw== X-Google-Smtp-Source: AMsMyM6U30yroNpKFEKjCm7TCa6yB+1N8pcSiQ3DbD3vbcRuDFpLFvQGdmxPGsO1PpfLcrfrsqc6TQ== X-Received: by 2002:a05:6870:6488:b0:131:a45b:a8ca with SMTP id cz8-20020a056870648800b00131a45ba8camr6395086oab.260.1666032698384; Mon, 17 Oct 2022 11:51:38 -0700 (PDT) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id 52-20020a9d0bb7000000b006619f38a686sm5073054oth.56.2022.10.17.11.51.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Oct 2022 11:51:37 -0700 (PDT) Received: (nullmailer pid 2273470 invoked by uid 1000); Mon, 17 Oct 2022 18:51:38 -0000 Date: Mon, 17 Oct 2022 13:51:38 -0500 From: Rob Herring To: =?iso-8859-1?Q?C=E9dric?= Le Goater Subject: Re: [PATCH linux v2 1/3] spi: dt-bindings: aspeed: Add a ranges property Message-ID: <20221017185138.GA2264550-robh@kernel.org> References: <20221017091624.130227-1-clg@kaod.org> <20221017091624.130227-2-clg@kaod.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221017091624.130227-2-clg@kaod.org> X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-aspeed@lists.ozlabs.org, Andrew Jeffery , openbmc@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Mark Brown , Joel Stanley , Krzysztof Kozlowski , Naresh Solanki , Chin-Ting Kuo , linux-arm-kernel@lists.infradead.org Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" On Mon, Oct 17, 2022 at 11:16:22AM +0200, Cédric Le Goater wrote: > "ranges" predefines settings for the decoding ranges of each CS. Please explain the problem, not what the change is. > Cc: Naresh Solanki > Cc: Chin-Ting Kuo > Signed-off-by: Cédric Le Goater > --- > .../devicetree/bindings/spi/aspeed,ast2600-fmc.yaml | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/Documentation/devicetree/bindings/spi/aspeed,ast2600-fmc.yaml b/Documentation/devicetree/bindings/spi/aspeed,ast2600-fmc.yaml > index fa8f4ac20985..a11cbc4c4c5c 100644 > --- a/Documentation/devicetree/bindings/spi/aspeed,ast2600-fmc.yaml > +++ b/Documentation/devicetree/bindings/spi/aspeed,ast2600-fmc.yaml > @@ -38,6 +38,14 @@ properties: > interrupts: > maxItems: 1 > > + ranges: > + minItems: 1 > + maxItems: 5 > + description: | > + Defines the address mapping for child devices with four integer > + values for each chip-select line in use: > + 0 > + > required: > - compatible > - reg > @@ -58,6 +66,7 @@ examples: > compatible = "aspeed,ast2600-fmc"; > clocks = <&syscon ASPEED_CLK_AHB>; > interrupts = ; > + ranges = <0 0 0x20000000 0x2000000>, <1 0 0x22000000 0x2000000>; By having ranges here, 'reg' in child nodes become translatable addresses. But they are not because they are SPI chip-selects. Only memory mapped addresses should be translatable. Probably the ranges here should be in 'reg' of the controller. > > flash@0 { > reg = < 0 >; > -- > 2.37.3 > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8F88DC43217 for ; Mon, 17 Oct 2022 18:52:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9b9T5G7dZaWRlq+qMF4zQcFP7ur3ncs7J4Z3rszekM8=; b=HcVjSQwStj2wbx BiurmFEX/ES/OURQ6LLkm90wE7Ra3gXbxT4oS5QVxRTCoCjR2cEE+vewTYpqmf91p40/jn4tTk5RV DwOfr2Kf8K431JhhMimiFXvMfShdxT0pYetz6cUvUwO0XnkDUOJPZels3PKCZvjfCOlqBRbQRX15S gal1F75MVGNWWJ/ovmca/qTPrqBLAtVQdiCNpPcA99lWFNYTObAcbqOes1A2msdSUx2Pb0Hme4Ejj 8Xw/c0kJXW/Ra7E71lOCqVFref7wDXQRHwcdjF/SbR+181hYe9J49JUuKnRXjWF+vDikMgfRhb8ir 7apMUq+ZQ04Kmh2sDxjw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1okVDD-00ELcT-Nc; Mon, 17 Oct 2022 18:51:43 +0000 Received: from mail-oa1-f47.google.com ([209.85.160.47]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1okVDA-00ELbO-Ie for linux-arm-kernel@lists.infradead.org; Mon, 17 Oct 2022 18:51:41 +0000 Received: by mail-oa1-f47.google.com with SMTP id 586e51a60fabf-132af5e5543so14289505fac.8 for ; Mon, 17 Oct 2022 11:51:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GiJGN1wykXSQ00DVk7YPI2dlZqV1IWIoUviA+sQDHg0=; b=MA7Sa+fM1gQMD6Xx0Q9PBN9boHlTHsaRouUiMJPUdtyFEWormonBt4pFAaj+rVkg6e 8H+sWx1SFrtNO8SyoXiiza3bfDSKk2UwH13k5Gf8+hj+RuUXhmnWwZXMVMEvqcy0wkse i1TJe2XTUv+m8tPIOXfXYdwSJXXeYjH7mS4zvAJkP0L1spSMfktiklneKxtjQ7rS+164 epHImz2tDQWJD3NpdoOWr4D/e6B1t0SulP0CtAsft1ZPVdGaLVn6O1YjuiajhaFYo4ZD fss+zfjc7Jl7HM7v6jYyInMOhQ2kg0Nh3/NmwsyowkbHueHctxvqQYuaV0/1eM6GO2wl +TEQ== X-Gm-Message-State: ACrzQf2sKw5afM08U8WTMIY/j3JhT4pDtNXoZz9E9gsp8L/Um0r6esos B7THgzLTohlfwjOBLJwO1g== X-Google-Smtp-Source: AMsMyM6U30yroNpKFEKjCm7TCa6yB+1N8pcSiQ3DbD3vbcRuDFpLFvQGdmxPGsO1PpfLcrfrsqc6TQ== X-Received: by 2002:a05:6870:6488:b0:131:a45b:a8ca with SMTP id cz8-20020a056870648800b00131a45ba8camr6395086oab.260.1666032698384; Mon, 17 Oct 2022 11:51:38 -0700 (PDT) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id 52-20020a9d0bb7000000b006619f38a686sm5073054oth.56.2022.10.17.11.51.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Oct 2022 11:51:37 -0700 (PDT) Received: (nullmailer pid 2273470 invoked by uid 1000); Mon, 17 Oct 2022 18:51:38 -0000 Date: Mon, 17 Oct 2022 13:51:38 -0500 From: Rob Herring To: =?iso-8859-1?Q?C=E9dric?= Le Goater Cc: linux-spi@vger.kernel.org, Mark Brown , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, Joel Stanley , Andrew Jeffery , Chin-Ting Kuo , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Naresh Solanki Subject: Re: [PATCH linux v2 1/3] spi: dt-bindings: aspeed: Add a ranges property Message-ID: <20221017185138.GA2264550-robh@kernel.org> References: <20221017091624.130227-1-clg@kaod.org> <20221017091624.130227-2-clg@kaod.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221017091624.130227-2-clg@kaod.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221017_115140_632318_4BEAFC62 X-CRM114-Status: GOOD ( 15.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Oct 17, 2022 at 11:16:22AM +0200, C=E9dric Le Goater wrote: > "ranges" predefines settings for the decoding ranges of each CS. Please explain the problem, not what the change is. > Cc: Naresh Solanki > Cc: Chin-Ting Kuo > Signed-off-by: C=E9dric Le Goater > --- > .../devicetree/bindings/spi/aspeed,ast2600-fmc.yaml | 9 +++++++++ > 1 file changed, 9 insertions(+) > = > diff --git a/Documentation/devicetree/bindings/spi/aspeed,ast2600-fmc.yam= l b/Documentation/devicetree/bindings/spi/aspeed,ast2600-fmc.yaml > index fa8f4ac20985..a11cbc4c4c5c 100644 > --- a/Documentation/devicetree/bindings/spi/aspeed,ast2600-fmc.yaml > +++ b/Documentation/devicetree/bindings/spi/aspeed,ast2600-fmc.yaml > @@ -38,6 +38,14 @@ properties: > interrupts: > maxItems: 1 > = > + ranges: > + minItems: 1 > + maxItems: 5 > + description: | > + Defines the address mapping for child devices with four integer > + values for each chip-select line in use: > + 0 > + > required: > - compatible > - reg > @@ -58,6 +66,7 @@ examples: > compatible =3D "aspeed,ast2600-fmc"; > clocks =3D <&syscon ASPEED_CLK_AHB>; > interrupts =3D ; > + ranges =3D <0 0 0x20000000 0x2000000>, <1 0 0x22000000 0x2000000= >; By having ranges here, 'reg' in child nodes become translatable = addresses. But they are not because they are SPI chip-selects. Only = memory mapped addresses should be translatable. = Probably the ranges here should be in 'reg' of the controller. > = > flash@0 { > reg =3D < 0 >; > -- = > 2.37.3 > = > = _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel