Re: [Buildroot] [PATCH 3/4] package/go-bin: new package

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

On Mon, 17 Oct 2022 09:13:54 -0700
Christian Stewart <christian@paral.in> wrote:

> Instead of adding new packages...
> 
> Continue using "host-go" and add parameters under a menu config for it.
> Then you can simply use a single variable - GO_VERSION - rather than 2 new
> packages.
> 
> I'm happy to send a prototype of this if you need.

I also thought of doing this for the NodeJS package, instead of
separating host-nodejs-bin and host-nodejs-src. I went for the
virtual-package + 2 providers solution as this is what we had done with
Rust.

The main advantage I see with the single package solution is that the
version of NodeJS would be located at only one place. Although this
could also be solved by:

package/
 nodejs/
  nodejs.mk 	<= contains the version
  nodejs/   	<= virtual package
  nodejs-bin/	<= pre-compiled provider
  nodejs-src/   <= source-based provider

In my proposal I solved this duplicated version by simply having a
comment above the <pkg>_VERSION field to remind people that the other
package supporting NodeJS should be bumped at the same time.

The advantage of the 2 packages solution is obviously that each package
is simpler.

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot